Brave translate is not available for existing users after migration/upgrade when Google translate extension is pinned to toolbar

[MadhaviSeelam]

Description

When existing users pin Google translate extension to toolbar and upgrade, Brave translate bubble is not shown. Google translate extension is still available in the upgraded version. Not sure of the expected functionality

Steps to Reproduce

1. install 1.42.95
2. launch brave
3. load a French language site https://www.lemonde.fr/
4. Google Translate extension bubble is shown in the URL bar as expected
5. install Google translate extension
6. verified Google translate extension is pinned to the toolbar in the upper right corner and displayed in brave://extensions
7. close the browser but do not close the website tab
8. rename the profile folder to Beta
9. launch Brave with 1.43.67
10. confirmed Brave tranlate is enabled via griffin in Brave://versionvia BraveTranslateStudy:Enabled
11. verified toggle ON as a default for Offer to translate pages that aren't in a language you read entry in brave://settings/languages

Actual result:

Brave translate extension bubble is not shown in the URL bar
Google translate extension available in toolbar

Step4	Step 6Ex2	Step10	actual_result

Expected result:

Brave translate bubble should be shown?

Reproduces how often:

Easily

Brave version (brave://version info)

Brave	1.43.67 Chromium: 104.0.5112.81 (Official Build) beta (64-bit)
Revision	5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS	Windows 11 Version 21H2 (Build 22000.856)
JavaScript	V8 10.4.132.20

Version/Channel Information:

• Can you reproduce this issue with the current release? N/A
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the nightly channel? N/A

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@rebron @stephendonner

[atuchin-m]

@rebron it's expected behavior at time we experimented with the feature.
The reason is not avoid a double translate suggestion for users who use Goggle Translate extension.
That behavior was fixed in the original issue: #18593 (comment)

@rebron Are we ready to remove or disable the code checking the extension status? Or we need some migration for such users?

P.S. We check that the extension is enabled, not pinned.

[rebron]

@atuchin-m We can go ahead and disable the code checking status.

[stephendonner]

Verified PASSED using

Brave	1.46.86 Chromium: 107.0.5304.91 (Official Build) beta (x86_64)
Revision	3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097}
OS	macOS Version 11.7.1 (Build 20G918)

Steps:

1. installed 1.42.95
2. launched Brave
3. loaded https://russian.rt.com/
4. confirmed the Google Translate extension bubble was shown
5. clicked Install
6. clicked Add extension
7. test-translated the page
8. shut down Brave
9. renamed Brave-Browser profile folder to Brave-Browser-Beta
10. launched 1.46.86
11. confirmed I saw the Brave Translate UI and the Google Translate extension, co-existing
12. confirmed I could translate the page from Russian to English
13. opened brave://settings/languages and confirmed Use Brave Translate was set to Enabled / On by default

example	example	example	example	example	example	example	example	example

[kjozwiak]

The above requires 1.45.124 or higher for 1.45.x verification. Removing QA Pass-macOS so it can get rechecked via 1.45.x. Used the verification that @stephendonner did via #24715 (comment) for the uplift as per brave/brave-core#15888 (review).

[GeetaSarvadnya]

Verification PASSED on

Brave | 1.45.125 Chromium: 107.0.5304.110 (Official Build) (64-bit)
-- | --
Revision | 2a558545ab7e6fb8177002bf44d4fc1717cb2998-refs/branch-heads/5304@{#1202}
OS | Windows 10 Version 21H2 (Build 19044.2251)

Steps:

1. installed 1.42.95
2. launched Brave
3. loaded https://russian.rt.com/
4. confirmed the Google Translate extension bubble was shown
5. clicked Install
6. clicked Add extension
7. test-translated the page
8. shut down Brave
9. renamed Brave-Browser profile folder to Brave-Browser-Beta
10. launched 1.46.86
11. confirmed I saw the Brave Translate UI and the Google Translate extension, co-existing
12. confirmed I could translate the page from Russian to English
13. opened brave://settings/languages and confirmed Use Brave Translate was set to Enabled / On by default

1.42.95	1.42.95	1.42.95	1.45.125	1.45.125	1.45.125	1.45.125	1.45.125