Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Solana Dapp transactions in Transaction Parser #25419

Closed
Pavneet-Sing opened this issue Sep 15, 2022 · 2 comments · Fixed by brave/brave-core#15593
Closed

Support Solana Dapp transactions in Transaction Parser #25419

Pavneet-Sing opened this issue Sep 15, 2022 · 2 comments · Fixed by brave/brave-core#15593
Labels
feature/web3/wallet/dapps feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support needs-more-info The report requires more detail before we can decide what to do with this issue. OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Milestone
1.46.x - Release

Comments

@Pavneet-Sing
Copy link

Description:
Need to support two Solana dapp transaction types in our TransactionParser: SolanaDappSignAndSendTransaction & SolanaDappSignTransaction

Dependency:
Unlike desktop, Mobile doesn't have solana/web3 lib sdk to parse solana transaction so need:
@Pavneet-Sing Pavneet-Sing added QA/Yes release-notes/exclude needs-more-info The report requires more detail before we can decide what to do with this issue. OS/Android Fixes related to Android browser functionality feature/web3/wallet/solana feature/web3/wallet/dapps labels Sep 15, 2022
@srirambv srirambv added the feature/web3/wallet Integrating Ethereum+ wallet support label Sep 15, 2022
@Pavneet-Sing Pavneet-Sing added the priority/P3 The next thing for us to work on. It'll ride the trains. label Sep 16, 2022
@Pavneet-Sing Pavneet-Sing mentioned this issue Oct 21, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.47.x - Nightly milestone Oct 28, 2022
@Pavneet-Sing Pavneet-Sing mentioned this issue Nov 4, 2022
Merged
7 tasks
@kjozwiak
Copy link
Member

kjozwiak commented Nov 4, 2022

The above requires 1.46.94 or higher for 1.46.x verification 👍

@srirambv
Copy link
Contributor

srirambv commented Nov 7, 2022

Verification passed on the following devices running 1.46.96 x64 beta build

Oppo Reno 5 (Android 12) Samsung Tab A (Android 10)
25419-ARM.mp4
25419-Tab.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/web3/wallet/dapps feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support needs-more-info The report requires more detail before we can decide what to do with this issue. OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.46.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): implement solana dapps send tx brave/brave-core
4 participants
@kjozwiak @Pavneet-Sing @srirambv @brave-builds