Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wallet): implement solana dapps send tx (uplift to 1.46.x) #15798

Merged
merged 1 commit into from
Nov 4, 2022
Merged

feat(wallet): implement solana dapps send tx (uplift to 1.46.x) #15798

merged 1 commit into from
Nov 4, 2022

Conversation

Pavneet-Sing
Copy link
Contributor

@Pavneet-Sing Pavneet-Sing commented Nov 4, 2022 •
edited by kjozwiak

Uplift of #15593
Resolves brave/brave-browser#25419
Resolves brave/brave-browser#25258

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@Pavneet-Sing Pavneet-Sing requested a review from a team as a code owner November 4, 2022 10:27
@Pavneet-Sing Pavneet-Sing self-assigned this Nov 4, 2022
@Pavneet-Sing Pavneet-Sing added this to the 1.46.x - Beta milestone Nov 4, 2022
@Pavneet-Sing Pavneet-Sing added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Nov 4, 2022
kjozwiak
kjozwiak approved these changes Nov 4, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.46.x approved 👍 QA has verified the PR on Nightly as per #15593 (comment).

@kjozwiak kjozwiak merged commit 49c2fc0 into 1.46.x Nov 4, 2022
@kjozwiak kjozwiak deleted the pr15593_feat-solana-dapps-tx_1.46.x branch November 4, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@Pavneet-Sing Pavneet-Sing

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.46.x - Release
2 participants
@Pavneet-Sing @kjozwiak