Skip to content

Navigation Menu

Explore
By size
By industry
By use case
Topics
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

brave / brave-core Public

Notifications You must be signed in to change notification settings
Fork 840
Star 2.4k

Code
Pull requests 223
Actions
Security
Insights

Additional navigation options

Code
Pull requests
Actions
Security
Insights

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wallet): implement solana dapps send tx #15593

Merged

Pavneet-Sing merged 2 commits into master from feat-solana-dapps-tx

Oct 28, 2022

Merged

feat(wallet): implement solana dapps send tx #15593

Pavneet-Sing merged 2 commits into master from feat-solana-dapps-tx

Oct 28, 2022

Conversation 49 Commits 2 Checks 0 Files changed

Conversation

Copy link

Pavneet-Sing commented Oct 21, 2022 •

edited by SergeyZhukovsky

Loading

fix show wallet icon with sol dapps request

Resolves brave/brave-browser#25419
Resolves brave/brave-browser#25258

Submitter Checklist:

I confirm that no security/privacy review is needed, or that I have requested one
There is a ticket for my issue
Used Github auto-closing keywords in the PR description above
Wrote a good PR/commit description
Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
Ran git rebase master (if needed)

Reviewer Checklist:

A security review is not needed, or a link to one is included in the PR description
New files have MPL-2.0 license header
Adequate test coverage exists to prevent regressions
Major classes, functions and non-trivial code blocks are well-commented
Changes in component dependencies are properly reflected in gn
Code follows the style guide
Test plan is specified in PR before merging

After-merge Checklist:

The associated issue milestone is set to the smallest version that the
changes has landed on
All relevant documentation has been updated, for instance:

Test Plan:

solna-dapps-tx.webm

Sorry, something went wrong.

All reactions

Pavneet-Sing requested a review from SergeyZhukovsky

October 21, 2022 11:44

Pavneet-Sing self-assigned this

Pavneet-Sing requested a review from a team as a code owner

October 21, 2022 11:44

SergeyZhukovsky reviewed

View reviewed changes

android/java/org/chromium/chrome/browser/crypto_wallet/fragments/TxFragment.java Show resolved Hide resolved

SergeyZhukovsky reviewed

View reviewed changes

android/java/org/chromium/chrome/browser/crypto_wallet/fragments/TxFragment.java Outdated Show resolved Hide resolved

SergeyZhukovsky reviewed

View reviewed changes

android/java/org/chromium/chrome/browser/crypto_wallet/presenters/Amount.java Outdated Show resolved Hide resolved

SergeyZhukovsky reviewed

View reviewed changes

android/java/org/chromium/chrome/browser/crypto_wallet/presenters/Amount.java Outdated Show resolved Hide resolved

SergeyZhukovsky reviewed

View reviewed changes

...id/java/org/chromium/chrome/browser/crypto_wallet/presenters/SolanaInstructionPresenter.java Show resolved Hide resolved

SergeyZhukovsky reviewed

View reviewed changes

android/java/org/chromium/chrome/browser/crypto_wallet/util/AndroidUtils.java Show resolved Hide resolved

SergeyZhukovsky reviewed

View reviewed changes

android/java/org/chromium/chrome/browser/crypto_wallet/util/AndroidUtils.java Show resolved Hide resolved

Pavneet-Sing force-pushed the feat-solana-dapps-tx branch from b10d98c to bb099d7 Compare

October 28, 2022 07:11

Pavneet-Sing added CI/skip-linux CI/skip-macos-x64

Do not run CI builds for macOS x64

CI/skip-ios Do not run CI builds for iOS labels

Copy link

Author

Pavneet-Sing commented Oct 28, 2022

Skipping other tests expect android as only making android changes now.

All reactions

Sorry, something went wrong.

Pavneet-Sing force-pushed the feat-solana-dapps-tx branch from bb099d7 to f9a20c0 Compare

October 28, 2022 11:35

Pavneet-Sing requested review from samartnik, AlexeyBarabash and deeppandya

October 28, 2022 12:23


          feat(wallet): implement solana dapps send tx

54e2cbc

- fix show wallet icon with sol dapps request

Pavneet-Sing force-pushed the feat-solana-dapps-tx branch from f9a20c0 to 54e2cbc Compare

October 28, 2022 12:37

AlexeyBarabash reviewed

View reviewed changes

android/java/res/values/brave_styles.xml Show resolved Hide resolved

AlexeyBarabash reviewed

View reviewed changes

android/java/org/chromium/chrome/browser/crypto_wallet/fragments/TxDetailsFragment.java Show resolved Hide resolved

SergeyZhukovsky approved these changes

View reviewed changes

Copy link

Member

SergeyZhukovsky left a comment

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Sorry, something went wrong.

All reactions

AlexeyBarabash reviewed

View reviewed changes

android/java/org/chromium/chrome/browser/crypto_wallet/fragments/TxFragment.java Outdated Show resolved Hide resolved

AlexeyBarabash reviewed

View reviewed changes

...id/java/org/chromium/chrome/browser/crypto_wallet/presenters/SolanaInstructionPresenter.java Outdated Show resolved Hide resolved

AlexeyBarabash reviewed

View reviewed changes

android/java/org/chromium/chrome/browser/crypto_wallet/util/ParsedTransaction.java Show resolved Hide resolved

AlexeyBarabash reviewed

View reviewed changes

android/java/org/chromium/chrome/browser/crypto_wallet/util/ParsedTransaction.java Show resolved Hide resolved

AlexeyBarabash reviewed

View reviewed changes

android/java/org/chromium/chrome/browser/crypto_wallet/util/ParsedTransactionFees.java Show resolved Hide resolved

AlexeyBarabash approved these changes

View reviewed changes

Copy link

Contributor

AlexeyBarabash left a comment

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please wait for approval from guys who recently worked with Android wallet

Sorry, something went wrong.

All reactions

Copy link

Author

Pavneet-Sing commented Oct 28, 2022

LGTM but please wait for approval from guys who recently worked with Android wallet

That would be @SergeyZhukovsky so it's good to merge.

All reactions

Sorry, something went wrong.


          review: optimisations

a81ef9a

Pavneet-Sing force-pushed the feat-solana-dapps-tx branch from 11b346d to a81ef9a Compare

October 28, 2022 15:50

Pavneet-Sing merged commit a857b5f into master

Pavneet-Sing deleted the feat-solana-dapps-tx branch

October 28, 2022 16:30

github-actions bot added this to the 1.47.x - Nightly milestone

Pavneet-Sing pushed a commit that referenced this pull request


          Uplift of #15593 (squashed) to beta

1197d6a

Pavneet-Sing mentioned this pull request

feat(wallet): implement solana dapps send tx (uplift to 1.46.x) #15798

Merged

7 tasks

Copy link

Contributor

srirambv commented Nov 4, 2022

Verification passed on Oppo Reno 5 with Android 12 running 1.47.42 x64 Nightly build

Verified steps from PR description
Verified wallet icon is shown on URL bar when a Dapp is connected
Verified able to submit and sign transactions in Solana Dapps

15593.mp4

All reactions

Sorry, something went wrong.

srirambv mentioned this pull request

Support Solana Dapp transactions in Transaction Parser brave/brave-browser#25419

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

SergeyZhukovsky SergeyZhukovsky approved these changes

AlexeyBarabash AlexeyBarabash approved these changes

samartnik Awaiting requested review from samartnik

deeppandya Awaiting requested review from deeppandya deeppandya is a code owner

Assignees

Labels

Do not run CI builds for iOS

CI/skip-macos-x64

Do not run CI builds for macOS x64

Projects

None yet

Milestone

1.47.x - Release

4 participants

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

Footer

© 2024 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.