Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync chain should be reset when deleting another device with v2 spec #2552

Closed
darkdh opened this issue Dec 13, 2018 · 2 comments · Fixed by brave/brave-core#1109 or brave/brave-core#1191
Assignees

Comments

@darkdh
Copy link
Member

darkdh commented Dec 13, 2018

Description

Sync chain didn't get reset when there is only one device left on sync chain

Steps to Reproduce

  1. Setup sync chain on device a and device b
  2. Delete device b from device a
  3. Setup new chain on device a and connect device b to it
  4. It connect to the previous sync chain. (sync code is still same as step 1)

Actual result:

It connect to the previous sync chain. (sync code is still same as step 1)

Expected result:

Sync chain should be reset when there is only one device on sync chain

Reproduces how often:

Brave version (brave://version info)

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@darkdh darkdh added feature/sync priority/P2 A bad problem. We might uplift this to the next planned release. labels Dec 13, 2018
@cezaraugusto cezaraugusto added this to the 0.58.x - Release milestone Dec 13, 2018
cezaraugusto added a commit to brave/brave-core that referenced this issue Dec 13, 2018
@darkdh darkdh self-assigned this Dec 14, 2018
@srirambv srirambv added this to Untriaged backlog in Sync Dec 14, 2018
@darkdh darkdh moved this from Untriaged backlog to Inprogress in Sync Dec 16, 2018
@darkdh darkdh added the QA/Yes label Dec 16, 2018
Sync automation moved this from Inprogress to Completed Dec 17, 2018
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 25, 2018

Verified the STR mentioned in brave/brave-core#1109. Issue still persists hence reopening the issue.

Step 6 fails, sync code is still same as step3.

Issue is reproducible on

Brave 0.59.12 Chromium: 72.0.3626.17 (Official Build) beta (64-bit)
Revision 08d2140079f8db14c9eb885a803d231b1a30e817-refs/branch-heads/3626@{#315}
OS Windows 10

Win10 (Bravebeta 0.59.12) to Win10 (BraveDev 0.60.4)
2552

Win10 (Bravebeta 0.59.12) to Linux Mint(Bravebeta 0.59.12)
2552_ win and linux

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jan 4, 2019

Verification passed on

Brave 0.59.18 Chromium: 72.0.3626.28 (Official Build) beta (64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Windows

Verified passed with:

Brave 0.59.18 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Mac OS X

Verified passed with:

Brave 0.59.18 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment