-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makes eTLD+1 always visible on Android #15574
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diracdeltas
approved these changes
Oct 20, 2022
samartnik
approved these changes
Oct 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
samartnik
added a commit
that referenced
this pull request
Oct 21, 2022
This is adjustment for changes in master #15574
cdesouza-chromium
pushed a commit
that referenced
this pull request
Oct 24, 2022
This is adjustment for changes in master #15574
cdesouza-chromium
pushed a commit
that referenced
this pull request
Oct 25, 2022
This is adjustment for changes in master #15574
cdesouza-chromium
pushed a commit
that referenced
this pull request
Oct 26, 2022
This is adjustment for changes in master #15574
cdesouza-chromium
pushed a commit
that referenced
this pull request
Oct 27, 2022
This is adjustment for changes in master #15574
cdesouza-chromium
pushed a commit
that referenced
this pull request
Oct 28, 2022
This is adjustment for changes in master #15574
cdesouza-chromium
pushed a commit
that referenced
this pull request
Oct 28, 2022
This is adjustment for changes in master #15574
mkarolin
pushed a commit
that referenced
this pull request
Oct 31, 2022
This is adjustment for changes in master #15574
cdesouza-chromium
pushed a commit
that referenced
this pull request
Nov 2, 2022
This is adjustment for changes in master #15574
cdesouza-chromium
pushed a commit
that referenced
this pull request
Nov 2, 2022
This is adjustment for changes in master #15574
mkarolin
pushed a commit
that referenced
this pull request
Nov 3, 2022
This is adjustment for changes in master #15574
cdesouza-chromium
pushed a commit
that referenced
this pull request
Nov 4, 2022
This is adjustment for changes in master #15574
mkarolin
pushed a commit
that referenced
this pull request
Nov 4, 2022
This is adjustment for changes in master #15574
mkarolin
pushed a commit
that referenced
this pull request
Nov 11, 2022
This is adjustment for changes in master #15574
mkarolin
pushed a commit
that referenced
this pull request
Nov 14, 2022
This is adjustment for changes in master #15574
sangwoo108
pushed a commit
that referenced
this pull request
Apr 4, 2023
This is adjustment for changes in master #15574
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#26155
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Visit https://long-extended-subdomain-name-containing-many-letters-and-dashes.badssl.com/ysigsgksgkskgslgsogslgslgslgslgslgsogsogsogslgsogsyosoys
![Screenshot_20221020-144841_Brave - Nightly](https://user-images.githubusercontent.com/12011303/197034698-11d77422-5980-4891-b6c3-5c05c200fa99.jpg)
On versions before the fix observe that visible text in the URL bar
On versions after the fix observe that
![Screenshot_20221020-144816_Brave - Debug](https://user-images.githubusercontent.com/12011303/197034826-ebd53385-4374-4ebe-a04d-59b9a33f09b6.jpg)