Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable first run dialog temporarily #27225

Closed
simonhong opened this issue Dec 8, 2022 · 4 comments · Fixed by brave/brave-core#16282
Closed

Disable first run dialog temporarily #27225

simonhong opened this issue Dec 8, 2022 · 4 comments · Fixed by brave/brave-core#16282
Assignees
@simonhong
Labels
onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Milestone
1.47.x - Release

Comments

@simonhong
Copy link
Member

simonhong commented Dec 8, 2022 •
edited

Don't launch first run dialog as we'll launch new welcome flow.
If new welcome flow is more effective, we'll delete first run dialog.

  1. Launch brave with clean profile
  2. Check first run dialog is not launched
@simonhong simonhong self-assigned this Dec 8, 2022
@rebron rebron added onboarding Front-end related to helping a new user learn about features within the browser. priority/P2 A bad problem. We might uplift this to the next planned release. labels Dec 8, 2022
simonhong added a commit to brave/brave-core that referenced this issue Dec 8, 2022
@simonhong
Hide first run dialog
55e172e 
fix brave/brave-browser#27225

Temporarily hide till we have numbers from new welcome flow.
If welcome flow do better than FR dialog, we'll delete FR dialog.
@simonhong simonhong mentioned this issue Dec 8, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.48.x - Nightly milestone Dec 8, 2022
@brave-builds brave-builds mentioned this issue Dec 8, 2022
Merged
7 tasks
@rebron rebron mentioned this issue Dec 9, 2022
Closed
@rebron rebron added this to Completed in General Dec 9, 2022
@rebron rebron moved this from Completed to Pending review/uplift or retest in General Dec 13, 2022
@kjozwiak
Copy link
Member

The above requires 1.47.130 or higher for 1.47.x verification 👍

@kjozwiak kjozwiak moved this from Pending review/uplift or retest to Completed in General Dec 15, 2022
@btlechowski
Copy link

Verification passed on

Brave 1.47.132 Chromium: 108.0.5359.128 (Official Build) beta (64-bit)
Revision 1cd27afdb8e5d057070c0961e04c490d2aca1aa0-refs/branch-heads/5359@{#1185}
OS Ubuntu 18.04 LTS

Verified first run dialog is disabled on clean profile
27225

@stephendonner
Copy link

Verified PASSED using

Brave 1.47.135 Chromium: 108.0.5359.128 (Official Build) beta (x86_64)
Revision 1cd27afdb8e5d057070c0961e04c490d2aca1aa0-refs/branch-heads/5359@{#1185}
OS macOS Version 11.7.2 (Build 20G1020)

Steps:

  1. installed 1.47.135
  2. launched Brave
  3. confirmed no first-run dialog
  4. clicked Skip on the brave://welcome screen
  5. launched Brave 6x
  6. confirmed still no first-run dialog

Screencast:

no-first-run

@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.47.136 Chromium: 108.0.5359.128 (Official Build) beta (64-bit)
-- | --
Revision | 1cd27afdb8e5d057070c0961e04c490d2aca1aa0-refs/branch-heads/5359@{#1185}
OS | Windows 11 Version 21H2 (Build 22000.1335)

Steps:

new install

  • installed 1.47.136
  • launched Brave
  • confirmed no first-run dialog
  • clicked Skip on the brave://welcome screen
  • launched Brave few times
  • confirmed still no first-run dialog

image

new profile

  • launch Brave with a new profile
  • confirmed no first-run dialog
  • clicked Skip on the brave://welcome screen
  • launched Brave few times
  • confirmed still no first-run dialog

image

@MadhaviSeelam MadhaviSeelam mentioned this issue Dec 21, 2022
Closed
@rebron rebron removed this from Completed in General Jan 17, 2023
sangwoo108 pushed a commit to brave/brave-core that referenced this issue Apr 4, 2023
@simonhong @sangwoo108
Hide first run dialog
9c44b8b 
fix brave/brave-browser#27225

Temporarily hide till we have numbers from new welcome flow.
If welcome flow do better than FR dialog, we'll delete FR dialog.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.47.x - Release
Development

Successfully merging a pull request may close this issue.

Hide first run dialog brave/brave-core
8 participants
@stephendonner @kjozwiak @rebron @simonhong @LaurenWags @btlechowski @brave-builds @MadhaviSeelam