Follow up to #26542 - Brave is pinned to the taskbar upon Brave launch (when brave is NOT pinned explicitly)

[MadhaviSeelam]

Description

Currently first run dialog is disabled in Nightly and Beta. But when Brave launched first time, with or without setting Brave as a default, Brave is pinned to the taskbar. In Nightly (1.48.71), sometimes, along with pinned to taskbar, Brave icon shown as white rectangle icon.

This issue is not reproducible 100% but I have seen the issue 3 to 4 times in 3 days while dog fooding the beta build (1.46.x)

Steps to Reproduce

Scenario 1: (This mostly happens in Beta)

1. Install 1.47.136
2. launch Brave
3. context menu in the taskbar shows Brave is not pinned
4. click on a new-tab

Actual results: Context menu in the taskbar shows Brave Pinned to taskbar

Scenario 2: (This mostly happens in Nightly than Beta)

1. Install 1.48.75
2. Launch Brave

Actual results: Brave icon was pinned to the taskbar upon launch without explicitly pinned to the taskbar

Scenario 3: Brave icon not shown when pinned to the taskbar

1. Install 1.47.139
2. Launch Brave

Actual results: Sometimes, Brave icon doesn't show when it pins and instead something like white paper icon shown

Actual result:

Context menu in the taskbar shows Brave Pinned to taskbar
Scenario 1: Click a new tab
Brave Beta

Brave not pinned before	Brave pinned

Brave Nightly (1.48.75)

Brave not pinned before	Brave pinned

Scenario 2: Brave icon was pinned to the taskbar upon launch

beta	nightly

Scenario 3: Brave icon is not shown on the taskbar

Expected result:

Brave should not be pinned to taskbar upon or when clicked on a new tab.
Brave icon should be shown on the taskbar

Reproduces how often:

Most of the times

Brave version (brave://version info)

Brave | 1.47.136 Chromium: 108.0.5359.128 (Official Build) beta (64-bit)
-- | --
Revision | 1cd27afdb8e5d057070c0961e04c490d2aca1aa0-refs/branch-heads/5359@{#1185}
OS | Windows 11 Version 21H2 (Build 22000.1335)

Version/Channel Information:

• Can you reproduce this issue with the current release? N/A
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

[rebron]

cc: @simonhong

@MadhaviSeelam Is this a clean profile/browser or did you previously pin Brave to taskbar before?

[MadhaviSeelam]

@rebron tested with a new profile and made sure Brave was not pinned before. Infact, I've uninstalled and reinstalled Brave few times to test this as well. I think @kjozwiak has seen this issue in Nightly as well.

[simonhong]

This change comes from upstream installer changes.
Upstream installer started to pin to taskbar on Win10+ as pin api was added.
Previously only pinned to win7/8.
We don't want to pin by installer?

[rebron]

Closing as invalid per last comment by @simonhong. New behavior is expected.
@MadhaviSeelam to file a separate issue on missing icon.

[kjozwiak]

@MadhaviSeelam mind CCing me on the new issue that you create re: icons being blank? I run into that issue on a daily basis when installing Nightly while running through verifications on Win 11 x64.

[MadhaviSeelam]

Filed separate bug #27558 for missing icon (Scenario 3)
cc: @kjozwiak