Follow-up to #27122 Add additional confirmation to end of support message dismissal

[rebron]

Description

Update button from "Don't show again" to a check box [ ] Don't show again

When clicking on Don't show again checkbox and "x" to dismiss, show an additional confirmation dialog that reads:

"By clicking OK, you acknowledge that your installation of Brave will NOT receive critical security fixes until you update to Windows 10 or later. This warning will NOT show again."

Add two buttons "OK" and "Cancel".
Ok will dismiss the dialog and infobar and not show the message again.
Cancel will dismiss the dialog.

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

• Can you reproduce this issue with the current release? n/a
• Can you reproduce this issue with the beta channel? yes
• Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? n/a
• Does the issue resolve itself when disabling Brave Rewards? n/a
• Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

#27122

[simonhong]

@rebron I realized that previous infobar change was applied to all OS not just Windows.
So, linux or macOS users also could see system obsolete infobar with Don't show again button on their old system.
I think we may also want to use this confirm dialog on all platforms not just Windows. Then, we need different sentences for each platfom. Or if we want to change chromium's infobar style only for Windows, we could do that. WDYT?

[rebron]

It's ok to have this style for all OSes. As long as we're not telling Linux or macOS users to upgrade to Windows 10 or higher we should be ok.

Do you have a pointer for the text for the other platforms?
"to Windows 10 or later" could be something like "to a supported version of your OS" or "to a newer, supported version of your OS"

[simonhong]

It's ok to have this style for all OSes. As long as we're not telling Linux or macOS users to upgrade to Windows 10 or higher we should be ok.

Do you have a pointer for the text for the other platforms? "to Windows 10 or later" could be something like "to a supported version of your OS" or "to a newer, supported version of your OS"

Chromium uses different strings per each os versions.
You can see them here - https://source.chromium.org/chromium/chromium/src/+/main:chrome/app/google_chrome_strings.grd;l=428

[kjozwiak]

The above requires 1.47.176 or higher for 1.47.x verification 👍 @brave/qa-team this obviously can only be verified on Win 8.1 and Win 7. I'll verify Win 8.1 and @btlechowski can verify Win 7.

[btlechowski]

Verification passed on

Brave	1.47.177 Chromium: 109.0.5414.87 (Official Build) (64-bit)
Revision	2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS	Windows 7 x64

Verified test plan from brave/brave-core#16553

Verified inforbar is shown and that it contains the checkmark

Verified infobar is shown again after browser restart when the checkmark is not marked

Verified additional dialog is shown when the checkmark is marked

Verified inforbar is shown again after browser restart when user clicks Cancel on additional dialog

Verified inforbar is shown again after browser restart when user clicks Cancel on additional dialog

Verified infobar and additional dialog were translated

Additional confirmation to end of support message is not translated

Logged #27904 for missing translations

[kjozwiak]

Verification PASSED on Win 8.1 x64 using the following build(s):

Brave | 1.47.183 Chromium: 109.0.5414.119 (Official Build) (64-bit)
--- | ---
Revision | 772095164c7d5d4e73160f858efed3b5e87eca83-refs/branch-heads/5414@{#1458}
OS | Windows 8.1 (Build 9600.20778)

• verified the STR/Cases outlined via Launched additional confirmation dialog to the end of support brave-core#16553 (comment)
• ensured that the correct OS is being listed via the infobar
• ensured that the Learn more link worked as expected and opened the correct support page
• ensured that the infobar only appears once per session once it's dismissed
• ensured that the infobar always appears after re-launch if the user hasn't checked off Don't show again
• ensured that the infobar always appear after re-launch of the user checked off Don't show again but never confirmed
• ensured that the infobar always appears after re-launch when user checked off Don't show again but cancelled confirmation
• ensured that the infobar doesn't re-appear again once the user clicks on OK and confirms
• ensured that the infobar doesn't re-appear once permanently closed via Guest, PB & Tor windows

Example	Example	Example	Example

Not related to this PR, but the OS is also starting to warn users as per the following: