Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide option to dismiss end of support notice message for Windows 7 or 8 #27122

Closed
itoffie opened this issue Dec 2, 2022 · 7 comments · Fixed by brave/brave-core#16270
Closed

Provide option to dismiss end of support notice message for Windows 7 or 8 #27122

itoffie opened this issue Dec 2, 2022 · 7 comments · Fixed by brave/brave-core#16270
Assignees
@simonhong
Labels
OS/Desktop OS/Windows priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude repros-on-chrome
Milestone
1.47.x - Release #4

Comments

@itoffie
Copy link

itoffie commented Dec 2, 2022

aight we all know win7 support gonna get dropped soon but for god's sake
image
give us the "users" the option to disable this message as it is quite annoying everytime i open the browser i have to do another click on the side just to get rid of it
@tntc4
Copy link

tntc4 commented Dec 4, 2022

absolutely hate this message.
some of us can't just update to new OS because we have old computers.
developers, please give us option to completely disable this message.

@itoffie
Copy link
Author

itoffie commented Dec 4, 2022

true the reason why i stayed with windows 7 is that when i upgrade to windows 10 it tends to ignore some bios settings despite having the latest windows 10 support bios for my motherboard like instead of staying at a certain hz of CPU it uses the maximum hz which puts stress on my hardware ...

@Inesicen
Copy link

Inesicen commented Dec 6, 2022

REG ADD HKLM\SOFTWARE\Policies\BraveSoftware\Brave /v SuppressUnsupportedOSWarning /t REG_DWORD /d 1

@rebron rebron changed the title WIN7 End of Support notice message [PLEASE DISABLE IT!(or give us the option to)] Show end of Support notice message for Windows 7 or 8 only once Dec 6, 2022
@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. repros-on-chrome labels Dec 6, 2022
@rebron rebron added this to P3 Backlog in General Dec 6, 2022
@rebron rebron moved this from P3 Backlog to In progress in General Dec 6, 2022
@simonhong
Copy link
Member

simonhong commented Dec 7, 2022 •
edited
Loading

Working on this.
It looks like this infobar doesn't have dismiss button.
Need to add Don't show again button.

simonhong added a commit to brave/brave-core that referenced this issue Dec 7, 2022
@simonhong
Added don't show again button to obsolete system infobar
9c39243 
fix brave/brave-browser#27122

W/o this, user will see this infobar whenever brave is launched.
@simonhong simonhong mentioned this issue Dec 7, 2022
Merged
25 tasks
simonhong added a commit to brave/brave-core that referenced this issue Dec 7, 2022
@simonhong
Added don't show again button to obsolete system infobar
95db0a3 
fix brave/brave-browser#27122

W/o this, user will see this infobar whenever brave is launched.
@rebron rebron added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Dec 7, 2022
simonhong added a commit to brave/brave-core that referenced this issue Dec 8, 2022
@simonhong
Added don't show again button to obsolete system infobar
170095c 
fix brave/brave-browser#27122

W/o this, user will see this infobar whenever brave is launched.
General automation moved this from In progress to Completed Dec 8, 2022
@brave-builds brave-builds added this to the 1.48.x - Nightly milestone Dec 8, 2022
@rebron rebron moved this from Completed to Pending review/uplift or retest in General Dec 13, 2022
This was referenced Dec 20, 2022
Closed
Closed
@simonhong simonhong mentioned this issue Dec 21, 2022
Closed
7 tasks
@rebron rebron mentioned this issue Jan 4, 2023
Closed
@LaurenWags
Copy link
Member

Labelling as QA/Blocked for now after discussing with @kjozwiak. More information to come on this one.

@rebron
Copy link
Collaborator

rebron commented Jan 19, 2023

@LaurenWags @kjozwiak Going to QA/No this one in favor of the test plan specified in brave/brave-core#16553

@rebron rebron changed the title Show end of Support notice message for Windows 7 or 8 only once Provide option to dismiss end of support notice message for Windows 7 or 8 Jan 19, 2023
@simonhong
Copy link
Member

PR for this is included also for uplifting brave/brave-core#16553 to 1.47.x
because brave/brave-core#16553 depends on brave/brave-core#16270.

@kjozwiak kjozwiak moved this from Pending review/uplift or retest to Completed in General Jan 19, 2023
@rebron rebron removed this from Completed in General Jan 24, 2023
@LaurenWags LaurenWags mentioned this issue Jan 24, 2023
Closed
sangwoo108 pushed a commit to brave/brave-core that referenced this issue Apr 4, 2023
@simonhong @sangwoo108
Added don't show again button to obsolete system infobar
8b1a90f 
fix brave/brave-browser#27122

W/o this, user will see this infobar whenever brave is launched.
@rebron rebron mentioned this issue Aug 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
OS/Desktop OS/Windows priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude repros-on-chrome
Projects
None yet
Milestone
1.47.x - Release #4
Development

Successfully merging a pull request may close this issue.

Added don't show again button to obsolete system infobar brave/brave-core
8 participants
@kjozwiak @tntc4 @rebron @simonhong @LaurenWags @brave-builds @Inesicen @itoffie