Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash on wallet creation #27805

Closed
SergeyZhukovsky opened this issue Jan 13, 2023 · 2 comments · Fixed by brave/brave-core#16728
Closed

Crash on wallet creation #27805

SergeyZhukovsky opened this issue Jan 13, 2023 · 2 comments · Fixed by brave/brave-core#16728
Assignees
@SergeyZhukovsky
Labels
crash feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.47.x - Release #4

Comments

@SergeyZhukovsky
Copy link
Member

SergeyZhukovsky commented Jan 13, 2023 •
edited
Loading

There is a crash from time to time on wallet creation with such a stack trace:

2023-01-13 14:04:07.700 28199-28199 System.err              pid-28199                            W  java.lang.NullPointerException: Attempt to invoke virtual method 'void org.chromium.brave_wallet.mojom.BraveWalletService_Internal$BraveWalletServiceGetSelectedCoinParams.<init>(org.chromium.brave_wallet.mojom.BraveWalletService$GetSelectedCoin_Response)' on a null object reference
2023-01-13 14:04:07.700 28199-28199 System.err              pid-28199                            W  java.lang.NullPointerException: Attempt to invoke virtual method 'void org.chromium.brave_wallet.mojom.BraveWalletService_Internal$Proxy.getSelectedCoin(org.chromium.brave_wallet.mojom.BraveWalletService$GetSelectedCoin_Response)' on a null object reference
<OR> 2023-01-13 14:04:07.700 28199-28199 System.err              pid-28199                            W  java.lang.NullPointerException: Attempt to invoke virtual method 'void org.chromium.brave_wallet.mojom.BraveWalletService_Internal$Proxy.getSelectedCoin(org.chromium.brave_wallet.mojom.BraveWalletService$GetSelectedCoin_Response)' on a null object reference
<OR> 2023-01-13 14:04:07.700 28199-28199 System.err              pid-28199                            W  java.lang.NullPointerException: Attempt to invoke virtual method 'void org.chromium.brave_wallet.mojom.BraveWalletService_Internal$Proxy.getSelectedCoin(org.chromium.brave_wallet.mojom.BraveWalletService$GetSelectedCoin_Response)' on a null object reference
<OR> 2023-01-13 14:04:07.700 28199-28199 System.err              pid-28199                            W  java.lang.NullPointerException: Attempt to invoke virtual method 'void org.chromium.brave_wallet.mojom.BraveWalletService_Internal$Proxy.getSelectedCoin(org.chromium.brave_wallet.mojom.BraveWalletService$GetSelectedCoin_Response)' on a null object reference
<OR> 2023-01-13 14:04:07.700 28199-28199 System.err              pid-28199                            W  java.lang.NullPointerException: Attempt to invoke virtual method 'void org.chromium.brave_wallet.mojom.BraveWalletService_Internal$Proxy.getSelectedCoin(org.chromium.brave_wallet.mojom.BraveWalletService$GetSelectedCoin_Response)' on a null object reference
<OR> 2023-01-13 14:04:07.700 28199-28199 System.err              pid-28199                            W  java.lang.NullPointerException: Attempt to invoke virtual method 'void org.chromium.mojo.bindings.Interface$AbstractProxy$HandlerImpl.getMessageReceiver(org.chromium.brave_wallet.mojom.BraveWalletService$GetSelectedCoin_Response)' on a null object reference
2023-01-13 14:04:07.700 28199-28199 System.err              pid-28199                            W  java.lang.NullPointerException: Attempt to invoke virtual method 'void org.chromium.brave_wallet.mojom.BraveWalletService_Internal$Proxy.getSelectedCoin(org.chromium.brave_wallet.mojom.BraveWalletService$GetSelectedCoin_Response)' on a null object reference
2023-01-13 14:04:07.700 28199-28199 System.err              pid-28199                            W      at org.chromium.chrome.browser.app.domain.KeyringModel.update(KeyringModel.java:147)
2023-01-13 14:04:07.700 28199-28199 System.err              pid-28199                            W      at org.chromium.chrome.browser.app.domain.KeyringModel.keyringCreated(KeyringModel.java:299)
2023-01-13 14:04:07.700 28199-28199 System.err              pid-28199                            W      at org.chromium.brave_wallet.mojom.KeyringServiceObserver_Internal$Stub.accept(KeyringServiceObserver_Internal.java:277)
2023-01-13 14:04:07.700 28199-28199 System.err              pid-28199                            W      at org.chromium.mojo.bindings.RouterImpl.handleIncomingMessage(RouterImpl.java:238)
2023-01-13 14:04:07.700 28199-28199 System.err              pid-28199                            W      at org.chromium.mojo.bindings.RouterImpl$HandleIncomingMessageThunk.accept(RouterImpl.java:33)
2023-01-13 14:04:07.700 28199-28199 System.err              pid-28199                            W      at org.chromium.mojo.bindings.Connector.readAndDispatchMessage(Connector.java:210)
2023-01-13 14:04:07.700 28199-28199 System.err              pid-28199                            W      at org.chromium.mojo.bindings.Connector.readOutstandingMessages(Connector.java:176)
2023-01-13 14:04:07.700 28199-28199 System.err              pid-28199                            W      at org.chromium.mojo.bindings.Connector.onWatcherResult(Connector.java:152)
2023-01-13 14:04:07.700 28199-28199 System.err              pid-28199                            W      at org.chromium.mojo.bindings.Connector$WatcherCallback.onResult(Connector.java:142)
2023-01-13 14:04:07.700 28199-28199 System.err              pid-28199                            W      at org.chromium.mojo.system.impl.WatcherImpl.onHandleReady(WatcherImpl.java:56)
2023-01-13 14:04:07.700 28199-28199 System.err              pid-28199                            W      at android.os.MessageQueue.nativePollOnce(Native Method)
2023-01-13 14:04:07.700 28199-28199 System.err              pid-28199                            W      at android.os.MessageQueue.next(MessageQueue.java:335)
2023-01-13 14:04:07.700 28199-28199 System.err              pid-28199                            W      at android.os.Looper.loopOnce(Looper.java:186)
2023-01-13 14:04:07.700 28199-28199 System.err              pid-28199                            W      at android.os.Looper.loop(Looper.java:313)
2023-01-13 14:04:07.700 28199-28199 System.err              pid-28199                            W      at android.app.ActivityThread.main(ActivityThread.java:8751)
2023-01-13 14:04:07.700 28199-28199 System.err              pid-28199                            W      at java.lang.reflect.Method.invoke(Native Method)
2023-01-13 14:04:07.700 28199-28199 System.err              pid-28199                            W      at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:571)
2023-01-13 14:04:07.700 28199-28199 System.err              pid-28199                            W      at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1135)

I could replicate it on 1.49.x release version and it happens 1 out of 5 times to me. STR:

  1. Make a fresh Brave install
  2. Settings->Wallet
  3. Create new wallet

Observe a crash on creating wallet wizard.
A video of the crash:

PXL_20230118_162948414.TS.mp4
@SergeyZhukovsky SergeyZhukovsky added crash priority/P2 A bad problem. We might uplift this to the next planned release. feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Jan 13, 2023
@SergeyZhukovsky SergeyZhukovsky self-assigned this Jan 13, 2023
@SergeyZhukovsky SergeyZhukovsky mentioned this issue Jan 18, 2023
Open
@SergeyZhukovsky SergeyZhukovsky mentioned this issue Jan 18, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.49.x - Nightly milestone Jan 19, 2023
@brave-builds brave-builds mentioned this issue Jan 19, 2023
Merged
7 tasks
@SergeyZhukovsky SergeyZhukovsky mentioned this issue Jan 19, 2023
Merged
@kjozwiak
Copy link
Member

The above requires 1.47.178 or higher for 1.47.x verification 👍

@srirambv
Copy link
Contributor

Verification passed on Lenovo Tab with Android 12 running 1.47.181 x64 build

  • Verified steps from issue description and brave/brave-core#16728
  • Verified no crash when creating wallet
  • Verified on clean install and upgrade

Verification passed on Oppo Reno 5 with Android 13 running 1.47.181 x64 build

  • Verified steps from issue description and brave/brave-core#16728
  • Verified no crash when creating wallet
  • Verified no crash when skipping fingerprint registration for wallet unlock
  • Verified no crash when opting into fingerprint registration for wallet unlock
  • Verified on clean install and upgrade

This was referenced Jan 25, 2023
Closed
Closed
@Pavneet-Sing Pavneet-Sing mentioned this issue Mar 29, 2023
Merged
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SergeyZhukovsky SergeyZhukovsky

Labels
crash feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.47.x - Release #4
Development

Successfully merging a pull request may close this issue.

Fixes an intermittent crash on Android on a wallet creation brave/brave-core
4 participants
@kjozwiak @SergeyZhukovsky @srirambv @brave-builds