Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto Discovery for Filecoin Assets and Accounts #28002

Closed
HEagle18 opened this issue Jan 24, 2023 · 3 comments · Fixed by brave/brave-core#18283
Closed

Auto Discovery for Filecoin Assets and Accounts #28002

HEagle18 opened this issue Jan 24, 2023 · 3 comments · Fixed by brave/brave-core#18283
Assignees
Labels
feature/web3/wallet/filecoin feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include

Comments

@HEagle18
Copy link

Description

We are building auto discovery for ERC tokens and Solana tokens. We should also do this for Filecoin.

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Desktop Brave version:

Android Device details:

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@HEagle18 HEagle18 added OS/Android Fixes related to Android browser functionality OS/Desktop feature/web3/wallet/filecoin labels Jan 24, 2023
@cypt4 cypt4 self-assigned this Jan 24, 2023
@jamesmudgett jamesmudgett added the priority/P4 Planned work. We expect to get to it "soon". label Jan 27, 2023
@yrliou
Copy link
Member

yrliou commented Feb 3, 2023

AFAIK Filecoin does not have other tokens other than Filecoin itself, so I think we probably only need account discovery for Filecoin. For account discovery, we should follow the algorithm in #18104.

@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 13 running 1.53.94 x64 Beta build

  • Verified steps from brave/brave-core#18283
  • Verified importing a wallet restores all non-zero balance accounts for both ETH and SOL

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.53.94 Chromium: 114.0.5735.133 (Official Build) beta (64-bit)
Revision fbfa2ce68d01b2201d8c667c2e73f648a61c4f4a-refs/branch-heads/5735@{#1270}
OS Windows 11 Version 22H2 (Build 22621.1848)
  • Verified steps from brave/brave-core#18283
  • Verified importing a wallet restores all non-zero balance accounts for both ETH, SOL & FIL accounts
28002.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet/filecoin feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

7 participants