Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 111 to Chromium 112 #28494

Closed
mkarolin opened this issue Feb 14, 2023 · 4 comments · Fixed by brave/brave-core#17187
Closed

Upgrade from Chromium 111 to Chromium 112 #28494

mkarolin opened this issue Feb 14, 2023 · 4 comments · Fixed by brave/brave-core#17187

Comments

@mkarolin
Copy link
Contributor

mkarolin commented Feb 14, 2023

Upgrade from Chromium 111 to Chromium 112

https://chromium.googlesource.com/chromium/src/+log/111.0.5563.19..112.0.5582.0/?pretty=fuller&n=10000

QA tests:
This is a major Chromium version bump, please do full passes.

Desktop Affected areas:

  • Sharing hub in the omnibox works as expected
  • Info bar colors look correctly
  • Components (brave://components) update without errors (on new profile)
  • Shields cookies permissions work correctly
  • Prepopulated search engines look correctly
  • Omnibox suggestions entries open correctly

iOS Affected areas:

  • N/A

Android Affected areas:

  • Turn on notfications dialog (double check it appears as expected)
  • Rate Brave (make sure you can leave a review in Play Store)
  • Play video in background
  • Bookmarking pages (there is a new bottom sheet UI and behaviour)
  • Sync (double check it generally works)
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Mar 20, 2023

Verification PASSED on

Brave | 1.51.46 Chromium: 112.0.5615.29 (Official Build) nightly (64-bit)
-- | --
Revision | 8a59304c62e066962363d2fd8edd8e7b459c42bd-refs/branch-heads/5615@{#497}
OS | Windows 10 Version 21H2 (Build 19044.2728)
Sharing hub in the omnibox works as expected_PASSED
  • Ensured that sharing hub options in the omnibox works as expected
    image
Info bar colors look correctly_PASSED
  • Confirmed that info bar color looks as expected in light theme
  • Confirmed that info bar color looks as expected in Dark theme
  • Verified the info bar color in PT/PT with TOR/Guest windows and ensured that the info bar color looks as expected
Light theme Dark theme
image image
Components (brave://components) update without errors (on new profile)_PASSED
  • Verified the components in Components updater section below
Shields cookies permissions work correctly_PASSED
Case 1: Cookies settings are retained upon browser restart_PASSED
  1. Clean profile 1.51.x
  2. Open a site A
  3. Tap on the shield and looks for cookies settings
  4. Default cookies settings "Block cross-site cookies" is populated in the dropdown
  5. Change the cookies settings to "Block all cookies" and restart the browser
  6. Ensured that "Block all cookies" cookies settings are retained, restart the browser
  7. Change the cookies settings to "Allow all cookies" and restart the browser
  8. Ensured that "Allow all cookies" cookies settings are retained
Case 2: Global cookies settings are retained across all the sites_PASSED
  1. Clean profile 1.51.x
  2. Open brave://settings/shields and ensure default settings "Block cross-site cookies" is populated in the dropdown
  3. Open a site A, Tap on the shield and ensured default global cookies settings are retained
  4. Open brave://settings/shields, change the cookies settings to "Block all cookies" and restart the browser
  5. Ensured that "Block all cookies" cookies settings are retained
  6. Open brave://settings/shields, change the cookies settings to "Allow all cookies" and restart the browser
  7. Ensured that "Allow all cookies" cookies settings are retained
Case 3: Cookies settings for a site A are propagated to site A in Private window Tab_PASSED
    1. Clean profile 1.51.x
    2. Open a site A, tap on the shield and change the default cookies setting to "Allow all cookies"
    3. Open a Private tab window
    4. Open the same site A in the PT and ensure that the "Allow all cookies" settings are retained
    5. Change the cookies settings to "Block all cookies" in the PT 
    6. Open the same site A in the Normal window tab and ensure that the "Block all cookies" settings are NOT retained
Case 4: Cookies settings are retained in an upgraded profile_PASSED
  1. Clean profile 1.49.x
  2. Open a few sites and change the default site shield settings 
  3. Open brave://settings/shields and change the default global shield settings
  4. Upgrade the profile 1.51.x
  5. Open the sites and ensured that the site shield settings are reatined
  6. Open brave://settings/shields and ensured that the global shield settings are retained
Case 5: cookies settings in brave://settings/cookies works as expected_PASSED
1. Clean profile 1.51.x
2. Open brave://settings/cookies and select "Block all cookies" settings 
3. Open a site and ensured that the cookies are blocked on the site 
4. Open brave://settings/cookies and select "Allow all cookies" settings
5. Open a site and ensured that the cookies are allowed on the site 
Exampple Example Example Example
image image image image
Prepopulated search engines look correctly_PASSED
  • Confirmed that Prepopulated SE works as expected in Normal/Private/TOR/Guest window types
  • Confirmed that :b ,:sp, :d etc..keywords SE's works as expected
  • Confirmed that selected SE's reatined in brave://settings/search upon browser restart
  • Confirmed that SE's are retained in an upgraded profile
Omnibox suggestions entries open correctly_PASSED
Case 1: Improve search suggestions toggle is OFF
  1. Clean profile 1.51.x
  2. Go to brave://settings/privacy and esnure that Improve search suggestions toggle is OFF by default
  3. Open a NTP and enter a text "test" in the Omnibox and look for the suggestion entries
  4. Open a Private window tab (or TOR or Guest) and enter a text "test" in the Omnibox and look for the suggestion entries
  5. Confirmed that the search suggestion are same in both Normal and Private window types when the `Improve search suggestions` toggle is OFF
Settings is OFF Normal win suggestions PT suggestions
image image image
Case 2: Improve search suggestions toggle is ON
  1. Clean profile 1.51.x
  2. Go to brave://settings/privacy and and enable the `Improve search suggestions` toggle to ON
  3. Open a NTP and enter a text "test" in the Omnibox and look for the suggestion entries
  4. Confirmed that the suggestion entries are more as the toggle is ON
  5. Open a Private window tab (or TOR or Guest) and enter a text "test" in the Omnibox and look for the suggestion entries
  6. Confirmed that the search suggestion entries remained same not increased in PT which is expected as the Toggle ON is applicable only for Normal windows search suggestions
Settings is ON Normal win suggestions PT suggestions
image image image
Case 3: Autocomplete searches and URLs_Upgrade case
 1. Clean profile 1.49.x or 1.51.30
 2. Go to brave://settings/privacy and toggle the switch `Autocomplete searches and URLs` to ON
 3. Open a NTP and enter a text "test" in the Omnibox and look for the suggestion entries
 4. Confirmed that the suggestion entries are more as the toggle is ON
 5. Upgrade the profile to 1.51.46
 6. Go to brave://settings/privacy and ensured that the switch `Autocomplete searches and URLs` is renamed to `Improve search suggestions` 
 7. Confirmed that the toggle is ON as expected

Settings comparison

1.49.x 1.51.x
image image

Components updater

  • No new components are added as part of CR 112
  • Components are updates successfully without any error
1.49.120 Chromium: 111.0.5563.64 1.51.46 Chromium: 112.0.5615.29
image image

Brave startup calls

  • Confirmed that only brave domains are listed in the Charles when the nightly build is launched with a clean profile
  • Confirmed no calls to google, gstatic, etc domains when the nightly build is launched with a clean profile

@Uni-verse
Copy link
Contributor

Uni-verse commented Mar 21, 2023

Verified on Samsung GS 21 5G using version(s):

Brave	1.51.48 Chromium: 112.0.5615.29 (Official Build) canary (32-bit) 
Revision	8a59304c62e066962363d2fd8edd8e7b459c42bd-refs/branch-heads/5615@{#497}
OS	Android 13; Build/TP1A.220624.014
Notifications Dialog - PASS
  • Ensured notifications popup is shown on NTP and user is able to enable it.
  • Ensured notifications popup shows up when creating rewards profile.
Example Example Example Example
screenshot-1679411818854 screenshot-1679411828275 screenshot-1679411859267 screenshot-1679411889464
Rate Brave - PASS
  • Confirmed user is able to leave a rating on the GPS.
  • Confirmed brave rate modals are shown correctly.
Example Example Example Example
screenshot-1679411592295 screenshot-1679411601018 screenshot-1679411609477 screenshot-1679412781293
Background Play - PASS
  • Background play is enabled by default via the griffin study.
  • Playing videos in the background and while lockscreen is on works if background play is enabled.
  • Playing videos in the background doesn't work when disabling background play.
Example Example Example Example
screenshot-1679411682816 screenshot-1679412042085 screenshot-1679412059891 screenshot-1679412094913
Bookmarking - PASS
  • Ensured bookmarking pages is working.
  • Ensured creating a bookmark into a new folder is working.
  • Ensured that bookmarking is working when sync chain is enabled.
Example Example
screenshot-1679326655445 screenshot-1679411329632
Sync Chain - PASS
  • Ensured sync chain is working.
  • Ensured user is able to create a standalone sync chain.
  • Ensured user is able to join existing sync chain using code words and by scanning QR.
  • Ensured that deleting sync chain works.
  • Ensured that existing contents on sync chain are shown on all connected devices.
  • Ensured that adding other devices to the sync chain is successful.
Example Example Example Example
screenshot-1679411052883 screenshot-1679411114765 screenshot-1679411134997 screenshot-1679411146068

@Uni-verse
Copy link
Contributor

Verified on Samsung Tablet per #29171 (comment)

@kjozwiak
Copy link
Member

Labelling as QA/No and release-notes/exclude in favour of #29277. Summary of the work remaining can be found via #29277 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment