-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade from Chromium 112.0.5615.29 to Chromium 112.0.5615.39 #29277
Comments
Quick overview of the work remaining re: affected areas due to Platforms that require a spot check due to already completing full check of the affected areas mentioned via #28494 (comment).
Platforms that still need to check/verify the affected areas due to
@Uni-verse believe you mentioned that you checked the affected areas on Tablet but double checking just in case. I do see the affected areas checked off via #29171 (comment) but let me know if that's not the case. |
The above requires |
Verification
|
Brave | 1.50.108 Chromium: 112.0.5615.39 (Official Build) (x86_64) |
---|---|
Revision | a0e7b9718a92bcd1cf33b7c95316caff3fc20714-refs/branch-heads/5615@{#753} |
OS | macOS Version 11.7.5 (Build 20G1225) |
Info bar colors look correctly - PASSED
- Confirmed that info bar color looks as expected in
Light
theme - Confirmed that info bar color looks as expected in
Dark
theme - Verified the info bar color in PT/PT with TOR/Guest windows and ensured that the info bar color looks as expected
Light theme |
Dark theme |
---|---|
![]() |
![]() |
Private browsing |
Private browsing w/Tor |
Guest window |
---|---|---|
![]() |
![]() |
![]() |
Shields cookies permissions work correctly - PENDING
Case 1: Cookies settings are retained upon browser restart - PENDING
1. Clean profile 1.51.x
2. Open a site A
3. Tap on the shield and looks for cookies settings
4. Default cookies settings "Block cross-site cookies" is populated in the dropdown
5. Change the cookies settings to "Block all cookies" and restart the browser
6. Ensured that "Block all cookies" cookies settings are retained, restart the browser
7. Change the cookies settings to "Allow all cookies" and restart the browser
8. Ensured that "Allow all cookies" cookies settings are retained
Case 2: Global cookies settings are retained across all the sites - PENDING
1. Clean profile 1.51.x
2. Open brave://settings/shields and ensure default settings "Block cross-site cookies" is populated in the dropdown
3. Open a site A, Tap on the shield and ensured default global cookies settings are retained
4. Open brave://settings/shields, change the cookies settings to "Block all cookies" and restart the browser
5. Ensured that "Block all cookies" cookies settings are retained
6. Open brave://settings/shields, change the cookies settings to "Allow all cookies" and restart the browser
7. Ensured that "Allow all cookies" cookies settings are retained
Case 3: Cookies settings for a site A are propagated to site A in Private window Tab - PENDING
1. Clean profile 1.51.x
2. Open a site A, tap on the shield and change the default cookies setting to "Allow all cookies"
3. Open a Private tab window
4. Open the same site A in the PT and ensure that the "Allow all cookies" settings are retained
5. Change the cookies settings to "Block all cookies" in the PT
6. Open the same site A in the Normal window tab and ensure that the "Block all cookies" settings are NOT retained
Case 4: Cookies settings are retained in an upgraded profile - PENDING
1. Clean profile 1.49.x
2. Open a few sites and change the default site shield settings
3. Open brave://settings/shields and change the default global shield settings
4. Upgrade the profile 1.51.x
5. Open the sites and ensured that the site shield settings are reatined
6. Open brave://settings/shields and ensured that the global shield settings are retained
Case 5: cookies settings in brave://settings/cookies works as expected - PENDING
1. Clean profile 1.51.x
2. Open brave://settings/cookies and select "Block all cookies" settings
3. Open a site and ensured that the cookies are blocked on the site
4. Open brave://settings/cookies and select "Allow all cookies" settings
5. Open a site and ensured that the cookies are allowed on the site
Example | Example | Example | Example |
---|
@LaurenWags feel free to start from the bottom of the above and work your way up until we meet? |
@stephendonner going label this one as |
Minor Chromium bump
https://chromium.googlesource.com/chromium/src/+log/112.0.5615.29..112.0.5615.39?pretty=fuller&n=10000
QA tests:
Additional checks:
The text was updated successfully, but these errors were encountered: