Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "Copy clean link" from context menu on webpage when URL text (not link) is highlighted #28881

Closed
LaurenWags opened this issue Mar 3, 2023 · 2 comments · Fixed by brave/brave-core#17494

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Mar 3, 2023

Description

Follow up to #27676 (comment) - for all OSes, not just those listed in comment.

When copying text (not link) that is a URL, would like to see "Copy clean link" in context menu.

See discussion under https://bravesoftware.slack.com/archives/CKNHM4RTK/p1677768069627199.

Steps to Reproduce

  1. Using 1.49.117, clean profile
  2. Navigate to a github issue
  3. In a comment, enter www.brave.com but don't submit your comment
  4. Highlight www.brave.com in the comment
  5. Right click to get context menu
    ---> would like to see "Copy clean link" from here, but it does not show.

Actual result:

2

Expected result:

Different context menu, but just to give an example of where "Copy clean link" displays:

Screen Shot 2023-03-03 at 8 41 52 AM

Reproduces how often:

easily

Brave version (brave://version info)

Brave | 1.49.117 Chromium: 111.0.5563.50 (Official Build) (x86_64)
-- | --
Revision | 39f3dfc5023fe60997adc4f6cf5439cfa3e6968a-refs/branch-heads/5563@{#903}
OS | macOS Version 12.6.3 (Build 21G419)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @rebron @sangwoo108 @fmarier

@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.51.79 Chromium: 112.0.5615.49 (Official Build) beta (64-bit)
-- | --
Revision | bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS | Windows 11 Version 22H2 (Build 22621.1413)

Verified using STR from #28881 (comment)

Confirmed Copy clean link is displayed in the context menu when URL text is highlighted

image

@stephendonner
Copy link

stephendonner commented Apr 11, 2023

Verification PASSED using

Brave 1.51.85 Chromium: 112.0.5615.49 (Official Build) beta (x86_64)
Revision bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS macOS Version 11.7.6 (Build 20G1231)

Steps:

  1. installed 1.51.85
  2. launched Brave
  3. loaded pastebin.com
  4. pasted a copied Twitter link from Chrome:
    https://twitter.com/JortsTheCat/status/1645854409065365504?s=20
  5. selected the full text of the URL
  6. confirmed Copy clean link context-menu item
  7. chose Copy clean link
  8. pasted from clipboard
  9. added single quotes to the string, and tried to invoke Copy clean link
  10. confirmed because it's not a resolvable URL the menu option didn't show

Confirmed Copy clean link both appears when selecting a text with a URL, as well as works to strip out the tracking parameter ?s=20

example example example
Screen Shot 2023-04-11 at 2 32 22 PM Screen Shot 2023-04-11 at 2 32 31 PM Screen Shot 2023-04-11 at 2 34 23 PM

Verification passed on

Brave 1.51.80 Chromium: 112.0.5615.49 (Official Build) beta (64-bit)
Revision bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS Ubuntu 18.04 LTS

Steps:

  1. installed 1.51.x
  2. launched Brave
  3. loaded pastebin.com
  4. pasted a copied Twitter link from Chrome:
    https://twitter.com/JortsTheCat/status/1645854409065365504?s=20
  5. selected the full text of the URL
  6. confirmed Copy clean link context-menu item
  7. chose Copy clean link
  8. pasted from clipboard
  9. added single quotes to the string, and tried to invoke Copy clean link
  10. confirmed because it's not a resolvable URL the menu option didn't show

Confirmed Copy clean link both appears when selecting a text with a URL, as well as works to strip out the tracking parameter ?s=20

example example example
image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment