Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable brave://flags/#brave-vertical-tabs in Release channel #29659

Closed
stephendonner opened this issue Apr 12, 2023 · 8 comments · Fixed by brave/brave-core#18465
Closed

Enable brave://flags/#brave-vertical-tabs in Release channel #29659

stephendonner opened this issue Apr 12, 2023 · 8 comments · Fixed by brave/brave-core#18465

Comments

@stephendonner
Copy link

stephendonner commented Apr 12, 2023

Description

Placeholder for when we're ready to ship, and can enable brave://flags/#brave-vertical-tabs in Release channel

Steps to Reproduce

  1. install latest release-candidate build of 1.51.x
  2. launch Brave
  3. load brave://flags
  4. confirm that brave://flags/#brave-vertical-tabs is set to Default
  5. load a few tabs
  6. context-click a tab
  7. look for the option to Use Vertical Tabs

Cross-reference:

Actual result:

It's absent.

Expected result:

Screen Shot 2023-04-12 at 10 13 28 AM

Reproduces how often:

100%

Brave version (brave://version info)

1.51.x (release candidate/release build)

Miscellaneous Information:

/cc @rebron @sangwoo108 @brave/qa-team

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label May 8, 2023
@rebron rebron changed the title (Placeholder) Enable brave://flags/#brave-vertical-tabs in Release channel Enable brave://flags/#brave-vertical-tabs in Release channel May 8, 2023
@rebron rebron added this to Untriaged Backlog in General May 8, 2023
General automation moved this from Untriaged Backlog to Completed May 13, 2023
@brave-builds brave-builds added this to the 1.53.x - Nightly milestone May 13, 2023
@sangwoo108
Copy link

@rebron Please let me know if this needs uplifting

@rebron rebron moved this from Completed to Pending review/uplift or retest in General May 16, 2023
@kjozwiak kjozwiak moved this from Pending review/uplift or retest to Completed in General May 17, 2023
@kjozwiak
Copy link
Member

The above requires 1.52.102 or higher for 1.52.x verification 👍 @brave/qa-team note that we'll need to verify that vertical tabs are enabled by default via beta and then release once we do channel migrations and 1.52.x gets moved into release.

@MadhaviSeelam

This comment was marked as outdated.

@stephendonner

This comment was marked as outdated.

@LaurenWags
Copy link
Member

Removing QA/Blocked as the first 1.52.x RC is available via https://github.com/brave/brave-browser/releases/tag/v1.52.110

@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.52.110 Chromium: 114.0.5735.35 (Official Build) (64-bit)
-- | --
Revision | 2295354895fa3652ae47b651481831484f16d1ff-refs/branch-heads/5735@{#713}
OS | Windows 11 Version 22H2 (Build 22621.1702)
  1. Installed 1.52.110
  2. launch Brave
  3. load brave://flags
  4. confirm that brave://flags/#brave-vertical-tabs is set to Default
  5. load a few tabs
  6. context-click a tab
  7. verified the option to Use Vertical Tabs is available
  8. selected Used Vertical Tabs
  • Confirmed vertical-tabs is enabled as default inbrave://flags
  • Confirmed vertical tab panel is shown with opened tabs
  • Confirmed vertical tab functionality worked as expected
example example example
image image image

@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.52.110 Chromium: 114.0.5735.35 (Official Build) (x86_64)
Revision 2295354895fa3652ae47b651481831484f16d1ff-refs/branch-heads/5735@{#713}
OS macOS Version 13.5 (Build 22G5027e)

Steps:

  1. Installed 1.52.110
  2. launch Brave
  3. load brave://flags
  4. confirm that brave://flags/#brave-vertical-tabs is set to Default
  5. load a few tabs
  6. context-click a tab
  7. verified the option to Use Vertical Tabs is available
  8. selected Used Vertical Tabs
  9. Confirmed vertical-tabs is enabled as default inbrave://flags

Confirmed vertical tab panel is shown with opened tabs
Confirmed vertical tab functionality worked as expected

example example example
Screenshot 2023-05-25 at 8 31 58 AM Screenshot 2023-05-25 at 8 32 36 AM Screenshot 2023-05-25 at 8 32 52 AM

@stephendonner
Copy link
Author

Verified PASSED using

Brave	1.52.112 Chromium: 114.0.5735.35 (Official Build) (64-bit) 
Revision	2295354895fa3652ae47b651481831484f16d1ff-refs/branch-heads/5735@{#713}
OS	Linux

Steps:

  1. installed 1.52.112
  2. launched Brave
  3. loaded brave://flags
  4. confirmed that brave://flags/#brave-vertical-tabs is set to Default
  5. loaded a few tabs
  6. context-clicked a tab
  7. verified the option to Use Vertical Tabs is available
  8. selected Used Vertical Tabs
  9. confirmed vertical-tabs is enabled as default in brave://flags
example example example
Screen Shot 2023-05-25 at 10 00 02 PM Screen Shot 2023-05-25 at 10 00 56 PM Screen Shot 2023-05-25 at 10 04 42 PM

@rebron rebron removed this from Completed in General Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment