Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on vertical tab strip feature by default #18465

Merged
merged 1 commit into from
May 13, 2023

Conversation

sangwoo108
Copy link
Contributor

Now we have the feature tuned on for all channels

Resolves brave/brave-browser#29659

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@github-actions github-actions bot added the potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false label May 12, 2023
Now we have the feature tuned on for all channels
@sangwoo108 sangwoo108 marked this pull request as ready for review May 12, 2023 11:06
@sangwoo108 sangwoo108 requested a review from simonhong May 12, 2023 11:06
Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ 👍🏼

@sangwoo108 sangwoo108 merged commit 63ed5ae into master May 13, 2023
@sangwoo108 sangwoo108 deleted the sko/vtab-feature-value branch May 13, 2023 03:44
@github-actions github-actions bot added this to the 1.53.x - Nightly milestone May 13, 2023
brave-builds added a commit that referenced this pull request May 16, 2023
kjozwiak pushed a commit that referenced this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable brave://flags/#brave-vertical-tabs in Release channel
2 participants