Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine transaction confirmation panel components #34661

Closed
josheleonard opened this issue Dec 1, 2023 · 2 comments · Fixed by brave/brave-core#21188
Closed

Combine transaction confirmation panel components #34661

josheleonard opened this issue Dec 1, 2023 · 2 comments · Fixed by brave/brave-core#21188
Assignees
@josheleonard
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.62.x - Release

Comments

@josheleonard
Copy link

Description

Combine transaction confirmation panel components to help prevent regressions between panels when editing styles
@josheleonard josheleonard added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Dec 1, 2023
@josheleonard josheleonard self-assigned this Dec 1, 2023
@josheleonard josheleonard mentioned this issue Dec 1, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.63.x - Nightly milestone Dec 14, 2023
This was referenced Jan 18, 2024
Merged
Closed
@kjozwiak
Copy link
Member

The above requires 1.62.148 or higher for 1.62.x verification 👍

@josheleonard josheleonard mentioned this issue Jan 22, 2024
Merged
7 tasks
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.62.149 Chromium: 121.0.6167.75 (Official Build) (64-bit)
Revision ff84587bd70af9fcbcbe59fc5194ca65082759c4
OS Windows 11 Version 23H2 (Build 22631.3007)
  • Verified steps from brave/brave-core#21188
  • Verified transaction confirmation panel continue to show all transaction information for all transaction types without any regression

@LaurenWags LaurenWags mentioned this issue Jan 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josheleonard josheleonard

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.62.x - Release
Development

Successfully merging a pull request may close this issue.

chore: consolidate tx confirmation panels brave/brave-core
4 participants
@kjozwiak @srirambv @josheleonard @brave-builds