Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: display error when transaction fee estimate fails (Uplift to 1.62.x) #21625

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Fix: display error when transaction fee estimate fails (Uplift to 1.62.x) #21625

merged 2 commits into from
Jan 19, 2024

Conversation

josheleonard
Copy link
Contributor

@josheleonard josheleonard commented Jan 18, 2024 •
edited by kjozwiak
Loading

Uplift of #21624
Uplift of #21188
Resolves brave/brave-browser#35413
Resolves brave/brave-browser#34661

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@josheleonard
chore: consolidate tx confirmation panels (#21188)
0b8c9ae 
* chore: consolidate tx confirmation panels

* chore: combine transaction-info components

* chore: combine transaction-detail components

* fix: allow rows to wrap content

* fix: allow tx confirm to-from row to wrap

* chore: remove max-width prop from column component
@josheleonard
fix: display error when unable to fetch transaction fee
27cf88c
@josheleonard josheleonard self-assigned this Jan 18, 2024
@josheleonard josheleonard requested a review from a team as a code owner January 18, 2024 17:31
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet labels Jan 18, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@kjozwiak kjozwiak added this to the 1.62.x - Release milestone Jan 19, 2024
kjozwiak
kjozwiak approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.62.x approved 👍 QA has verified the PR on Nightly using 1.64.x as per #21624 (comment) & #21188 (comment).

@kjozwiak kjozwiak merged commit e141c82 into 1.62.x Jan 19, 2024
15 checks passed
@kjozwiak kjozwiak deleted the chore--consolidate-tx-confirmation-panels-1.62.x branch January 19, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@josheleonard josheleonard

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet
Projects
None yet
Milestone
1.62.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@josheleonard @brave-builds @kjozwiak