Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CR121 - Cookies settings are not in sync between brave://settings/cookies and brave://settings/shields settings pages #35415

Closed
GeetaSarvadnya opened this issue Jan 18, 2024 · 2 comments · Fixed by brave/brave-core#21745
Assignees
Labels
bug Chromium/upstream-test Issue involves an upstream unit or browser test OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include

Comments

@GeetaSarvadnya
Copy link
Collaborator

GeetaSarvadnya commented Jan 18, 2024

Description

Cookies settings are not in sync between brave://settings/cookies and brave://settings/shields settings pages

Steps to Reproduce

Case 1:

  1. Clean profile 1.63.24 CR121 build
  2. Open brave://settings/cookies
  3. Change the cookies settings to "Allow third-party cookies"
  4. Confirm that "Allow third-party cookies" option is selected
  5. Open brave://settings/shields
  6. Look for cookies shield setting
  7. Cookies settings are set to "Only cross-sites" instead of "Disable"
  8. Both setting pages are NOT insync

Case 2:

  1. Clean profile 1.63.24 CR121 build
  2. Open brave://settings/shields
  3. Change the cookies settings to "Disable"
  4. Open brave://settings/cookies
  5. Cookies settings are still showing up "Block 3rd party cookies" settings selected instead of "Allow third-party cookies"
  6. Both setting pages are NOT in sync

Actual result:

Cookies settings are not in sync between brave://settings/cookies and brave://settings/shields settings pages

Expected result:

Cookies settings should be insync between brave://settings/cookies and brave://settings/shields settings pages

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.63.124 Chromium: 121.0.6167.57 (Official Build) nightly (64-bit)
Revision e0864ff
OS Windows 10 Version 22H2 (Build 19045.3930)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @rebron @mkarolin @bridiver @brave/qa-team

@rebron rebron added this to In progress in Settings Jan 18, 2024
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jan 18, 2024
@GeetaSarvadnya GeetaSarvadnya changed the title Cookies settings are not in sync between brave://settings/cookies and brave://settings/shields settings pages CR121 - Cookies settings are not in sync between brave://settings/cookies and brave://settings/shields settings pages Jan 19, 2024
@brave-builds brave-builds added this to the 1.64.x - Nightly milestone Jan 25, 2024
@rebron rebron moved this from In progress to Completed in Settings Jan 26, 2024
@kjozwiak
Copy link
Member

The above requires 1.62.156 or higher for 1.62.x verification 👍

@GeetaSarvadnya
Copy link
Collaborator Author

Verification PASSED on

Brave | 1.62.156 Chromium: 121.0.6167.139 (Official Build) (64-bit)
-- | --
Revision | 800674fc2c6162087525ed9b5bfc07230296b27d
OS | Windows 10 Version 22H2 (Build 19045.3930)

Toggle cookies settings via brave://settings/cookies

Case 1: Block third-party cookies_PASSED
  1. Clean profile 1.62.x
  2. Open brave://settings/cookies
  3. Confirm that the Block third-party cookies radio button is selected by default
  4. Open brave://settings/shields
  5. Confirm that the Only cross-stite cookies setting are populated by default in the Block cookies shields dropdown
  6. Open a site cnn.com in a NTP
  7. Click on View site information icon in the URL bar
  8. Click on Cookies and site data
  9. Confirmed that 3rd party cookies are blocked on the site
  10. Confirmed that no of sites allowed is shown on the cookies and site data modal
step 3 step 5 step 9
image image image
Case 2: Allow third-party cookies_PASSED
  1. Continuation of case 1
  2. Go to brave://settings/cookies
  3. Change the cookies settings by selecting Allow third-party cookies radio button
  4. Go to brave://settings/shields
  5. Confirm that the Disabled cookies setting is populated in the Block cookies shields dropdown
  6. Reload the site cnn.com which is opened via case 1
  7. Click on View site information icon in the URL bar
  8. Confirm that no of cookies allowed on the site as expected
step 3 step 5 step 8
image image image

Toggle cookies settings via brave://settings/shields

Case 1: Only cross-site_PASSED
  1. Clean profile 1.62.x
  2. Open brave://settings/shields
  3. Confirmed that Only cross-site cookies settings is selected by default in the Block cookies shields dropdown
  4. Go to brave://settings/cookies
  5. Confirm that the Block third-party cookies radio button is selected by default
  6. Open a site buzzfeed.com in a NTP
  7. Click on View site information icon in the URL bar
  8. Click on Cookies and site data
  9. Confirmed that 3rd party cookies are blocked on the site
  10. Confirmed that no of sites allowed is shown on the cookies and site data modal
step 3 step 5 step 9,10
image image image
Case 2: Disabled_PASSED
  1. Continuation of case 1
  2. Go to brave://settings/shields
  3. Change the cookies settings to Disabled via Block cookies shield settings
  4. Go to brave://settings/cookies
  5. Confirmed that Allow thrid-party cookies settings is selected
  6. Reload the site buzzfeed.com which is opened in case 1
  7. Click on View site information icon in the URL bar
  8. Click on Cookies and site data
  9. Confirm that no. of cookies allowed are shown on the cookies and site data modal
step 3 step 5 step 9
image image image
Case 3: All_PASSED
  1. Continuation of case 2
  2. Go to brave://settings/shields
  3. Change the cookies settings to block All via Block cookies shield settings
  4. Go to brave://settings/cookies
  5. Confirmed that Block third-party cookies and Allow thrid-party cookies settings are unchanged and both the settings are in non selectable state as there is no block all cookies settings in brave://settings/cookies now
  6. Reload the site buzzfeed.com which is opened in case 2
  7. Click on View site information icon in the URL bar
  8. Click on Cookies and site data
  9. Confirmed that no cookies are allowed, all the cookies are blocked as block all cookies settings is selected via brave://settings/shields
step 3 step 5 step 9
image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Chromium/upstream-test Issue involves an upstream unit or browser test OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants