insufficient funds notification and unable to contribute when wallet has more than enough BAT - follow up to 3212

[LaurenWags]

Description

Per additional comments on #3212 and some internal reports, some users are still experiencing this issue.

Sometimes users are getting a notification that alerts them that they don't have sufficient BAT to cover their auto contribution/recurring tips, but in fact, the user does have more than enough BAT for this. Subsequently, the contribution/recurring tips are not contributed.

Steps to Reproduce

Unknown at this time.

Actual result:

You get notification below 3 days prior.

At time of contribution, your contribution won't go through, you will get the below message:

Expected result:

Notification should not be shown when it is not needed.

Reproduces how often:

unsure

Brave version (brave://version info)

Brave	0.60.48 Chromium: 72.0.3626.121 (Official Build) (64-bit)
Revision	da3787ba355f18db7db52abf75c42afb408d656f-refs/branch-heads/3626@{#883}
OS	Mac OS X

Additional versions as well.

Reproducible on current release:

• Does it reproduce on brave-browser dev/beta builds? unsure

Website problems only:

• Does the issue resolve itself when disabling Brave Shields? n/a
• Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

#3212 (comment)
#3212 (comment)
#3212 (comment)

[mightypenguin]

I just got an alert that I Auto Contributed 1.5 BAT!
It does have a warning about how most of my BAT is to contributors that haven't signed up yet.
I didn't realize that could trigger this warning?

[Miyayes]

+1 from Reddit: https://www.reddit.com/r/BATProject/comments/b0dh3x/insufficient_funds_but_thats_not_true/

+1 from my personal experience as well.

[LaurenWags]

+1 from https://community.brave.com/t/no-monthly-rewards-or-tipping-possible/43571/5

[LaurenWags]

@mightypenguin to confirm, you're on version 0.61.51? Another user reported that after updating to 0.61.x they were able to contribute. Unsure if this will work for everyone, and unfortunately, we will have to just wait until contribution time comes in. Anyhow - glad you were able to contribute! I am not sure what you mean by triggering a warning? If you mean a message like this

then this is expected if you were contributing some amount to creators who have not yet verified with Brave.

[LaurenWags]

@NejcZdovc I just experienced this on a new-ish (about a month ago) dev profile - my personal one. I don't have any recurring monthly tips set up, my wallet balance is 39 BAT and my monthly auto contribute budget is 20 BAT. If there's any other info I can provide let me know.

[disfit]

Can confirm this on Linux platform. Had my monthly contribution go through in January and got the same message as @LaurenWags for February and March: see below. (Sorry, did not have time to post this earlier.

Currently on: Version 0.61.51 Chromium: 73.0.3683.75 (Official Build) (64-bit)
OS: Linux Mint 18.3 Cinnamon 64-bit, kernel 4.15.0-46-generic

On February 19th:

(I did not make a screenshot of the grants, but between February 19th and March 18th a grant of 25 BAT expired.)

On March 18th (3 days prior to contribution date):

And this morning March 21th:

If there is anything I can add to this, please let me know.

(edit: emphasis on dates and adding the grant expiration info)

[bsclifton]

Updated to 0.62.x after brave/brave-core#2116 was merged
cc: @ryanml

[LaurenWags]

@NejcZdovc @ryanml - test plan mentions changing reconcileStamp brave/brave-core#2028 however, we do not test with this (there were issues previously) so we always test reconcile with reconcile-interval flag. can one of you confirm if we should be using with reconcileStamp or reconcile-interval flag?
cc @brave/legacy_qa

[NejcZdovc]

I think should work with reconcile-interval flag

[btlechowski]

Verification passed on

Brave	0.62.49 Chromium: 73.0.3683.86 (Official Build) (64-bit)
Revision	f9b0bec6063ea50ce2b71f5b9abbae7beee319a6-refs/branch-heads/3683@{#858}
OS	Linux

Used test plan from brave/brave-core#2028 , but used --rewards=staging=true,reconcile-interval=1 flag instead. Tested on staging server.

Sufficient funds

Insufficient funds

Verified passed with

Brave	0.62.49 Chromium: 73.0.3683.86 (Official Build) (64-bit)
Revision	f9b0bec6063ea50ce2b71f5b9abbae7beee319a6-refs/branch-heads/3683@{#858}
OS	Mac OS X

Used test plan from brave/brave-core#2028 , but used --rewards=staging=true,reconcile-interval=10 flags instead. Tested on staging server.

Sufficient Funds:

Insufficient Funds:

Verification passed on

Brave	0.62.49 Chromium: 73.0.3683.86 (Official Build) (64-bit)
Revision	f9b0bec6063ea50ce2b71f5b9abbae7beee319a6-refs/branch-heads/3683@{#858}
OS	Windows 10 OS Build 17134.523

• Verified the test plan from Fixes false insufficient funds notification brave-core#2028 , but used --rewards=staging=true,reconcile-interval=5 flags instead. Tested on the staging server.

Sufficient Funds:

Insufficient Funds:

[felschr]

Just had this issue again today with v0.62.50.

[disfit]

Same here running on Version 0.62.51 Chromium: 73.0.3683.103 (Official Build) (64-bit):

Insufficient funds | Your Brave Rewards account is waiting for a deposit. 4/18/2019

Next contribution date is 4/20/2019

Wallet contains 778.9 BAT

Auto-contribute is set on signed on / verified publishers.

[LaurenWags]

@felschr @disfit we're tracking additional fixes for this with these issues: #4090 and #3897