Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Brave Leo on iOS #36585

Closed
kylehickinson opened this issue Mar 6, 2024 · 4 comments · Fixed by brave/brave-core#22200
Closed

Implement Brave Leo on iOS #36585

kylehickinson opened this issue Mar 6, 2024 · 4 comments · Fixed by brave/brave-core#22200
Assignees
@Brandon-T
Labels
browser-ai OS/iOS Fixes related to iOS browser functionality QA Pass-iPad QA Pass-iPhone QA/Test-All-Platforms QA/Yes release-notes/include
Milestone
1.63.x - Release #5

Comments

@kylehickinson
Copy link
Contributor

Description:

Implement Brave Leo in iOS

Related issues:
@kylehickinson kylehickinson added QA/Yes release-notes/include OS/iOS Fixes related to iOS browser functionality browser-ai labels Mar 6, 2024
@kylehickinson kylehickinson added this to the 1.65.x - Nightly milestone Mar 6, 2024
@kylehickinson kylehickinson mentioned this issue Mar 6, 2024
Merged
24 tasks
This was referenced Mar 6, 2024
Merged
Merged
@kjozwiak kjozwiak mentioned this issue Mar 8, 2024
Closed
26 tasks
@kjozwiak
Copy link
Member

kjozwiak commented Mar 8, 2024

The above requires 1.63.171 or higher for 1.63.x verification 👍

@Uni-verse @hffvld lets the issues outlined via #36585 (comment) as a guide of the different areas that we should check/run through but can add the verification notes via this issue. There's also #36596 (comment) which address some design changes.

This was referenced Mar 8, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@kjozwiak
Copy link
Member

kjozwiak commented Mar 15, 2024 •
edited

Verification PASSED on iPhone 11 running iOS 17.4 using the following build(s):

1.63.176 Chromium: 122.0.6261.128 (Official Build) unknown (64-bit)
--- | ---
Revision | 0767ff0f97fb...
OS | iOS

Restoring Leo credentials from Android account that purchased using CC# - PASSED

  • downloaded/installed 1.63.176 Chromium: 122.0.6261.128 via TF
  • tapped on Hamburger Menu -> Leo and ensured that the onboarding/T&S are being displayed
  • ensured that there's no strings/text indicating PREMIUM and displaying LIMITED for Mixtral & Claude Instant
  • logged into account.brave.com and logged into an account that already has a Leo subscription
    • this account purchased Leo on Android via the GPS and used a CC#
  • once logged into the account, ensured that the subscription plan is being displayed with the ability to Refresh Leo
    • ensured that it mentions Purchased on Android
  • tapped on Refresh Leo and ensured that the credentials were loaded without any issues in a reasonable time (~10s)
    • ensured that You have active credentials loaded! is being displayed via account.brave.com
  • ensured that Leo now appears as PREMIUM and both Mixtral & Claude Instant are listed as UNLIMITED
  • ensured that Advanced Settings is listing the all the Subscription information (expiry date etc..)
Example Example Example Example Example
IMG_0065 IMG_0066 IMG_0067 IMG_0068 IMG_0069
Example Example Example Example Example
IMG_0070 IMG_0071 IMG_0072 IMG_0078 IMG_0075

Restoring Leo & VPN credentials from Desktop account - PASSED

  • downloaded/installed 1.63.176 Chromium: 122.0.6261.128 via TF
  • tapped on Hamburger Menu -> Leo and ensured that the onboarding/T&S are being displayed
  • ensured that there's no strings/text indicating PREMIUM and displaying LIMITED for Mixtral & Claude Instant
  • logged into account.brave.com and logged into an account that already has a Leo & VPN subscription
    • this account is my main kamil@brave.com which has all the premium features via promo codes
  • once logged into the account, ensured that the subscription plans were being displayed
    • ability to Refresh both VPN & Leo credentials
  • tapped on Refresh VPN and ensured that the credentials were loaded without any issues in a reasonable time (~10s)
    • ensured that You have active credentials loaded! is being displayed via account.brave.com
    • ensured that a VPN configuration was created without any issues
    • ensured that the VPN connected without any issues
    • ensured that changing the regions worked without any issues (checked https://ipinfo.io)
  • tapped on Refresh Leo and ensured that the credentials were loaded without any issues in a reasonable time (~10s)
    • ensured that You have active credentials loaded! is being displayed via account.brave.com
  • ensured that Leo now appears as PREMIUM and both Mixtral & Claude Instant are listed as UNLIMITED
  • ensured that Advanced Settings is listing the all the Subscription information (expiry date etc..)
Example Example Example Example Example
IMG_0079 IMG_0080 IMG_0081 IMG_0082 IMG_0083
Example Example Example Example Example
IMG_0084 IMG_0085 IMG_0086 IMG_0087 IMG_0088
Example Example Example Example Example Example
IMG_0089 IMG_0090 IMG_0091 IMG_0093 IMG_0094 IMG_0095

Purchasing Leo via iOS and linking/restoring using Desktop - PASSED

Verification PASSED on iPhone 11 running iOS 17.4 using the following build(s):

1.63.177 Chromium: 122.0.6261.128 (Official Build) unknown (64-bit)
--- | ---
Revision | f43e1b1dc6dc...
OS | iOS
  • downloaded/installed 1.63.177 Chromium: 122.0.6261.128 via TF
  • tapped on Hamburger Menu -> Leo and ensured that the onboarding/T&S are being displayed
  • ensured that there's no strings/text indicating PREMIUM and displaying LIMITED for Mixtral & Claude Instant
  • tap on Hamburger Menu -> Settings -> Leo -> Go Premium
    • also used the purchase flow via the Leo context menu (gog/settings -> Go Premium)
  • tapped on Upgrade Now via the Leo Premium paywall screen and ensured that the TestFlight purchase screen displayed
  • tapped on Subscribe and signed in via Apple ID to complete the TF subscription purchase
  • once Leo has been purchased, tapped on Link purchase to your Brave account via the Leo settings
  • ensured that https://account.brave.com/?intent=link-order&product=leo (specifically intent=link-order)
  • used/logged into an account that doesn't have any Premium products associated with the account
  • once logged into the Brave Account, tapped on Link my subscription now
    • ensured that the Success! Your subscription is now linked message was displayed once linked
  • ensured that Leo appeared as a purchased premium product
    • ensured that Purchased on iOS is visible/being displayed

Purchasing Leo via Production via TF

Example Example Example Example Example
IMG_0096 IMG_0097 IMG_0099 IMG_0100 IMG_0101
Example Example Example Example Example
IMG_0102 IMG_0103 IMG_0104 IMG_0106 IMG_0123

Linking with Desktop using Production

Example Example Example Example Example
IMG_0124 IMG_0125 IMG_0126 IMG_0127 IMG_0128

Once launched 1.64.104 Chromium: 123.0.6312.46 using Win 11 x64 and went through the following:

  • logged into the same account that was used above via https://account.brave.com/account/
  • once logged in, verified that Leo was a product that appeared as Purchased
    • ensured that Purchased on iOS is visible/being displayed
  • clicked on Refresh Leo and ensured that new credentials were pulled and Leo switched to Premium on the desktop
  • ensured that Premium appeared throughout the UI and that Unlimited appeared next to each LLM (indicating Premium)
Example Example Example Example
link1 link2 link3 link4

@kjozwiak kjozwiak mentioned this issue Mar 19, 2024
Closed
@Uni-verse
Copy link
Contributor

Uni-verse commented Mar 19, 2024 •
edited

Verified on iPad (7th Gen) running iPadOS 17.0 using version 1.63.179

Leo related Issues

  • Went through and spot checked all the issues mentioned in Implement Brave Leo on iOS #36585 (comment)
    • Chat contextual menu
    • Feedback submit UI
    • Provide feedback UI
    • Enter prompt input UI
    • Suggested follow ups UI
    • Chat UI implementation
    • Top navigation UI
    • Default model menu UI
    • Brave-Leo settings menu UI

Restoring Leo credentials purchased on Android

  • downloaded/installed 1.63.179 Chromium: 122.0.6261.128 via TF
  • tapped on Hamburger Menu -> Leo and ensured that the onboarding/T&S are being displayed
  • ensured that there's no strings/text indicating PREMIUM and displaying LIMITED for Mixtral & Claude Instant
  • logged into account.brave.com and logged into an account that already has a Leo subscription
  • this account purchased Leo on Android via the GPS and used test card
  • once logged into the account, ensured that the subscription plan is being displayed with the ability to Refresh Leo
  • ensured that it mentions Purchased on Android
  • tapped on Refresh Leo and ensured that the credentials were loaded without any issues in a reasonable time (~10s)
  • ensured that You have active credentials loaded! is being displayed via account.brave.com
  • ensured that Leo now appears as PREMIUM and both Mixtral & Claude Instant are listed as UNLIMITED
  • ensured that Advanced Settings is listing the all the Subscription information (expiry date etc..)
  • ensured chat is working after upgrading
Example Example Example Example
IMG_1338 IMG_1339 IMG_1340 IMG_1341

Restoring Leo & VPN credentials from desktop account

  • downloaded/installed 1.63.179 Chromium: 122.0.6261.128 via TF
  • tapped on Hamburger Menu -> Leo and ensured that the onboarding/T&S are being displayed
  • ensured that there's no strings/text indicating PREMIUM and displaying LIMITED for Mixtral & Claude Instant
  • logged into account.brave.com and logged into an account that already has a Leo & VPN subscription
  • this account is my main smesheryakov@brave.com which has all the premium features via promo codes
  • once logged into the account, ensured that the subscription plans were being displayed
  • ability to Refresh both VPN & Leo credentials
  • tapped on Refresh VPN and ensured that the credentials were loaded without any issues in a reasonable time (~10s)
  • ensured that You have active credentials loaded! is being displayed via account.brave.com
  • ensured that a VPN configuration was created without any issues
  • ensured that the VPN connected without any issues
  • ensured that changing the regions worked without any issues (checked https://ipinfo.io)
  • tapped on Refresh Leo and ensured that the credentials were loaded without any issues in a reasonable time (~10s)
  • ensured that You have active credentials loaded! is being displayed via account.brave.com
  • ensured that Leo now appears as PREMIUM and both Mixtral & Claude Instant are listed as UNLIMITED
  • ensured that Advanced Settings is listing the all the Subscription information (expiry date etc..)
  • ensured that Leo chat is working after restoring with VPN enabled
Example Example Example Example Example Example Example
IMG_1321 IMG_1322 IMG_1323 IMG_1324 IMG_1325 IMG_1326 IMG_1332

@kjozwiak kjozwiak mentioned this issue Mar 19, 2024
Closed
@Uni-verse
Copy link
Contributor

Verified on iPhone 12 running iOS 17.3.1 using version 1.63.179

  • Verified using active credentials from desktop account to upgrade to Leo Premium after upgrading from 1.62.2 to 1.63.179
  • Went through and spot checked all the issues mentioned in Implement Brave Leo on iOS #36585 (comment)
    • Chat contextual menu
    • Feedback submit UI
    • Provide feedback UI
    • Enter prompt input UI
    • Suggested follow ups UI
    • Chat UI implementation
    • Top navigation UI
    • Default model menu UI
    • Brave-Leo settings menu UI
Example Example Example Example
IMG_5857 IMG_5858 IMG_5871 IMG_5873
IMG_5860 IMG_5861 IMG_5862 IMG_5863
IMG_5865
IMG_5866 IMG_5867 IMG_5868 IMG_5869

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Brandon-T Brandon-T

Labels
browser-ai OS/iOS Fixes related to iOS browser functionality QA Pass-iPad QA Pass-iPhone QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Milestone
1.63.x - Release #5
Development

Successfully merging a pull request may close this issue.

Implement AI-Chat for iOS brave/brave-core
5 participants
@kylehickinson @Brandon-T @kjozwiak @Uni-verse @brave-builds