[Playlist] Offline controls don't function as expected

[ShivanKaul]

Description

While we're downloading a media item for offline play (default behaviour), we should get rid of the "Keep for offline playing" option in the item's context menu. Since we're already downloading the media, this option doesn't make sense.
Worse, if you click "Keep for offline playing" a few times while the download is in progress, and then click "Remove offline data" (once the download completes), it doesn't respect the removal, and just starts downloading again. It does this as many times as you clicked "Keep for offline playing".

Steps to Reproduce

1. Go to a page with a large video that will take time to download. Example: https://www.youtube.com/watch?v=WknTbYOet4c
2. Add to Playlist
3. While item is downloading, click the kebab menu for the item

Actual result:

offline-data-removal-playlist.mov

Expected result:

1. Not see "Keep for offline playing" while item is downloading.
2. Clicking "Remove offline data" should never re-trigger download.

Reproduces how often:

Easily

Brave version (brave://version info)

1.66.70 Chromium: 124.0.6367.29 (Official Build) nightly (arm64)

[sangwoo108]

Wow, @ShivanKaul well spotted. I assume "keep for offline playing" just checks "uncached" itmes and queue the tasks. That's why it's retriggered as many times as "kepp for offline playing" was clicked.

[stephendonner]

Verification PASSED using

Brave | 1.67.45 Chromium: 124.0.6367.91 (Official Build) nightly (x86_64)
-- | --
Revision | f5b8b1597695a9fa4b57874e2a469ef8ad62ff48
OS | macOS Version 11.7.10 (Build 20G1427)

Followed the steps to reproduce from #37469 (comment)

Confirmed no Keep for offline playing option while downloading

Confirmed no refetching after Remove offline data was chosen

example	example	example

example	example	example