You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While we're downloading a media item for offline play (default behaviour), we should get rid of the "Keep for offline playing" option in the item's context menu. Since we're already downloading the media, this option doesn't make sense.
Worse, if you click "Keep for offline playing" a few times while the download is in progress, and then click "Remove offline data" (once the download completes), it doesn't respect the removal, and just starts downloading again. It does this as many times as you clicked "Keep for offline playing".
Wow, @ShivanKaul well spotted. I assume "keep for offline playing" just checks "uncached" itmes and queue the tasks. That's why it's retriggered as many times as "kepp for offline playing" was clicked.
Description
While we're downloading a media item for offline play (default behaviour), we should get rid of the "Keep for offline playing" option in the item's context menu. Since we're already downloading the media, this option doesn't make sense.
Worse, if you click "Keep for offline playing" a few times while the download is in progress, and then click "Remove offline data" (once the download completes), it doesn't respect the removal, and just starts downloading again. It does this as many times as you clicked "Keep for offline playing".
Steps to Reproduce
Actual result:
offline-data-removal-playlist.mov
Expected result:
Reproduces how often:
Easily
Brave version (brave://version info)
1.66.70 Chromium: 124.0.6367.29 (Official Build) nightly (arm64)
The text was updated successfully, but these errors were encountered: