Upgrade from Chromium 126 to Chromium 127

[emerick]

Description

Upgrade from Chromium 126 to Chromium 127

https://chromium.googlesource.com/chromium/src/+log/126.0.6478.114..127.0.6533.17/?pretty=fuller&n=10000

QA tests:
This is a major Chromium version bump, please do full passes.

Desktop Affected areas:

• Verify hamburger menu UI, icons, items, ordering
• Verify tab UI, style, and functionality (rearranging tabs, tearing off tabs, vertical tabs, tab groups, etc.)
• Verify tab search UI and functionality
• Verify clear browsing data functionality
• Verify all side panel related functionality
• Verify all toolbar related functionality
• Verify profile related functionality (creating new profiles, guest profiles, avatar selection, profile menu, etc.)
• Verify browser themes functionality and light/dark mode
• Verify page info functionality, specifically cookie-related info
• Verify ad notifications UI and functionality
• Verify omnibox UI and functionality
• Verify default search engine functionality
• Ensure that supported MV2 extensions continue to load and run as expected

iOS Affected areas:

• Nothing specific to note

Android Affected areas:

• NTP UI (double check no regresson)
• Bottom toolbar (double check no changes in UI and behaviour)
• Privacy settings (all the same items are still there)
• SafeBrowsing (double check there is no regression)
• Switching tabs (double check no UI issues here)

[GeetaSarvadnya]

Verification PASSED on

Brave | 1.69.53 Chromium: 127.0.6533.17 (Official Build) nightly (64-bit)
-- | --
Revision | bedcc2e74ce45bd641d2946e0d870d68ba08b8e9
OS | Windows 10 Version 22H2 (Build 19045.4529)

• Logged [CR 127] - Grouped history hamburger settings menu is inherited from chrome and click on it doesn't open the history in side panel #39377
• Logged [CR 127] - cookies site data and site settings icon are changed as part of CR127 #39380
• Logged [CR 127] - Certificate is valid icon is inherited from Chrome #39381
• Logged [CR 127] - redundant sidebar settings added via brave://settings/appearance #39382
• Logged Tor button size/spacing is small as compared to CR 126 Tor button.  #39383
• Logged [CR 127] - Update brave notification text is not visible #39428

Verify hamburger menu UI, icons, items, ordering_PASSED

• Verified the side panel testing in Settings comparison section below
• Logged and encountered [CR 127] - Grouped history hamburger settings menu is inherited from chrome and click on it doesn't open the history in side panel #39377

Verify tab UI, style, and functionality (rearranging tabs, tearing off tabs, vertical tabs, tab groups, etc.)_PASSED

Horizontal tabs view:

Confirmed that tabs drag and drop works as expected for Horizontal tabs

Vertical tabs view:

Confirmed that tabs drag and drop works as expected for Vertical tabs

Tab groups

• Confirmed tab groups works as expected
  

Tab shapes:

• Confirmed that Tab shapes are shown as expected in Card tab type
• Confirmed that Tab shapes are shown as expected in Card with preview tab type
• Confirmed that Tab shapes are shown as expected in Tooltip tab type

Card	Card with preview	Tooltip

active/inactive tab colors:

• Confirmed that active/inactive tab colors are shown as expected

Verify tab search UI and functionality_PASSED

• Confirmed that all the opened/closed tabs are opened via Tab search panel
• Confirmed that user can see recently closed tabs via Tab search panel
• Confirmed that user can search specific site via Tab search panel
• Confirmed that user can close the specific tab via Tab search panel

Example	Example	Example

Verify clear browsing data functionality_PASSED

• Confirmed that browser data can be delted via hamburger settings menu Delete browsing data or via brave://settings/privacy Delete browsing data
• Click on Delete browsing data opens up the Delete browsing data popup modal
  
• Confirmed that user can delete the browsing data

Verify all side panel related functionality_PASSED

• Verified the side panel testing in Settings comparison section below
• Logged and encountered [CR 127] - redundant sidebar settings added via brave://settings/appearance #39382

Verify all toolbar related functionality_PASSED

Tab search

• Confirmed that Tab search toolbar icon is displayed as expected
• Confirmed that all the opened/closed tabs are opened via Tab search panel
• Confirmed that user can see recently closed tabs via Tab search panel
• Confirmed that user can search specific site via Tab search panel
• Confirmed that user can close the specific tab via Tab search panel

Rewards:

• Confirmed that rewards BAT toolbar icon is displayed as expected
• Confirmed that Rewards panel works as expected
• Confirmed that publisher info is shown as expected on rewards panel
• Confirmed that AC notification shown as expected on BR panel

Example	Example	Example	Example

Shields

• Confirmed that shields toolbar icon is displayed as expected
• Shield panel is shown as expected in normal view
• Shield panel is shown as expected in advanced view
• Shield panel is shown as expected disabled mode

Example	Example	Example

Sidebar toolbar icon

• Confirmed that Sidebar toolbar icon is displayed as expected
• Confirmed that click on sidebar icon displayed the sidebar panel as expected
• Confirmed that icons on the sidebar panel works as expected

Example	Example	Example

Wallet

• Confirmed that wallet toolbar icon is displayed as expected
• Confirmed that click on wallet opens up the wallet modal popup
• Confirmed that user can create wallet

VPN

• Confirmed that VPN panel is shown as expected in connected state
• Confirmed that VPN panel is shown as expected in disconnected state
• Confirmed that VPN panel is shown as expected in connecting state
• Confirmed that VPN panel is shown as expected in region selection state
• Confirmed that VPN panel is shown as expected in error state

Example	Example	Example	Example

Verify profile related functionality (creating new profiles, guest profiles, avatar selection, profile menu, etc.)_PASSED

• Confirmed that user can create a new profile via Hamburger menu->More tools->Add new profile
• Confirmed that user can pick different avatar for each profile
• Confirmed that user can edit the profile name/avatar via profile manager
• Confirmed that user can open the guest window via profile menu
• Confirmed that user can open guest window via profile manager

Example	Example	Example	Example	Example

Verify browser themes functionality and light/dark mode_PASSED

• Confirmed that toolbar icons, settings and omnibox looks as expected in Light theme
• Confirmed that toolbar icons, settings and omnibox looks as expected in Dark theme

Light theme

Example	Example

Dark theme

Example	Example

Themes from CWS

Example	Example	Example	Example

Verify page info functionality, specifically cookie-related info_PASSED

Update the cookies setting

1. Open a site A and and click on the site information icon and ensured that the third party cookies are blocked on the site A
   
2. Go to brave://settings/shields and select Block all cookies
3. Reload the site A and click on the site information icon and ensured that the third party cookies are blocked on the site A
   
4. Open the shield panel on site A and ensure that global cookies settings are applied
   
5. Go to brave://settings/shields and select Allow all cookies
6. Reload the site A and click on the site information icon and ensured that the cookies are allowed on the site A
   
7. Open the shield panel on site A and ensure that global cookies settings are applied
   

Check Allow cookies functionality:

1. Clean profile 1.69.x CR 127
2. Go to brave://settings/shields
3. Change cookies settings to Block all cookies
4. Open a site A
5. Open shields panel and ensure that block all cookies settings selected in the dropdown
6. Click on site information on a Site A and ensure that all the cookies are blocked
   
7. Go to brave://settings/cookies
8. Click on Add button and add a Site B to allow cookies list
   
9. Open site B in a NTP
10. Click on site information on a Site B and ensure that all the cookies are allowed as site B is added into allow cookies list in step 8
    
11. Open shield panel for site B
12. Ensured that global cookies settings are applied as expected
    

Case 1:

1. Clean profile 1.69.x - CR 127
2. Open a site
3. Click on the site shield settings
4. Change the trackers and ad blocking settings from Block third part cookies to Block all cookies
5. Restart the browser
6. Open the site shield settings, confirmed updated cookies settings are retained

Case 2:

1. Continuation of case 1
2. Open a site
3. Click on the site shield settings
4. Change the trackers and ad blocking settings from Block all cookies to Allow all cookies
5. Restart the browser
6. Open the site shield settings, confirmed updated cookies settings are retained

Case 3:

1. Continuation of case 2
2. Open a site
3. Click on the site shield settings
4. Change the trackers and ad blocking settings from Allow all cookies to Block third party site cookies
5. Restart the browser
6. Open the site shield settings, confirmed updated cookies settings are retained

Verify ad notifications UI and functionality_PASSED

1. Notification ads_PASSED

• Confirmed that notification ads are shown as expected
• Confirmed that ad notification UI looks as expected
• Confirmed that users are rewarded for viewing notification ads
• Confirmed that notification ads are displayed under ads history

Example	Example

[8028:2992:0628/215006.255:VERBOSE1:notification_ad_handler.cc(176)] Served notification ad impression:
  placementId: c11f5ef7-4682-40fa-bcf9-b3dd9c064b87
  creativeInstanceId: 9c3c29bd-8266-456a-89c1-49270ef687a0
  creativeSetId: 45ea5952-37ca-41f0-88c2-4b546b0e6f4b
  campaignId: 1c1ac828-db13-49bb-9128-090132044b7f
  advertiserId: ecbcc833-8b1d-4867-98f7-ad2341396ce8
  segment: untargeted
  title: Ad4
  body: Ad4
  targetUrl: https://brave.com/
[8028:2992:0628/215006.265:VERBOSE1:notification_helper_impl_win.cc(182)] Notifications are enabled

[8028:2992:0628/215006.344:VERBOSE3:account.cc(179)] Successfully processed deposit for ad_notification with creative instance id 9c3c29bd-8266-456a-89c1-49270ef687a0 and view valued at 0.01

2. NTP ads_PASSED

• Viewed an NTP SI in production env
• Confirmed that users are rewarded for viewing NTP ads
• Confirmed that NTP ads are displayed under ads history

Example	Example

3. Inline content ads_PASSED

• Viewed inline content ads by enabling Brave news
• Confirmed that user are rewarded for viewing inline content ads
• Confirmed that inline content ads are displayed under ads history panel

Example	Example

[4432:15576:0628/220520.034:VERBOSE1:inline_content_ad_handler.cc(193)] Served inline content ad:
  placementId: a0df267d-d75e-47ff-bded-d2b0da9eb43c
  creativeInstanceId: fe7e925e-5490-431b-b788-4c64f5543e0d
  creativeSetId: f1886272-e83d-4efb-b53c-72a1c79ae0b3
  campaignId: 07de7f05-ab32-4af0-a350-a1bce4427eac
  advertiserId: 93130af3-2def-4ecb-b836-b3772e73b3c9
  segment: untargeted
  title: Staging - Inline Test 3
  description: Fung Brave News Inline Display Ad - windows
  imageUrl: https://pcdn.brave.com/brave-ads/468beb93-2458-5d3e-8d7b-bc1f387d2e9b.webp.pad
  dimensions: 900x750
  ctaText: Work at Brave
  targetUrl: https://brave.com/careers
[4432:15576:0628/220520.049:VERBOSE3:inline_content_ad_handler.cc(200)] Served inline content ad impression with placement id a0df267d-d75e-47ff-bded-d2b0da9eb43c and creative instance id fe7e925e-5490-431b-b788-4c64f5543e0d

[4432:15576:0628/220533.078:VERBOSE3:account.cc(179)] Successfully processed deposit for inline_content_ad with creative instance id fe7e925e-5490-431b-b788-4c64f5543e0d and view valued at 0.025

4. Search ads_PASSED

To trigger a search ad use: https://search.brave.software/search?q=chainlink
The credentials are in 1password.
The server is linked to ads staging server.

• Users are not rewarded for viewing search ads (need to check with @btlechowski )
• Confirmed that search ads are displayed under ads history panel

Example	Example

[11504:8888:0628/222316.416:VERBOSE6:search_result_ad_converting_util.cc(361)] Creative search result ad attributes:
  "data-placement-id": 48ff0cc4-1066-420c-a542-8462a697085d
  "data-creative-instance-id": 788a9319-9ff9-4cf8-944b-98dcdc3dbfa8
  "data-creative-set-id": d04f6627-4b81-45a9-9fae-d01e4a851b93
  "data-campaign-id": 56fc9d5a-5540-46d4-8c10-70573e9d5a3d
  "data-advertiser-id": 5f1ec21a-3526-4504-b0b7-ffe17e8de8bb
  "data-landing-page": https://brave.com/brave-ads/?brave-creative-id=788a9319-9ff9-4cf8-944b-98dcdc3dbfa8&oustide_key_param=inside_key_param=itsnotbranded
  "data-headline-text": [STAGING] Brave Ads
  "data-description": testing param replacement
  "data-rewards-value": 0
[11504:8888:0628/222316.416:VERBOSE6:search_result_ad_converting_util.cc(380)] Creative search result ad conversion attributes:
  "data-conversion-url-pattern-value": https://brave.com/vertical-tabs/*
  "data-conversion-advertiser-public-key-value":
  "data-conversion-observation-window-value": 604800 s
[11504:8888:0628/222316.440:VERBOSE3:search_result_ad_handler.cc(164)] Served search res

[11504:8888:0628/222316.547:VERBOSE3:account.cc(179)] Successfully processed deposit for search_result_ad with creative instance id 788a9319-9ff9-4cf8-944b-98dcdc3dbfa8 and view valued at 0

Verify omnibox UI and functionality_PASSED

Omnibox:

• Confirmed that info bar color looks as expected in light theme
• Confirmed that info bar color looks as expected in Dark theme
• Verified the info bar color in PT/PT with TOR/Guest windows and ensured that the info bar color looks as expected
• Confirmed that the icons in the URL bar works as expected

Light theme	Dark theme	Suggestions

Verify default search engine functionality_PASSED

IN (India) locale

Clean Profile - PASSED

• ensured that Brave was selected as the default for both Normal/Private windows via brave://settings/search
• ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
• ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
• ensured that Brave was selected as the default via brave://settings/searchEngines

Example	Example	Example	Example

Updated Profile (Google/Google - default SE) - PASSED

• installed 1.48.61
• ensured that Google was the default SE selected under brave://settings/search for Normal Windows
• changed Brave to Google for default SE for Private Windows
• updated to 1.69.x CR127 and ensured that Google is still the default SE in both Normal and Private windows SE
  • ensured that it wasn't replaced by Brave
• ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
• ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows

1.48.x	1.48.x

1.69.x	1.69.x	1.69.x

Updated Profile (Startpage/DDG - modified SE) - PASSED

• installed 1.48.x
• Selected Startpage as the default SE selected under brave://settings/search for Normal Windows
• Change Brave to DDG as the default SE for Private Windows
• updated to 1.69.x CR127 and ensured that previously selected SE is still the default for both Normal and Private windows
  • Normal Windows = Startpage and Private Windows = DDG
• ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
• ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
• ensured that Brave was the first engine via the list under brave://settings/searchEngines

1.48.x	1.48.x

1.69.x	1.69.x	1.69.x	1.69.x

Australia locale

Clean Profile - PASSED

• ensured that Google was selected as the default for Normal windows and Brave was selected as the default for Private windows via brave://settings/search
• ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
• ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
• ensured that Google was selected as the default via brave://settings/searchEngines and Brave was listed first

Example	Example	Example	Example

Updated Profile (Google/Google - default SE) - PASSED

• installed 1.68.x
• ensured that Google was the default SE selected under brave://settings/search for normal windows
• changed default SE for Private windows from Brave to Google
• updated to 1.69.x cr127 and ensured that Google is still the default SE in both Normal and Private window SE
• ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
• ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
• ensured that Brave was the first engine via the list under brave://settings/searchEngines

1.68.x	1.68.x

• 1.69.x | 1.68.x | 1.68.x | 1.68.x
  ---------------|--------------|--------------|-----------
  | | |

Ensure that supported MV2 extensions continue to load and run as expected_PASSED

Note: The Adblock and Adblock Plus extensions are NOT working on both Brave and Chrome, which is fine as per the comments https://bravesoftware.slack.com/archives/C7VLGSR55/p1719861726168549?thread_ts=1719836286.009949&cid=C7VLGSR55

Ublock origin_PASSED

1. Clean profile 1.69.x
2. Install Ublock origin extension
3. Open cnn.com and disable the shield for cnn.com
4. Reload cnn.com
5. Confirmed that ads are blocked on the site cnn.com and ensured that Ublock origin extension works as expected
6. Open brave RC/Beta
7. Open cnn.com and disable shield for cnn.com
8. Ensured that Ads are NOT blocked as expected (as shield is disabled on cnn.com and there are no Adblock extensions installed)
9. Open a new site (e.g nytimes.com) in an NTP on 1.69.x
10. Disable shields for nytimes.com
11. Reload nytimes.com
12. Confirmed that ads are blocked on the site nytimes.com and ensured that Ublock origin extension works as expected
13. Open nytimes.com in an NTP on RC/Beta
14. Disable shields for nytimes.com and reload nytimes.com
15. Ensured that Ads are NOT blocked as expected (as shield is disabled on cnn.com and there are no Adblock extensions installed)

step 5	step 8	step 12	step 15

Adblock_Partially working

1. Clean profile 1.69.x CR 127
2. Install Adblock extension via CWS
3. Open bunch of sites and disable shields for all the sites (buzzfeed.com, theverge.com, nytimes.com and cnn.com)
4. Reload all the sites after disabling shields
5. Open buzzfeed.com and nytimes.com and ensured that Ads are blocked and ensured Adblock extension works as expected
6. Open theverge.com (Ads are not blocked looks like bug)
   

Adblock Ultimate_PASSED

1. Clean profile 1.69.x CR 127
2. Install Adblock Ultimate extension via CWS
3. Open bunch of sites and disable shields for all the sites (buzzfeed.com, theverge.com, nytimes.com and cnn.com)
4. Reload all the sites after disabling shields
5. Open all the site and confirmed Ads are blocked and ensured Adblock Ultimate extension works as expected

Adblock Plus_Partially working

1. Clean profile 1.69.x CR 127
2. Install Adblock Plus extension via CWS
3. Open bunch of sites and disable shields for all the sites (buzzfeed.com, theverge.com, nytimes.com and cnn.com)
4. Reload all the sites after disabling shields
5. Open buzzfeed.com and nytimes.com and ensured that Ads are blocked and ensured Adblock Plus extension works as expected
6. Open cnn.com and theverge.com (Ads are not blocked looks like bug)
   

Stands AdBlocker_PASSED

1. Clean profile 1.69.x CR 127
2. Install Stands Adblocker extension via CWS
3. Open bunch of sites and disable shields for all the sites (buzzfeed.com, theverge.com, nytimes.com and cnn.com)
4. Reload all the sites after disabling shields
5. Open all the site and confirmed Ads are blocked and ensured Stands Adblocker extension works as expected

---

Settings comparison

1. A new settings Sidebar is added as part of Brave via Hamburger menu
   
   • The Sidebar settings is On by default
   • Click on Off sidebar settings hide the sidebar settings
   • Click on Autohide sidebar settings autohide the sidebar settings
   • Change the sidebar settings via brave://settings/appearance and ensured that the changes are reflected on the hamburger sidebar settings options on/off
   • Change the sidebar settings via hamburger menu and ensured that the changes are reflected on sidebar settings via brave://settings/appearance
2. New settings Manifest v2 extensions is added as part of Brave via brave://settings/extensions

Example	Example

17. A new content settings Automatic full screen is added via brave://settings/content as part of CR127
    

Brave startup calls

• Confirmed that only brave domains are listed in the Charles when the nightly build is launched with a clean profile
• Confirmed no calls to google, gstatic, etc domains when the nightly build is launched with a clean profile

[Uni-verse]

Verified on Samsung Galaxy S21 using version:

Brave	1.69.55 Chromium: 127.0.6533.17 (Official Build) canary (64-bit) 
Revision	c2c742fba6902889df5e08e3f3f276f5c33f048e
OS	Android 13; Build/TP1A.220624.014; 33; REL

Summary of testing based on #38560 (comment)

NTP UI

• Ensured NTP UI in general has not regressed.
• Ensured Brave News opt-in card is shown and can be dismissed from NTP.
• Ensured news feed is shown when enabling Brave News from NTP.
• Ensured all settings are working in New Tab Page settings page.
• Ensured that opening tabs has not regressed.
• Ensured all tab view functionality and menu items.

Encountered: #39432

Example	Example	Example	Example

Bottom toolbar

• Ensured all toolbar and search functionality has not regressed with bottom toolbar enabled/disabled.
• Ensured bottom toolbar is enabled by default for new users.
• Ensured that bottom toolbar setting is shown in Appearance settings page

Example	Example	Example	Example

Privacy settings

• Ensured none of the privacy settings have regressed in Brave Shields & Privacy.

SafeBrowsing

• Ensured SafeBrowsing protection is working by running some tests on https://testsafebrowsing.appspot.com/
• Ensured disabling SafeBrowsing protection will not show interstitial warning page when visiting a dangerous site.
• Ensured SafeBrowsing is shown in the privacy settings and enabled by default.

Example	Example	Example	Example

Switching Tabs

• Ensured switching tabs in tab view has no regressed.
• Ensured there are no issues switching / moving and deleting tabs in and out of tab groups.
• Ensured switching between private tabs and normal tab mode.

Example	Example	Example

[Uni-verse]

Verified on Samsung Tab S7 using version:

Brave	1.69.65 Chromium: 127.0.6533.26 (Official Build) canary (64-bit) 
Revision	2c13a0566fdd2ef6a495035fd1efe1b123bc7d48
OS	Android 13; Build/TP1A.220624.014; 33; REL

Encountered:

• Hamburger menu does not open after closing all tabs #39464
• Add to home screen UI shows chrome branding [CR127] #39502

Summary of testing based on #38560 (comment)

NTP UI

• Ensured NTP UI in general has not regressed.
• Ensured Brave News opt-in card is shown and can be dismissed from NTP.
• Ensured news feed is shown when enabling Brave News from NTP.
• Ensured all settings are working in New Tab Page settings page.
• Ensured that opening tabs has not regressed.
• Ensured all tab view functionality and menu items.

Example	Example	Example	Example

Privacy settings

• Ensured none of the privacy settings have regressed in Brave Shields & Privacy.

Example	Example	Example

SafeBrowsing

• Ensured SafeBrowsing protection is working by running some tests on https://testsafebrowsing.appspot.com/
• Ensured disabling SafeBrowsing protection will not show interstitial warning page when visiting a dangerous site.
• Ensured SafeBrowsing is shown in the privacy settings and enabled by default.

Example	Example	Example	Example

Switching Tabs

• Ensured switching tabs in tab view has no regressed.
• Ensured there are no issues switching / moving and deleting tabs in and out of tab groups.
• Ensured switching between private tabs and normal tab mode.

Example	Example	Example

[Uni-verse]

Verified on iPhone 12 running iOS 17.5.1 using version 1.69 (70)

• Ensured UI, Settings, Rewards and Shields have not regressed for Chromium 127

Example	Example	Example	Example

[kjozwiak]

Closing in favour of #39401 (comment).