Upgrade from Chromium 126 to Chromium 127 #23829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
CI/run-network-audit
|
A Storybook has been deployed to preview UI for the latest push |
|
A Storybook has been deployed to preview UI for the latest push |
|
A Storybook has been deployed to preview UI for the latest push |
|
A Storybook has been deployed to preview UI for the latest push |
|
A Storybook has been deployed to preview UI for the latest push |
|
A Storybook has been deployed to preview UI for the latest push |
|
A Storybook has been deployed to preview UI for the latest push |
|
A Storybook has been deployed to preview UI for the latest push |
|
A Storybook has been deployed to preview UI for the latest push |
|
A Storybook has been deployed to preview UI for the latest push |
|
A Storybook has been deployed to preview UI for the latest push |
|
A Storybook has been deployed to preview UI for the latest push |
|
A Storybook has been deployed to preview UI for the latest push |
|
A Storybook has been deployed to preview UI for the latest push |
|
A Storybook has been deployed to preview UI for the latest push |
|
A Storybook has been deployed to preview UI for the latest push |
|
A Storybook has been deployed to preview UI for the latest push |
We disable this service on iOS, but let's also disable it on desktop. Chromium change: https://source.chromium.org/chromium/chromium/src/+/6952ce1a5bab9ac1cf2c190883bd0e152ebc5f41 commit 6952ce1a5bab9ac1cf2c190883bd0e152ebc5f41 Author: Marc Treib <treib@chromium.org> Date: Tue May 14 21:50:04 2024 +0000 Migrate GoogleGroupsUpdaterService to SyncServiceObserver Before this CL, GoogleGroupsUpdaterService exposed a public ClearSigninScopedState() and relied on users (in practice, the implementations of SyncClient::OnLocalSyncTransportDataCleared()) to call it at the right time. This CL migrates it to implement SyncServiceObserver instead, and internally clear the state at the right time (i.e. when the sync TransportState becomes DISABLED). The new behavior is not 100% identical to the old one, but it's very close and should work out to the same thing in practice. The new implementation is cleaner architecture-wise, and will (after some additional changes) allow us to get rid of SyncClient::OnLocalSyncTransportDataCleared(). Bug: 40724759, 337034860
Replaced upstream's chrome refresh icon version that we've been using.
… for tabs
Now that ChromeRefresh2023 is active, the ThemeColorPickerHandler is using a
tri-color picker and foreground/background tabs and the tab strip were not
taking on theme colors as expected.
This change creates overrides to:
- Replace SetUserColorAndBrowserColorVariant with
BuildAutogeneratedThemeFromColor to correct the theme coloring for tabs and
the tab strip.
- Replace kGeneratedColorsInfo with kCustomizeChromeColors, allowing us to
return to using the bi-color theme picker in brave://settings and the
profile dialog. We call getChromeColors with extended_list=true from
TypeScript in order to take advantage of this code path in the theme
handler.
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/05baea744f4111671b9e3b9baf28f8c1727f78c5
commit 05baea744f4111671b9e3b9baf28f8c1727f78c5
Author: Alison Gale <agale@chromium.org>
Date: Wed May 15 17:38:31 2024 +0000
Remove references to launched kChromeRefreshSecondary2023 feature
Also cleaned up some test-only references to kChromeRefresh2023 when
they were adjacent.
#chrome-refresh-2023-cleanup
Bug: 335904039
This reverts commit f2a3b1b.
Since the IsolateSandboxedIframes feature flag was enabled, the chrome-untrusted://line-chart-display Wallet browser tests for the portfolio chart have been failing. In order to temporarily work around those failures, we've added allow-same-origin to the sandbox attribute for that chart. Entered brave/brave-browser#38771 to address this in a follow-up. Chromium change: https://source.chromium.org/chromium/chromium/src/+/b2c49e9ef800bc606041fc9356e665d11869cb30 commit b2c49e9ef800bc606041fc9356e665d11869cb30 Author: W. James MacLean <wjmaclean@chromium.org> Date: Wed May 15 19:54:12 2024 +0000 Enable IsolateSandboxedIframes by default. This CL enables the IsolateSandboxedIframes feature by default. Bug: 40082497
This avoids the following DCHECK: Check failed: instance->IsTestRenderFrameHost(). You may want to instantiate RenderViewHostTestEnabler.
Disabling this feature flag (which is enabled on iOS and Android by default) for now as it requires a Google account and possibly other backend support.
After deleting 2023UIRefresh features, upstream's all new color mixers are added and it overwrites our colors. Some of them are called from our code and others are not needed.
After deleting 2023UIRefresh, upstream's toolbar margin is increased. This causes our toolar has more long height. Back to previous value.
After deleting 2023UIRefresh, more larger text button's vertical padding is set. This made dialog button bigger. Set to previous vertical padding.
This crate has been dropped in upstrem but it is still required in brave. This change checks it out in our tree. Chromium change: https://chromium.googlesource.com/chromium/src/+/2a140ac6fc6943d7689fc41f8c4573e3d27cba7d commit 2a140ac6fc6943d7689fc41f8c4573e3d27cba7d Author: danakj <danakj@chromium.org> Date: Mon May 27 15:45:04 2024 +0000 Roll winapi-util: 0.1.6 => 0.1.8 in //third_party/rust. This change moves the dependency for windows bindings from winapi to the windows-rs crates published by Microsoft. Those crates come with .lib files that must be made available for linking, so we add them to gnrt_config.toml under the `native_libs_roots` variable. Native libs are copied into the toolchain's `./rustlib` directory and that directory is added to the library search path in order to find them there. This ensures the correct architecture library is used for host toolchains. This CL has been created semi-automatically. The expected review process and other details can be found at //tools/crates/create_update_cl.md Updated crates: * winapi-util: 0.1.6 => 0.1.8 New crates: * windows-sys@0.52.0 * windows-targets@0.52.5 * windows_aarch64_gnullvm@0.52.5 (as placeholder) * windows_aarch64_msvc@0.52.5 * windows_i686_gnu@0.52.5 (as placeholder) * windows_i686_gnullvm@0.52.5 (as placeholder) * windows_i686_msvc@0.52.5 * windows_x86_64_gnu@0.52.5 (as placeholder) * windows_x86_64_gnullvm@0.52.5 (as placeholder) * windows_x86_64_msvc@0.52.5 Removed crates: * winapi-i686-pc-windows-gnu@0.4.0 * winapi-x86_64-pc-windows-gnu@0.4.0 * winapi@0.3.9 Chromium `supply-chain/config.toml` policy requires that the following audit criteria are met (note that these are the *minimum* required criteria and `supply-chain/audits.toml` can and should record a stricter certification if possible; see also //docs/rust-unsafe.md): * winapi-util@0.1.8, windows-sys@0.52.0, windows-targets@0.52.5, windows_aarch64_gnullvm@0.52.5, windows_aarch64_msvc@0.52.5, windows_i686_gnu@0.52.5, windows_i686_gnullvm@0.52.5, windows_i686_msvc@0.52.5, windows_x86_64_gnu@0.52.5, windows_x86_64_gnullvm@0.52.5, windows_x86_64_msvc@0.52.5: does-not-implement-crypto, safe-to-run Fixed: 342194487
Crates under this path were triggering format. This mirrors what is being done in upstream.
github-actions
bot
added
the
CI/storybook-url
|
A Storybook has been deployed to preview UI for the latest push |
bridiver
approved these changes
Jun 25, 2024
emerick
added a commit
that referenced
this pull request
Jun 25, 2024
Upgrade from Chromium 126 to Chromium 127
24 tasks
emerick
added a commit
that referenced
this pull request
Jun 25, 2024
Upgrade from Chromium 126 to Chromium 127
emerick
added a commit
that referenced
this pull request
Jun 25, 2024
Upgrade from Chromium 126 to Chromium 127
mkarolin
pushed a commit
that referenced
this pull request
Jul 2, 2024
Upgrade from Chromium 126 to Chromium 127
mkarolin
pushed a commit
that referenced
this pull request
Jul 2, 2024
Upgrade from Chromium 126 to Chromium 127
kjozwiak
pushed a commit
that referenced
this pull request
Jul 3, 2024
* Merge pull request #23829 from brave/cr127 Upgrade from Chromium 126 to Chromium 127 * Support IndexedHostContentSettingsMap feature in Brave provider. (#24027) * Use NOTREACHED_NORETURN in domain block throttle. (#24292) * Fixed omnibox flickering with download toolbar button toggle fix brave/brave-browser#39373 Our download button used smaller image size than other toolbar buttons. Set same icon size with other toolbar buttons. * Merge pull request #24391 from brave/cr127-followup-remove-redundant-sidepanel-settings Remove redundant side panel settings * Merge pull request #24394 from brave/127.0.6533.26_master Upgrade from Chromium 127.0.6533.17 to Chromium 127.0.6533.26 * Merge pull request #24422 from brave/fix_app_menu_button_upgrade_alert_regression Fix app menu button upgrade alert regression * Merge pull request #24412 from brave/android_tablet_ntp_fix [C127] [Android] Fix for tablet NTP crash * Merge pull request #24425 from brave/android_tablet_no_tabs_ui_fix [C127] [Android] Fix for tablet overview UI with no tabs * Merge pull request #24428 from brave/maxk-hide-history-groups-menu-item Hides Grouped History menu item. * Merge pull request #24460 from brave/android_webapps_branding_fix [C127] [Android] Fix for web app branding icon and string --------- Co-authored-by: goodov <5928869+goodov@users.noreply.github.com> Co-authored-by: Simon Hong <shong@brave.com> Co-authored-by: Max Karolinskiy <41635752+mkarolin@users.noreply.github.com> Co-authored-by: samartnik <30602739+samartnik@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#38560
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: