Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 126.0.6478.40 to Chromium 126.0.6478.56 #38974

Closed
emerick opened this issue Jun 11, 2024 · 8 comments · Fixed by brave/brave-core#24138
Closed

Upgrade from Chromium 126.0.6478.40 to Chromium 126.0.6478.56 #38974

emerick opened this issue Jun 11, 2024 · 8 comments · Fixed by brave/brave-core#24138

Comments

@emerick
Copy link
Contributor

emerick commented Jun 11, 2024

Minor Chromium bump

https://chromium.googlesource.com/chromium/src/+log/126.0.6478.40..126.0.6478.56?pretty=fuller&n=10000

QA tests

  • Check branding items
  • Check for version bump

Minor Chromium bump

  • No specific code changes in Brave (only line number changes in patches)
@emerick emerick added QA/Yes release-notes/include QA/Test-Plan-Specified OS/Android Fixes related to Android browser functionality Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Desktop labels Jun 11, 2024
@emerick emerick changed the title Upgrade from Chromium 126.0.6478.40 to Chromium 126.0.6478.40 Upgrade from Chromium 126.0.6478.40 to Chromium 126.0.6478.56 Jun 11, 2024
@kjozwiak kjozwiak added OS/iOS Fixes related to iOS browser functionality QA/Test-All-Device-Types labels Jun 12, 2024
@kjozwiak
Copy link
Member

The above requires 1.67.113 or higher for 1.67.x verification 👍

@kjozwiak
Copy link
Member

kjozwiak commented Jun 12, 2024

Quick overview of the work remaining re: affected areas due to C126 on the following platforms:

Platforms that only require a spot check due to already completing full check of the affected areas mentioned via #37788 (comment):

Platforms that still need to check/verify the affected areas due to C126 changes as per #37788 (comment):

  • Android Tablet - Still requires a pass through the affected areas. CCing @hffvld @Uni-verse

@LaurenWags
Copy link
Member

Verified passed with

Brave | 1.67.113 Chromium: 126.0.6478.56 (Official Build) (x86_64)
-- | --
Revision | 2c6c9c73e7382e94dd9f7327dff55cb1fe56ff59
OS | macOS Version 13.6.7 (Build 22G720)
Screenshot 2024-06-12 at 11 29 36 AM

@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.67.113 Chromium: 126.0.6478.56 (Official Build) (64-bit)
-- | --
Revision | 2c6c9c73e7382e94dd9f7327dff55cb1fe56ff59
OS | Windows 11 Version 23H2 (Build 22631.3737)

image

@MadhaviSeelam
Copy link

Verification PASSED using

Brave	1.67.113 Chromium: 126.0.6478.56 (Official Build) (64-bit) 
Revision	2c6c9c73e7382e94dd9f7327dff55cb1fe56ff59
OS	Linux

image

@hffvld
Copy link
Contributor

hffvld commented Jun 12, 2024

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 14 AP31.240426.023.B4 release-keys
Brave build: 1.67.113
Chromium: 126.0.6478.56 (Official Build) (64-bit) 

1 2
1 2

@hffvld
Copy link
Contributor

hffvld commented Jun 13, 2024

Verified on Galaxy Tab S8 using version(s):

Device/OS: Galaxy Tab S8 / gts8wifixx-user 14 UP1A.231005.007 release-keys
Brave build: 1.67.113
Chromium: 126.0.6478.56 (Official Build) (64-bit) 

URL bar UI (make sure its look doesn't change)

ACTUAL RESULTS:

  • Verified that the URL search bar looks the same as before in the Standard and Private tab
  • Verified that Share, Copy & Edit buttons are available
  • Verified that search with QR code and Voice search are working

Standard tab

1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4

Private tab

1 2 3
1 2 3
1 2 3
1 2 3
Tab overview UI

ACTUAL RESULTS:

  • Verified that the Tab overview UI looks the same as before, for example, in build 1.63.165
  • Verified the same for the Standard and Private tab

Standard tab

1 2
1 2
1 2

Private tab

1 2
1 2
1 2
Brave news

ACTUAL RESULTS:

  • Verified that Brave News is working as expected
  • Verified that it's possible to add/remove news sources
  • Verified that the long tap on the news card is working

1 2 3 4
1 2 3 4
1 2 3 4
Brave Ads notifications

ACTUAL RESULTS:

  • Verified that ad notifications are shown as expected
  • Verified that all logs are shown as expected including View, Click, Land and Dismiss

1 2 3
1 2 3
1 2 3
Close all tabs - expected to have browser alive

ACTUAL RESULTS:

  • Verified that Brave stays opened when closing all tabs
  • Verified that Closing all tabs closes Brave is OFF by default

1 2 3
1 2 3
Icons of sites at rewards UI on Android

ACTUAL RESULTS:


1 2
1 2
Password manager - should allow to save and view passwords

ACTUAL RESULTS:

  • Verified that the Brave Password Manager offers to save a password
  • Verified that the saved password can be used to sign in on a website
  • Verified that saved password can be seen and editable if needed

1 2 3
1 2 3
1 2 3
1 2 3

@hffvld
Copy link
Contributor

hffvld commented Jun 17, 2024

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.5.1
Brave build: 1.67 (115)
BraveCore: 1.67.115 (126.0.6478.56)

1 2
1 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants