old favicons not being updated to v2 via brave://rewards after uprade - follow up to #37941

[kjozwiak]

Description

Due to #37941, we had a bug where favicons weren't being displayed in the rewards panels and brave://rewards due to loading from chrome://favicon rather than chrome://favicon2 as per #37941 (comment). However, the icons are still appearing broken via brave://rewards unless a user visits the affected websites and pulls/downloads the new favicons.

@hffvld also experienced the above on Android and provided screenshots which have also been added into the issue.

Steps to Reproduce

1. install 1.65.123 Chromium: 124.0.6367.91 and enable rewards
2. visit several websites and notice that there's broken favicons appearing under brave://rewards
3. update Brave to the latest version and revisit brave://rewards (you'll notice that the icons are still broken)

However, once you revisit the websites that are being listed under brave://rewards, the new favicons will be updated.

Actual result:

Desktop Example	Android Example

Expected result:

Brave should attempt to check to see if there's any broken favicons and update them automatically rather than the user needing to revisit the website to pull the new ones from chrome://favicon2

Reproduces how often:

100% reproducible when using the STR/Cases outlined above.

Desktop Brave version:

Reproduced on Win 11 x64 using 1.65.123 Chromium: 124.0.6367.91 --> Upgrade --> 1.65.126 Chromium: 124.0.6367.118

Android Device details:

• Install type (ARM, x86): ARM
• Device type (Phone, Tablet, Phablet): Phone
• Android version: Android 14

Version/Channel Information:

• Can you reproduce this issue with the current release? Yes
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? N/A
• Does the issue resolve itself when disabling Brave Rewards? Only occurs for users that have rewards enabled and before Favicons are not displaying in the rewards panel #37941
• Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

[hffvld]

I observed the same issue on Pixel 7 while testing Brave Nightly 1.67.70.

Device/OS: Pixel 7 / panther_beta-user 14 AP31.240322.023 release-keys
Brave build: 1.67.70 
Chromium: 125.0.6422.26 (Official Build) canary (64-bit) 

---

1	2	3