Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Chromium 126.0.6478.26 to Chromium 126.0.6478.40 #38848

Closed
emerick opened this issue Jun 5, 2024 · 5 comments · Fixed by brave/brave-core#24018
Closed

Upgrade from Chromium 126.0.6478.26 to Chromium 126.0.6478.40 #38848

emerick opened this issue Jun 5, 2024 · 5 comments · Fixed by brave/brave-core#24018
Assignees
@emerick @mkarolin
Labels
Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Android Fixes related to Android browser functionality OS/Desktop QA/No QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified release-notes/exclude
Milestone
1.67.x - Release

Comments

@emerick
Copy link
Contributor

emerick commented Jun 5, 2024

Minor Chromium bump

https://chromium.googlesource.com/chromium/src/+log/126.0.6478.26..126.0.6478.40?pretty=fuller&n=10000

QA tests

  • Check branding items
  • Check for version bump

Minor Chromium bump

  • No specific code changes in Brave (only line number changes in patches)
@emerick emerick added QA/Yes release-notes/include QA/Test-Plan-Specified OS/Android Fixes related to Android browser functionality Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Desktop labels Jun 5, 2024
This was referenced Jun 5, 2024
Merged
Merged
@kjozwiak
Copy link
Member

kjozwiak commented Jun 6, 2024 •
edited
Loading

Quick overview of the work remaining re: affected areas due to C126 on the following platforms:

Platforms that only require a spot check due to already completing full check of the affected areas mentioned via #37788 (comment):

Platforms that still need to check/verify the affected areas due to C126 changes as per #36346 (comment):

  • Android Tablet - Still requires a pass through the affected areas.

@kjozwiak kjozwiak mentioned this issue Jun 6, 2024
Closed
@GeetaSarvadnya
Copy link

Verification PASSED on

Brave | 1.67.108 Chromium: 126.0.6478.40 (Official Build) beta (64-bit)
-- | --
Revision | a286dc9f61f7d70fbf0157fcf3d924b00297d450
OS | Windows 10 Version 22H2 (Build 19045.4412)

image

@LaurenWags LaurenWags added QA/Test-All-Platforms QA/In-Progress Indicates that QA is currently in progress for that particular issue and removed QA/Test-All-Device-Types labels Jun 6, 2024
@LaurenWags
Copy link
Member

Verified with

Brave | 1.67.108 Chromium: 126.0.6478.40 (Official Build) beta (x86_64)
-- | --
Revision | a286dc9f61f7d70fbf0157fcf3d924b00297d450
OS | macOS Version 13.6.7 (Build 22G720)
Screenshot 2024-06-06 at 8 55 50 AM

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jun 6, 2024
@LaurenWags
Copy link
Member

Verified with

Brave	1.67.108 Chromium: 126.0.6478.40 (Official Build) beta (64-bit) 
Revision	a286dc9f61f7d70fbf0157fcf3d924b00297d450
OS	Linux
Screenshot 2024-06-06 at 9 35 54 AM

@LaurenWags LaurenWags mentioned this issue Jun 11, 2024
Closed
@kjozwiak
Copy link
Member

Labelled as release-notes/exclude & QA/No in favour of #38974 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emerick emerick

@mkarolin mkarolin

Labels
Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Android Fixes related to Android browser functionality OS/Desktop QA/No QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified release-notes/exclude
Projects
None yet
Milestone
1.67.x - Release
Development

Successfully merging a pull request may close this issue.

Upgrade from Chromium 126.0.6478.26 to Chromium 126.0.6478.40 brave/brave-core
6 participants
@kjozwiak @emerick @LaurenWags @GeetaSarvadnya @mkarolin @brave-builds