-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security] "Next" button label/text for pin required/passkey-pin input is unreadable #39072
Closed
5 of 6 tasks
Closed
5 of 6 tasks
Labels
Milestone
Comments
Next
button label/text for pin required/passkey-pin input is unreadable
#38905 is another example of an unreadable button in light mode. |
Working on this now. |
simonhong
added a commit
to brave/brave-core
that referenced
this issue
Jun 21, 2024
fix brave/brave-browser#39072 fix brave/brave-browser#38905 We should not allow customizing text color for prominent button style as we use our own bg color for it.
24 tasks
This was referenced Jun 22, 2024
The above requires |
Next
button label/text for pin required/passkey-pin input is unreadable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Description
Next
button label/text for pin required/passkey-pin input is unreadable inLight
modeSteps to reproduce
1.69.23
https://github.com
Log in
Use a passkey
optionActual result
The button text/label for the
Next
button isn't readable inLight
modeExpected result
The
Next
button's text should be readable, in bothDark
andLight
browser modesReproduces how often
Easily reproduced
Brave version (brave://version info)
Channel information
Reproducibility
Miscellaneous information
cc @rebron @simonhong @bsclifton @fmarier @kdenhartog @brave/qa-team
The text was updated successfully, but these errors were encountered: