Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy clean link should use an "aggressive" version of the debouncer #39618

Open
1 of 6 tasks
fmarier opened this issue Jul 8, 2024 · 2 comments
Open
1 of 6 tasks

Copy clean link should use an "aggressive" version of the debouncer #39618

fmarier opened this issue Jul 8, 2024 · 2 comments
Assignees
Labels
copy-clean-link OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/Yes release-notes/include

Comments

@fmarier
Copy link
Member

fmarier commented Jul 8, 2024

Description

https://goto.walmart.com/c/159047/565706/9383?&sharedid=cnet&partnerpropertyid=235399&u=https%3A%2F%2Fwww.walmart.com%2Fip%2FApple-Lightning-to-3-5-mm-Headphone-Jack-Adapter%2F54738078%3F&subId1=cn-bbdb4f53b6d64a02b50d53c6343ce6a2-dtp-oo should ideally be debounced to https://www.walmart.com/ip/Apple-Lightning-to-3-5-mm-Headphone-Jack-Adapter/54738078?&subId1=cn-bbdb4f53b6d64a02b50d53c6343ce6a2-dtp-oo when users select "copy clean link".

Steps to reproduce

  1. Right click on goto.walmart.com link above.
  2. Select Copy clean link.
  3. Paste into a text editor.

Actual result

https://goto.walmart.com/c/159047/565706/9383?&sharedid=cnet&partnerpropertyid=235399&u=https%3A%2F%2Fwww.walmart.com%2Fip%2FApple-Lightning-to-3-5-mm-Headphone-Jack-Adapter%2F54738078%3F&subId1=cn-bbdb4f53b6d64a02b50d53c6343ce6a2-dtp-oo

because goto.walmart.com and www.walmart.com are same-site with each other and we don't debounce same-site redirectors.

Expected result

https://www.walmart.com/ip/Apple-Lightning-to-3-5-mm-Headphone-Jack-Adapter/54738078?&subId1=cn-bbdb4f53b6d64a02b50d53c6343ce6a2-dtp-oo

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave	1.68.110 Chromium: 127.0.6533.26 (Official Build) beta (64-bit) 
Revision	83a08b66c8afbf78547e2acc7b3a7ebb962f359b
OS	Linux

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

@boocmp
Copy link

boocmp commented Jul 11, 2024

#25859
Here we've got goto.walmart.com and www.walmart.com and this check returns true, because it is the same domain.

Looks like it's by design :/

@fmarier
Copy link
Member Author

fmarier commented Jul 11, 2024

Ah, interesting I did not know about that rule. I've updated the wiki documentation.

I guess, we might want a more aggressive version of the debouncer for copy clean link. I will update the issue description and priority since this is not a bug, but rather a known limitation.

@fmarier fmarier added priority/P5 Not scheduled. Don't anticipate work on this any time soon. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Jul 11, 2024
@fmarier fmarier changed the title Copy clean link is not debouncing links Copy clean link should use an "aggressive" version of the debouncer Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
copy-clean-link OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/Yes release-notes/include
Projects
Status: On Deck
Development

No branches or pull requests

3 participants