Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verified sites need a different BAT logo #4043

Closed
mandar-brave opened this issue Apr 8, 2019 · 11 comments

Comments

@mandar-brave
Copy link
Collaborator

commented Apr 8, 2019

Verified BAT sites should show a different logo (original logo had a blue bar for verified sites) so user knows pre-logo click that site was verified.

cc @NejcZdovc

@mandar-brave mandar-brave added this to Untriaged Backlog in Rewards via automation Apr 8, 2019

@mandar-brave

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 8, 2019

@jenn-rhim can we pull the original design for this!

@NejcZdovc NejcZdovc moved this from Untriaged Backlog to P1 & P2 Backlog in Rewards Apr 9, 2019

@NejcZdovc NejcZdovc added this to Ryan in Rewards Team Apr 10, 2019

@mandar-brave

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 16, 2019

@rossmoody we need an icon for the change.
cc @ryanml

@NejcZdovc NejcZdovc added the blocked label Apr 17, 2019

@NejcZdovc

This comment has been minimized.

Copy link
Member

commented Apr 17, 2019

waiting for design and final decision on how it will work

@rossmoody

This comment has been minimized.

Copy link
Member

commented Apr 17, 2019

@davidtemkin Has some final fine tuning to do and then we should be good to go, I think.

@rossmoody

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

Rewards Verified Toolbar

@davidtemkin

This comment has been minimized.

Copy link
Collaborator

commented Apr 18, 2019

@rossmoody @ryanml still some discussion needed -- we are not yet final-final -- please hold implementation for a moment

@davidtemkin

This comment has been minimized.

Copy link
Collaborator

commented Apr 18, 2019

@rossmoody @ryanml -- OK, confirmed all with @bradleyrichter and we are good to go with the above

@NejcZdovc

This comment has been minimized.

Copy link
Member

commented Apr 19, 2019

so if I understand image correctly, if you have notification we don't show any indication for verified publisher?

@rossmoody

This comment has been minimized.

Copy link
Member

commented Apr 19, 2019

Yea, the notification would take priority until it's cleared.

@NejcZdovc

This comment has been minimized.

Copy link
Member

commented Apr 19, 2019

ok sounds good

@NejcZdovc NejcZdovc assigned NejcZdovc and unassigned ryanml Apr 19, 2019

@NejcZdovc NejcZdovc moved this from Ryan to Nejc in Rewards Team Apr 19, 2019

@NejcZdovc NejcZdovc added this to the 0.66.x - Nightly milestone Apr 19, 2019

NejcZdovc added a commit to brave/brave-core that referenced this issue Apr 19, 2019

@NejcZdovc NejcZdovc referenced this issue Apr 19, 2019

Merged

Adds different logo for verified publishers #2294

8 of 28 tasks complete

@NejcZdovc NejcZdovc added the QA/Yes label Apr 19, 2019

@NejcZdovc NejcZdovc moved this from P1 & P2 Backlog to In Progress in Rewards Apr 24, 2019

NejcZdovc added a commit to brave/brave-core that referenced this issue Apr 24, 2019

NejcZdovc added a commit to brave/brave-core that referenced this issue Apr 24, 2019

NejcZdovc added a commit to brave/brave-core that referenced this issue Apr 24, 2019

@NejcZdovc NejcZdovc removed the blocked label May 13, 2019

NejcZdovc added a commit to brave/brave-core that referenced this issue May 13, 2019

NejcZdovc added a commit to brave/brave-core that referenced this issue May 13, 2019

@NejcZdovc NejcZdovc moved this from In Progress to Pending review in Rewards May 14, 2019

NejcZdovc added a commit to brave/brave-core that referenced this issue May 14, 2019

petemill added a commit to brave/brave-core that referenced this issue May 14, 2019

Rewards automation moved this from Pending review to Completed May 15, 2019

Rewards Team automation moved this from Nejc to Closed May 15, 2019

@NejcZdovc NejcZdovc moved this from Completed to Waiting uplift in Rewards May 20, 2019

@NejcZdovc NejcZdovc moved this from Waiting uplift to Completed in Rewards May 22, 2019

snyderp added a commit to brave/brave-core that referenced this issue May 22, 2019

jdkuki added a commit to brave/brave-core that referenced this issue May 23, 2019

@btlechowski

This comment has been minimized.

Copy link
Collaborator

commented Jun 12, 2019

Verification passed on

Brave 0.66.87 Chromium: 75.0.3770.80 (Official Build) beta (64-bit)
Revision 9a9aa15057b6b2cc0909bdcf638c0b65ecd516f2-refs/branch-heads/3770@{#948}
OS Windows 7 Service Pack 1 (Build 7601.24465)

Verified test plan from brave/brave-core#2294
Logged #4817

Verification passed on

Brave 0.66.87 Chromium: 75.0.3770.80 (Official Build) beta (64-bit)
Revision 9a9aa15057b6b2cc0909bdcf638c0b65ecd516f2-refs/branch-heads/3770@{#948}
OS Linux

Verification PASSED* on macOS 10.14.5 x64 using the following build:

Brave 0.66.88 Chromium: 75.0.3770.87 (Official Build) beta(64-bit)
Revision 9dc58a2353af60ab2b48bab98a25bc43ed59085d-refs/branch-heads/3770@{#982}
OS Mac OS X
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.