Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verified sites need a different BAT logo #4043

Closed
mandar-brave opened this issue Apr 8, 2019 · 11 comments · Fixed by brave/brave-core#2294
Closed

Verified sites need a different BAT logo #4043

mandar-brave opened this issue Apr 8, 2019 · 11 comments · Fixed by brave/brave-core#2294
Assignees
@NejcZdovc
Labels
feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
Rewards Team
Milestone
0.66.x - Release ...

Comments

@mandar-brave
Copy link

Verified BAT sites should show a different logo (original logo had a blue bar for verified sites) so user knows pre-logo click that site was verified.

cc @NejcZdovc
@mandar-brave mandar-brave added feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. labels Apr 8, 2019
@mandar-brave mandar-brave added this to Untriaged Backlog in Rewards via automation Apr 8, 2019
@mandar-brave
Copy link
Author

@jenn-rhim can we pull the original design for this!

@NejcZdovc NejcZdovc moved this from Untriaged Backlog to P1 & P2 Backlog in Rewards Apr 9, 2019
@NejcZdovc NejcZdovc added this to Ryan in Rewards Team Apr 10, 2019
@mandar-brave
Copy link
Author

@rossmoody we need an icon for the change.
cc @ryanml

@NejcZdovc
Copy link
Contributor

waiting for design and final decision on how it will work

@rossmoody
Copy link
Contributor

@davidtemkin Has some final fine tuning to do and then we should be good to go, I think.

@rossmoody rossmoody mentioned this issue Apr 18, 2019
Closed
@rossmoody
Copy link
Contributor

Rewards Verified Toolbar

@davidtemkin
Copy link

@rossmoody @ryanml still some discussion needed -- we are not yet final-final -- please hold implementation for a moment

@davidtemkin
Copy link

@rossmoody @ryanml -- OK, confirmed all with @bradleyrichter and we are good to go with the above

@NejcZdovc
Copy link
Contributor

so if I understand image correctly, if you have notification we don't show any indication for verified publisher?

@rossmoody
Copy link
Contributor

Yea, the notification would take priority until it's cleared.

@NejcZdovc
Copy link
Contributor

ok sounds good

@NejcZdovc NejcZdovc assigned NejcZdovc and unassigned ryanml Apr 19, 2019
@NejcZdovc NejcZdovc moved this from Ryan to Nejc in Rewards Team Apr 19, 2019
@rossmoody rossmoody mentioned this issue Apr 19, 2019
Merged
@NejcZdovc NejcZdovc added this to the 0.66.x - Nightly milestone Apr 19, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Apr 19, 2019
@NejcZdovc
Adds different logo for verified publishers
a0909a6 
Resolves brave/brave-browser#4043
@NejcZdovc NejcZdovc mentioned this issue Apr 19, 2019
Merged
28 tasks
@NejcZdovc NejcZdovc moved this from P1 & P2 Backlog to In Progress in Rewards Apr 24, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Apr 24, 2019
@NejcZdovc
Adds different logo for verified publishers
25df536 
Resolves brave/brave-browser#4043
NejcZdovc added a commit to brave/brave-core that referenced this issue Apr 24, 2019
@NejcZdovc
Adds different logo for verified publishers
1136922 
Resolves brave/brave-browser#4043
NejcZdovc added a commit to brave/brave-core that referenced this issue Apr 24, 2019
@NejcZdovc
Adds different logo for verified publishers
3eed577 
Resolves brave/brave-browser#4043
@NejcZdovc NejcZdovc removed the blocked label May 13, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue May 13, 2019
@NejcZdovc
Adds different logo for verified publishers
b095f86 
Resolves brave/brave-browser#4043
NejcZdovc added a commit to brave/brave-core that referenced this issue May 13, 2019
@NejcZdovc
Adds different logo for verified publishers
d3f57cf 
Resolves brave/brave-browser#4043
@NejcZdovc NejcZdovc moved this from In Progress to Pending review in Rewards May 14, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue May 14, 2019
@NejcZdovc
Adds different logo for verified publishers
9290120 
Resolves brave/brave-browser#4043
petemill pushed a commit to brave/brave-core that referenced this issue May 14, 2019
@NejcZdovc @petemill
Adds different logo for verified publishers
0bfaec8 
Resolves brave/brave-browser#4043
Rewards automation moved this from Pending review to Completed May 15, 2019
Rewards Team automation moved this from Nejc to Closed May 15, 2019
@NejcZdovc NejcZdovc moved this from Completed to Waiting uplift in Rewards May 20, 2019
@NejcZdovc NejcZdovc moved this from Waiting uplift to Completed in Rewards May 22, 2019
pes10k pushed a commit to brave/brave-core that referenced this issue May 22, 2019
@NejcZdovc @pes10k
Adds different logo for verified publishers
47220cc 
Resolves brave/brave-browser#4043
jdkuki pushed a commit to brave/brave-core that referenced this issue May 23, 2019
@NejcZdovc @jdkuki
Adds different logo for verified publishers
fb210e6 
Resolves brave/brave-browser#4043
This was referenced Jun 11, 2019
Closed
Closed
Closed
@btlechowski btlechowski mentioned this issue Jun 12, 2019
Closed
@btlechowski
Copy link
Collaborator

btlechowski commented Jun 12, 2019 •
edited by kjozwiak

Verification passed on

Brave 0.66.87 Chromium: 75.0.3770.80 (Official Build) beta (64-bit)
Revision 9a9aa15057b6b2cc0909bdcf638c0b65ecd516f2-refs/branch-heads/3770@{#948}
OS Windows 7 Service Pack 1 (Build 7601.24465)

Verified test plan from brave/brave-core#2294
Logged #4817

Verification passed on

Brave 0.66.87 Chromium: 75.0.3770.80 (Official Build) beta (64-bit)
Revision 9a9aa15057b6b2cc0909bdcf638c0b65ecd516f2-refs/branch-heads/3770@{#948}
OS Linux

Verification PASSED* on macOS 10.14.5 x64 using the following build:

Brave 0.66.88 Chromium: 75.0.3770.87 (Official Build) beta(64-bit)
Revision 9dc58a2353af60ab2b48bab98a25bc43ed59085d-refs/branch-heads/3770@{#982}
OS Mac OS X

@LaurenWags LaurenWags mentioned this issue Jul 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
No open projects
Rewards Team
Closed
Milestone
0.66.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Adds different logo for verified publishers brave/brave-core
8 participants
@kjozwiak @davidtemkin @ryanml @NejcZdovc @rossmoody @btlechowski @mandar-brave @GeetaSarvadnya