Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SimpleURLLoader instead of URLFetcher #4164

Closed
SergeyZhukovsky opened this issue Apr 18, 2019 · 2 comments
Closed

Use SimpleURLLoader instead of URLFetcher #4164

SergeyZhukovsky opened this issue Apr 18, 2019 · 2 comments
Labels
closed/duplicate Issue has already been reported closed/invalid feature/rewards

Comments

@SergeyZhukovsky
Copy link
Member

Description

URLFetcher is going to be deprecated. We use it in bat_native_ads and bat_native_ledger. We should use SimpleURLLoader instead

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:
@NejcZdovc
Copy link
Contributor

@SergeyZhukovsky is this dupe of #3501?

@NejcZdovc
Copy link
Contributor

closing as dupe of #3501

@NejcZdovc NejcZdovc mentioned this issue May 1, 2019
Closed
@NejcZdovc NejcZdovc added the closed/duplicate Issue has already been reported label May 1, 2019
@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone May 1, 2019
@rebron rebron removed this from the Dupe / Invalid / Not actionable milestone May 7, 2019
@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Jun 3, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed/duplicate Issue has already been reported closed/invalid feature/rewards
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bbondy @rebron @NejcZdovc @SergeyZhukovsky