Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change cursor to hand only when shields has a blocked item #507

Closed
srirambv opened this issue Jul 8, 2018 · 2 comments · Fixed by brave/brave-extension#78
Closed

Change cursor to hand only when shields has a blocked item #507

srirambv opened this issue Jul 8, 2018 · 2 comments · Fixed by brave/brave-extension#78
Labels
browser-laptop-parity closed/invalid feature/shields The overall Shields feature in Brave. priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/No QA/Test-Plan-Specified release-notes/exclude

Comments

@srirambv
Copy link
Contributor

srirambv commented Jul 8, 2018

Description

Change cursor to hand only when shields has a blocked item

Steps to Reproduce

  1. Open any site, ensure shields has some blocked item
  2. Hover over the blocked item, cursor changes to hand
  3. Hover over 0 blocked items, cursor changes to hand
  4. Open a new tab, ensure shields is disabled, hover over the disabled blocked items, cursor changes to hand

Actual result:

disable shields

Expected result:

Should only change to hand when there is a blocked item in shields similar to browser-laptop

Reproduces how often:

100%

Brave version (about:brave info)

Packaged and release build

Reproducible on current release:

N/A

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information
@srirambv srirambv added feature/shields The overall Shields feature in Brave. priority/P5 Not scheduled. Don't anticipate work on this any time soon. browser-laptop-parity labels Jul 8, 2018
@srirambv srirambv added this to the Backlog milestone Jul 8, 2018
@cezaraugusto cezaraugusto mentioned this issue Oct 2, 2018
Closed
@cezaraugusto cezaraugusto mentioned this issue Oct 11, 2018
Closed
@cezaraugusto cezaraugusto mentioned this issue Oct 30, 2018
Merged
@bsclifton bsclifton modified the milestones: 1.x Backlog, 0.56.x - Beta Oct 30, 2018
@bsclifton bsclifton mentioned this issue Oct 30, 2018
Merged
18 tasks
@srirambv srirambv mentioned this issue Nov 1, 2018
Closed
@srirambv
Copy link
Contributor Author

srirambv commented Nov 1, 2018

Issue isn't fixed with new shields implementation either. Created new issue #1957
508

@srirambv
Copy link
Contributor Author

srirambv commented Nov 2, 2018

Marking as QA/No as the design is changed and #1957 supersedes this issue both on design and functionality on new tab

@srirambv srirambv added QA/No and removed QA/Yes labels Nov 2, 2018
@rebron rebron modified the milestones: 0.56.x - Release, Dupe / Invalid / Not actionable Nov 12, 2018
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
browser-laptop-parity closed/invalid feature/shields The overall Shields feature in Brave. priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/No QA/Test-Plan-Specified release-notes/exclude
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

new Shields brave/brave-extension
Shields v2 GA version brave/brave-extension
6 participants
@bbondy @kjozwiak @cezaraugusto @bsclifton @rebron @srirambv