Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer to install Google Translate extension in translate bubble #5561

Closed
yrliou opened this issue Aug 6, 2019 · 14 comments · Fixed by brave/brave-core#3103
Closed

Offer to install Google Translate extension in translate bubble #5561

yrliou opened this issue Aug 6, 2019 · 14 comments · Fixed by brave/brave-core#3103

Comments

@yrliou
Copy link
Member

yrliou commented Aug 6, 2019

Repurpose translate UI to offer Google Translate extension installation as a translate solution that could work on all desktop channels.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 25, 2019

Verification passed on

Brave 0.69.115 Chromium: 76.0.3809.100 (Official Build) beta (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Windows 10 OS Version 1803 (Build 17134.523)

Verification passed on

Brave 0.69.116 Chromium: 76.0.3809.100 (Official Build) beta (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Ubuntu 18.04 LTS

Verified passed with

Brave 0.69.116 Chromium: 76.0.3809.100 (Official Build) beta (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Mac OS X

@GeetaSarvadnya
Copy link

@yrliou Google translate option is not available in the context menu in Windows. Is this expected? whereas I could see Google translate option in macOS brave/brave-core#3103 (comment).

image

@yrliou
Copy link
Member Author

yrliou commented Aug 26, 2019

@GeetaSarvadnya Could you try the extension in Chrome and see if it shows up in Chrome's context menu on Windows? Thanks.

@GeetaSarvadnya
Copy link

@yrliou Nope, in chrome Google translate option is not available in the context menu in Windows.

Thanks!

@yrliou
Copy link
Member Author

yrliou commented Aug 27, 2019

@GeetaSarvadnya Thanks for checking, then it is the expected behavior, since this issue doesn't cover the scope of google translation extension itself and that context menu item was added by them, not us.

@crogonint
Copy link

Here's your missing translate service. Upvote this:
https://yahoo.uservoice.com/forums/341361-yahoo-homepage/suggestions/40044514-bring-back-babelfish

@dtantono
Copy link

@crogonint is babelfish also open-source similar like aspell?

@crogonint
Copy link

crogonint commented Jan 27, 2021 via email

@NayamAmarshe
Copy link

I think it's better to use this extension than the one Brave currently suggests.
This extension has context menu entries and has better customizability than Google's, it's also better for privacy.
https://github.com/FilipePS/Traduzir-paginas-web

@dtantono
Copy link

@NayamAmarshe I know this project and the developer said that the porting process from the firefox to chrome is underway. So, we need to be patient.

@NayamAmarshe
Copy link

NayamAmarshe commented Mar 27, 2021

@NayamAmarshe I know this project and the developer said that the porting process from the firefox to chrome is underway. So, we need to be patient.

I'm actually using it right now on Brave and it works just fine.

@dtantono
Copy link

dtantono commented Mar 27, 2021

@NayamAmarshe so you use Firefox xpi file on brave. Is that so?

@NayamAmarshe
Copy link

@NayamAmarshe so you use Firefox xpi file on brave. Is that so?

Of course not. The extension is easily available for install in Chromium browsers. You just need to clone the git, rename chrome_manifest to just manifest and install it as an unpacked extension in Brave.
The author has already provided the steps to install the extension in Chromium browsers: https://github.com/FilipePS/Traduzir-paginas-web#to-install-the-extension-on-a-browser-other-than-firefox-follow-these-steps

@dtantono
Copy link

The developer (FilipePS/Traduzir-paginas-web#55) wants to port the extension to the chrome store natively and I think it is a good idea because the update process will become automated from the chrome store rather than recompile the code manually which is quite time-consuming. Besides, I chatted with brave tech support that they seriously considered the translation feature on the brave browser and there is no ETA yet
So, I hope this feature can be realised someday because personally, I don't really like to depend on the extension too much for memory consumption reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment