Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Japan to ads #5656

Closed
tmancey opened this issue Aug 14, 2019 · 3 comments · Fixed by brave/brave-core#3172
Closed

Add support for Japan to ads #5656

tmancey opened this issue Aug 14, 2019 · 3 comments · Fixed by brave/brave-core#3172
Assignees
@tmancey
Labels
feature/ads priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
0.70.x - Release

Comments

@tmancey
Copy link
Contributor

tmancey commented Aug 14, 2019

Add support for Japan to ads
@tmancey tmancey added priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes feature/ads labels Aug 14, 2019
@tmancey tmancey added this to the 0.71.x - Nightly milestone Aug 14, 2019
@tmancey tmancey self-assigned this Aug 14, 2019
@tmancey tmancey mentioned this issue Aug 14, 2019
Merged
32 tasks
tmancey added a commit to brave/brave-core that referenced this issue Aug 14, 2019
@tmancey
Add support for Japan to ads
23c7a44 
Fixes brave/brave-browser#5656
@LaurenWags
Copy link
Member

QA/Blocked until there are ad campaigns available for this region.

@LaurenWags LaurenWags mentioned this issue Oct 11, 2019
Closed
@LaurenWags
Copy link
Member

LaurenWags commented Oct 11, 2019 •
edited by btlechowski
Loading

Verified passed with

Brave 0.70.113 Chromium: 77.0.3865.90 (Official Build) beta （64 ビット）
変更履歴 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS バージョン10.13.6（ビルド17G5019）
  • Verified enabling Rewards on fresh install for Japan locale enabled Ads

Screen Shot 2019-10-11 at 17 57 49

  • Verified upgrading from 0.69.135 with Rewards on and was not prompted via BAT logo notification to alert user that Ads have arrived. Ads were on by default. Logged ads enabled by default for Japan on upgrade #6449
  • Verified Japan ad catalog was downloaded
  • Verified untargeted Ad notifications were served
  • Verified view, click, dismiss, landed in confirmations.json.
  • Verified was able to redeem tokens with the server.

Verification passed on

Brave 0.70.113 Chromium: 77.0.3865.90 (Official Build) beta （64 ビット）
変更履歴 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified enabling Rewards on fresh install for Japan locale enabled Ads

image

  • Verified upgrading from 0.69.135 with Rewards on and was not prompted via BAT logo notification to alert the user that Ads have arrived. Ads were on by default. Encountered ads enabled by default for Japan on upgrade #6449
  • Verified Japan ad catalog was downloaded
  • Verified untargeted Ad notifications were served

image

  • Verified view, click, dismiss, landed in confirmations.json.
  • Verified was able to redeem tokens with the server.
    image

Verification passed on

Brave 0.70.115 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Ubuntu 18.04 LTS
  • Verified enabling Rewards on fresh install for Japan locale enabled Ads

image

  • Verified upgrading from 0.69.135 with Rewards on and was not prompted via BAT logo notification to alert user that Ads have arrived. Ads were on by default. Encountered ads enabled by default for Japan on upgrade #6449
  • Verified Japan ad catalog was downloaded
  • Verified untargeted Ad notifications were served
  • Verified view, click, dismiss, landed in confirmations.json.
  • Verified was able to redeem tokens with the server.

@GeetaSarvadnya GeetaSarvadnya mentioned this issue Oct 19, 2019
Closed
@kjozwiak kjozwiak mentioned this issue Oct 23, 2019
Closed
@LaurenWags
Copy link
Member

Removing from release notes as this is covered under #5655

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
feature/ads priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.70.x - Release
Development

Successfully merging a pull request may close this issue.

Add support for Japan to ads brave/brave-core
4 participants
@tmancey @LaurenWags @btlechowski @GeetaSarvadnya