Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave Rewards widget for New Tab Page #6370

Closed
rebron opened this issue Oct 9, 2019 · 3 comments · Fixed by brave/brave-core#3624

Comments

@rebron
Copy link
Collaborator

@rebron rebron commented Oct 9, 2019

Description

Add Brave Rewards widget on New Tabs page to add further usage and engagement of Brave Rewards. Users will be able to Turn on Brave Rewards and Ads if haven't already. Widget will also display current wallet amount as well as pending tips and contributions if users are opted into Brave Reward.

Design

Screen Shot 2019-10-08 at 8 10 31 PM

Additional screens to be added.

Test Plan:

  1. Build Browser from PR, navigate to brave://newtab
  2. Confirm that Rewards widget is initially present and can be toggled on and off via the widget menu
  3. Turn on Rewards via the widget
  4. Confirm that initial tip/ads amounts are shown in the widget after Rewards is turned on
  5. Confirm that Ads/Rewards can be toggled two ways between brave://newtab <-> brave://rewards
  6. Resore your Rewards wallet via brave://rewards with a wallet that is set to receive a grant
  7. Navigate to brave://newtab, wait and confirm that grant notification is shown
  8. Dismiss notification, reload page and ensure it does not show again
  9. With claimed grant funds, tip a fully connected and verified publisher
  10. Confirm on brave://newtab after some time that monthly tip amount increments appropriately
  11. Browse and serve yourself a Brave Ad
  12. Confirm on brave://newtab after some time that ads estimated earnings increments correctly
@NejcZdovc NejcZdovc added this to New Issues in Rewards via automation Oct 9, 2019
@NejcZdovc NejcZdovc moved this from New Issues to In Progress in Rewards Oct 9, 2019
@user1313

This comment has been minimized.

Copy link

@user1313 user1313 commented Oct 9, 2019

nice idea, but please keep it off for those of us who do not opt in!

@rebron rebron added this to In progress in New Tab page Oct 9, 2019
@rebron

This comment has been minimized.

Copy link
Collaborator Author

@rebron rebron commented Oct 10, 2019

@user1313 There will be a way to hide the Brave Rewards widget, similar to all the other New Tab page elements as you can do now in the current release 69.132.

@ryanml ryanml mentioned this issue Oct 15, 2019
7 of 32 tasks complete
ryanml added a commit to brave/brave-core that referenced this issue Oct 15, 2019
Notifications work

converted amounts

widget enable test, localizations

2
ryanml added a commit to brave/brave-core that referenced this issue Oct 15, 2019
@NejcZdovc NejcZdovc moved this from In Progress to Review/QA in Rewards Oct 15, 2019
@NejcZdovc NejcZdovc added 1.0 and removed 1.0-suggestion labels Oct 15, 2019
@NejcZdovc NejcZdovc added this to the 0.71.x - Beta milestone Oct 21, 2019
ryanml added a commit to brave/brave-core that referenced this issue Oct 23, 2019
ryanml added a commit to brave/brave-core that referenced this issue Oct 23, 2019
ryanml added a commit to brave/brave-core that referenced this issue Oct 23, 2019
ryanml added a commit to brave/brave-core that referenced this issue Oct 24, 2019
ryanml added a commit to brave/brave-core that referenced this issue Oct 24, 2019
ryanml added a commit to brave/brave-core that referenced this issue Oct 24, 2019
ryanml added a commit to brave/brave-core that referenced this issue Oct 24, 2019
ryanml added a commit to brave/brave-core that referenced this issue Oct 25, 2019
ryanml added a commit to brave/brave-core that referenced this issue Oct 29, 2019
Checking onlyAnonWallet for currency display

Fixes brave/brave-browser#6598
ryanml added a commit to brave/brave-core that referenced this issue Oct 29, 2019
Checking onlyAnonWallet for currency display

Fixes brave/brave-browser#6598
ryanml added a commit to brave/brave-core that referenced this issue Oct 29, 2019
Checking onlyAnonWallet for currency display

Fixes brave/brave-browser#6598
ryanml added a commit to brave/brave-core that referenced this issue Oct 29, 2019
Checking onlyAnonWallet for currency display

Fixes brave/brave-browser#6598
ryanml added a commit to brave/brave-core that referenced this issue Oct 29, 2019
Checking onlyAnonWallet for currency display

Fixes brave/brave-browser#6598
ryanml added a commit to brave/brave-core that referenced this issue Oct 29, 2019
Checking onlyAnonWallet for currency display

Fixes brave/brave-browser#6598
ryanml added a commit to brave/brave-core that referenced this issue Oct 29, 2019
Checking onlyAnonWallet for currency display

Fixes brave/brave-browser#6598
ryanml added a commit to brave/brave-core that referenced this issue Oct 29, 2019
Checking onlyAnonWallet for currency display

Fixes brave/brave-browser#6598
ryanml added a commit to brave/brave-core that referenced this issue Oct 29, 2019
Checking onlyAnonWallet for currency display

Fixes brave/brave-browser#6598
ryanml added a commit to brave/brave-core that referenced this issue Oct 29, 2019
ryanml added a commit to brave/brave-core that referenced this issue Oct 30, 2019
ryanml added a commit to brave/brave-core that referenced this issue Oct 30, 2019
ryanml added a commit to brave/brave-core that referenced this issue Oct 31, 2019
ryanml added a commit to brave/brave-core that referenced this issue Oct 31, 2019
Rewards automation moved this from Review/QA to Done Oct 31, 2019
@ryanml ryanml moved this from Done to Waiting uplift in Rewards Nov 1, 2019
@GeetaSarvadnya

This comment has been minimized.

Copy link
Collaborator

@GeetaSarvadnya GeetaSarvadnya commented Nov 4, 2019

Verification passed on

Brave 0.71.111 Chromium: 78.0.3904.87 (Official Build) (64-bit)
Revision 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified the test plan mentioned in the description
  • Logged #6749
  • Encountered #6740, #6754, #6755, #6685 (comment) and #6270 (comment)
  • Installed 0.68.142 added verified and non-verified pubs into a-c table, sent one time and monthly tips to verified pubs, performed auto contribution and upgraded the profile to 0.71.111 and verified that the rewards data (except auto contribution data #6740) is displayed in Rewards widget in an NTP
  • Installed 0.70.122 viewed an Ad and upgrade to 0.71.111, viewed ads stats displayed correctly in the Rewards widget in NTP
  • Installed 0.64.77 view an ad and upgrade to 0.71.111, viewed ad stats displayed correctly in the Rewards widget in NTP, view an ad in 0.71.111 and verify ads stats updated properly in rewards widget in NTP
  • Installed 0.70.111 and add few verified sites to auto contribution table and turn off A-C switch, send a monthly tip to a verified pub and wait for the a-c time interval to complete. After the auto contribution time interval, rewards data is updated properly in rewards widget
  • Installed 0.62.51, enable rewards and upgrade to 0.71.111- Ads are off by default, Ads enable alert is shown on BAT log and Turn on brave ads option is displayed in Rewards widget, click on Turn on brave ads, enables ads in Ads panel and switch state turned to ON state in ads panel, view an ad updated the rewards widget ads stats properly.
  • Verified failed confirmations in 0.71.111, estimated pending rewards and ads count is displayed as zero in ads panel (the only history is shown) and verified that the rewards widget is also showing ads stats as zero.

image

  • Verified retries confirmations in 0.70.111 and ensured retry happened after sometime, the estimated pending rewards is displayed in ads panel and same has reflected in rewards widget in NTP
    image

Verified passed with

Brave 0.71.112 Chromium: 78.0.3904.87 (Official Build) beta (64-bit)
Revision 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified test plan from description
  • Encountered #6740, #6754, #6755, #6759, #6741, #6677
  • Verified the following with a clean profile on 0.71.x:
    • widget is able to be toggled off/on
    • viewing ads updates the widget
    • one time tip updates the widget (connected and verified pubs)
    • AC does not update the widget (known, logged issue referenced above)
    • recurring monthly tips update the widget (connected and verified pubs)
    • widget still correctly reflects estimated pending BAT after ad tokens cashed in with the server
    • restoring a wallet with cashed in ad tokens correctly reflects estimated pending BAT on the widget (it matches Ads panel in brave://rewards)
    • viewing an ad after restoring a wallet with tokens updates the widget appropriately
    • claiming an Ad grant and UGP grant from widget does not open panel as expected for captcha (known, logged issue referenced above)
  • Verified the following with an upgraded profile (from 0.70.122)
    • widget is able to be toggled off/on
    • widget is accurate on upgrade (except for AC, known logged issue referenced above)
    • viewing ads updates the widget
    • tipping updates the widget (connected and verified pubs)
  • Using a connected (not KYC'd wallet)
    • Verified on a clean profile when using a connected wallet, one time and recurring tips update the widget. Ads views update the widget.
    • Verified on an upgraded profile when using a connected wallet, the widget is accurate on upgrade. One time and recurring tips update the widget. Ads views update the widget.
  • Using a verified, KYC'd wallet
    • Verified on a clean profile when using a verified wallet, one time and recurring tips update the widget. Ads views update the widget.
    • Verified on an upgraded profile when using a verified wallet, the widget is accurate on upgrade. One time and recurring tips update the widget. Ads views update the widget.
  • Verified widget states as listed in the spec:
    when BR has never been enabled:

Screen Shot 2019-11-06 at 4 22 06 PM

while enabling BR from the widget:

Enabling BR

after BR is enabled (no ads views, no tips yet):
Screen Shot 2019-11-06 at 4 24 02 PM
after ads views and tips:
Screen Shot 2019-11-06 at 4 21 42 PM
When ads are off and BR is on:
Screen Shot 2019-11-06 at 4 24 38 PM
when BR was on but toggled off:
Screen Shot 2019-11-06 at 4 25 07 PM
Upgrading from 0.62.51 (Ads not available) to 0.71.112 (Ads now available) - widget reflects that Ads are not on:
Screen Shot 2019-11-06 at 4 30 03 PM
Restoring a wallet where Ad tokens were cashed in:
Screen Shot 2019-11-06 at 4 39 33 PM
Claiming the waiting ad grant on above wallet, and seeing that widget reflects the correct Ad earnings:
Screen Shot 2019-11-06 at 4 39 52 PM
Screen Shot 2019-11-06 at 5 00 34 PM

  • Verified the test plan mentioned in the description
  • Installed 0.68.142 added verified and non-verified pubs into a-c table, sent one time and monthly tips to verified pubs, performed auto contribution and upgraded the profile to 0.71.111 and verified that the rewards data (except auto contribution data #6740) is displayed in Rewards widget in an NTP
  • Installed 0.70.122 viewed an Ad and upgrade to 0.71.111, viewed ads stats displayed correctly in the Rewards widget in NTP
  • Installed 0.64.77 view an ad and upgrade to 0.71.111, viewed ad stats displayed correctly in the Rewards widget in NTP, view an ad in 0.71.111 and verify ads stats updated properly in rewards widget in NTP
  • Installed 0.70.111 and add few verified sites to auto contribution table and turn off A-C switch, send a monthly tip to a verified pub and wait for the a-c time interval to complete. After the auto contribution time interval, rewards data is updated properly in rewards widget
  • Installed 0.62.51, enable rewards and upgrade to 0.71.111- Ads are off by default, Ads enable alert is shown on BAT log and Turn on brave ads option is displayed in Rewards widget, click on Turn on brave ads, enables ads in Ads panel and switch state turned to ON state in ads panel, view an ad updated the rewards widget ads stats properly.
  • Verified failed confirmations in 0.71.111, estimated pending rewards and ads count is displayed as zero in ads panel (the only history is shown) and verified that the rewards widget is also showing ads stats as zero.

image
image
image
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.