Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Rewards Widget for New Tab Page (0.72) #3859

Merged
merged 3 commits into from
Nov 4, 2019
Merged

Adding Rewards Widget for New Tab Page (0.72) #3859

merged 3 commits into from
Nov 4, 2019

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Nov 1, 2019 •
edited by bsclifton
Loading

@ryanml ryanml added this to the 0.72.x - Dev milestone Nov 1, 2019
@ryanml ryanml requested a review from a team November 1, 2019 21:07
@ryanml ryanml self-assigned this Nov 1, 2019
ryanml and others added 2 commits November 2, 2019 15:27
@ryanml
Merge pull request #3624 from brave/rewards-widget
d9564b8 
Adding Rewards Widget for New Tab Page
@bsclifton @ryanml
Merge pull request #3860 from brave/ntp-ads-fix
fd10752 
Fixing ads estimated earnings not updating on NTP widget
@bsclifton @ryanml
Merge pull request #3863 from brave/ntp-style-tweaks
8b83db3 
Rewards NTP Widget Style Updates
@kjozwiak
Copy link
Member

kjozwiak commented Nov 4, 2019

Restarting on macOS due to the following failure as per https://ci.brave.com/job/brave-browser-build-pr/job/ntp-widget-uplift-72/4/execution/node/711/log/:

17:32:25  [253/260] CXX obj/brave/test/brave_browser_tests/brave_shields_apitest.o
17:32:25  [254/260] CXX obj/brave/test/brave_browser_tests/brave_autocomplete_provider_client_browsertest.o
17:32:30  [255/260] CXX obj/brave/test/brave_browser_tests/rewards_service_browsertest.o
17:34:06  Sending interrupt signal to process
17:34:08  ninja: error: remove(brave_browser_tests.dSYM): Directory not empty
17:34:08  ninja: build stopped: interrupted by user.
17:34:08  ninja: error: remove(brave_browser_tests.dSYM): Directory not empty
17:34:09  script returned exit code 143

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Nov 4, 2019
@bsclifton
Copy link
Member

Failure was due to timeout; we'll want to expedite pulling in brave/brave-browser#6725 (which increases the timeout for test running)

rebron
rebron approved these changes Nov 4, 2019
View reviewed changes
Copy link
Collaborator

@rebron rebron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@bsclifton bsclifton merged commit ff41ddc into 0.72.x Nov 4, 2019
@bsclifton bsclifton deleted the ntp-widget-uplift-72 branch November 4, 2019 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebron rebron rebron approved these changes

Assignees

@ryanml ryanml

Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS feature/rewards
Projects
None yet
Milestone
1.1.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@ryanml @kjozwiak @bsclifton @rebron