restore tab context menu items

[rebron]

https://bugs.chromium.org/p/chromium/issues/detail?id=515930

Description

Chromium 78 removed items from the tab context menu. We should restore those menu items back.

Actual result:

Expected result:

Brave version (brave://version info)

Introduced in 70.x with Chromium 78 update.
Version 0.70.117 Chromium: 78.0.3904.50

[rebron]

cc: @petemill

[rebron]

cc: @simonhong can you take a look?

[fmarier]

It's still available, but only with right-clicking on the tab bar, right of the "new tab" button (plus sign):

[petemill]

Closing groups of tabs can now be done with multi-selecting tabs via ctrl / cmd, which allows for more selective options than simply "other" tabs.

Re-opening tabs can now be done with the 'History' menu, which provides more than just the most-recently-closed tab. Keyboard shortcut is also unaffected.

Not saying we shouldn't restore, just that there are new ways which are more powerful UX to begin to instruct users about.

[3dfoster]

Closing groups of tabs can now be done with multi-selecting tabs via ctrl / cmd, which allows for more selective options than simply "other" tabs.

Re-opening tabs can now be done with the 'History' menu, which provides more than just the most-recently-closed tab. Keyboard shortcut is also unaffected.

Not saying we shouldn't restore, just that there are new ways which are more powerful UX to begin to instruct users about.

There seem to be a lot of people on the internet, myself included, wanting the previous items in the context menu to be restored.

[rebron]

@fasterthan I'm in that group. This one is already in progress.

[bsclifton]

Reverted with brave/brave-core#3874

[simonhong]

@rebron @bsclifton, chromium re-added Close Other tabs menu to c79.
I think most users concerned that menu and chrome team decided to re-add it.
Is it ok to wait c79?
Or adding in advance to master?
Also, do we want all other items such as bookmark all tabs and reopen closed tab/window?

I pushed PR(brave/brave-core#3875) but it should be modified according to our decision.

[LaurenWags]

Marking as QA/Blocked until comment from #6513 (comment) is addressed.

Also, this issue is marked as 1.2.x but PR is in 1.3.x - should milestone for this issue be moved @rebron ?

[3dfoster]

@rebron @bsclifton, chromium re-added Close Other tabs menu to c79.
I think most users concerned that menu and chrome team decided to re-add it.
Is it ok to wait c79?
Or adding in advance to master?
Also, do we want all other items such as bookmark all tabs and reopen closed tab/window?

I pushed PR(brave/brave-core#3875) but it should be modified according to our decision.

Is this the best place for a user to provide feedback? If so, I'd prefer "reopen closed tab" to return to the menu :)

[bsclifton]

@fasterthan it's coming back! 😄 We recently fixed with brave/brave-core#3875 and it'll be working its way through the channels

edit: already live in Nightly!

[rebron]

For #6513 (comment) @LaurenWags
yes we want Reopened Close Tab and Bookmark All Tabs... back. We can wait until 1.3 for it. I moved the milestone.

Close Other Tabs was restored with 1.0.1 and Chromium 78.0.3904.108

[btlechowski]

Verification passed on

Brave	1.3.38 Chromium: 78.0.3904.108 (Official Build) nightly (64-bit)
Revision	4b26898a39ee037623a72fcfb77279fce0e7d648-refs/branch-heads/3904@{#889}
OS	Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#3875
Verified that the Menu options actually work.

Verification passed on

Brave	1.3.75 Chromium: 79.0.3945.88 (Official Build) dev (64-bit)
Revision	c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

• Verified test plan from Restore deleted tab context menu brave-core#3875
• Verified that the Menu options actually work.
  

Verified passed with

Brave	1.3.85 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
Revision	c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS	macOS Version 10.14.6 (Build 18G103)

• Verified test plan from Restore deleted tab context menu brave-core#3875
• Verified that Reopen Closed Tab and Bookmark All Tabs context menu items work.

Verification passed on

Brave	1.3.85 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
Revision	c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

• Verified test plan from Restore deleted tab context menu brave-core#3875
• Verified that Reopen Closed Tab and Bookmark All Tabs context menu items work.