Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Transactions List in UI #10049

Merged
merged 1 commit into from
Sep 16, 2021

Conversation

Douglashdaniel
Copy link
Contributor

Description

  1. Updated the TransactionListItem component to show Transaction Status.
  2. Built a Transaction Popup to give the ability to view transaction on Block Explorers.
  3. Implemented transaction list's for each account in the Accounts Subview.
  4. Implemented filtering transactions by Selected Asset on the Portfolio Subview page.
  5. Refactored all ORB displays to set the Address too lowercase since the return informations for transactions
    returns the sent/received address's formatted differently.
  6. Added some placeholder text to display when there are no transactions.
  7. Added Asset Portfolio Balance in the Portfolio Subview page.

Resolves brave/brave-browser#17082

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Screen.Recording.2021-09-10.at.1.19.54.PM.mov

@Douglashdaniel Douglashdaniel force-pushed the implemented-transactions-list-in-ui branch 2 times, most recently from d8fea6f to 3f695c2 Compare September 15, 2021 16:03
@Douglashdaniel Douglashdaniel force-pushed the implemented-transactions-list-in-ui branch from 3f695c2 to 7725516 Compare September 16, 2021 20:15
Copy link
Member

@onyb onyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@Douglashdaniel Douglashdaniel merged commit 9a8a658 into master Sep 16, 2021
@Douglashdaniel Douglashdaniel deleted the implemented-transactions-list-in-ui branch September 16, 2021 23:59
@Douglashdaniel Douglashdaniel added this to the 1.31.x - Nightly milestone Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement transactions list UI
2 participants