-
Notifications
You must be signed in to change notification settings - Fork 858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 1985: Properly show the widevine absence prompt. #1033
Conversation
e8c3b81
to
c0cee86
Compare
media_client->RequestMediaKeySystemAccess( | ||
WebEncryptedMediaRequest(initializer)); | ||
|
||
+ // Notify Brave about the widevine availability request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you just have 1 header file and 1 function that you insert here to minimize patching a bit here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or even 0 header files and chromium_src override and patch 1 line to call the function from the extra header in the override.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Fixes brave/brave-browser#1985 Replacing a set of hardcoded urls with a blink hook and a corresponding tab helper that updates the widevine content settings icon.
c0cee86
to
6c5c8f5
Compare
6c5c8f5
to
c125186
Compare
c125186
to
6c5c8f5
Compare
noticed tests weren't marked above so I ran them on macOS and they all passed for me. |
Ran builds and tests on linux and Windows too. All pass. |
Issue 1985: Properly show the widevine absence prompt.
Issue 1985: Properly show the widevine absence prompt.
0.59.x: 981f7f4 |
Fixes brave/brave-browser#1985
Replacing a set of hardcoded urls with a blink hook and a corresponding
tab helper that updates the widevine content settings icon.
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests
) ongit rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist: