Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1985: Properly show the widevine absence prompt. #1033

Merged
merged 1 commit into from
Dec 14, 2018
Merged

Conversation

iefremov
Copy link
Contributor

@iefremov iefremov commented Dec 6, 2018

Fixes brave/brave-browser#1985
Replacing a set of hardcoded urls with a blink hook and a corresponding
tab helper that updates the widevine content settings icon.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

media_client->RequestMediaKeySystemAccess(
WebEncryptedMediaRequest(initializer));

+ // Notify Brave about the widevine availability request.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you just have 1 header file and 1 function that you insert here to minimize patching a bit here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or even 0 header files and chromium_src override and patch 1 line to call the function from the extra header in the override.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Fixes brave/brave-browser#1985
Replacing a set of hardcoded urls with a blink hook and a corresponding
tab helper that updates the widevine content settings icon.
@bbondy
Copy link
Member

bbondy commented Dec 14, 2018

noticed tests weren't marked above so I ran them on macOS and they all passed for me.

@bbondy
Copy link
Member

bbondy commented Dec 14, 2018

Ran builds and tests on linux and Windows too. All pass.

@bbondy bbondy merged commit 1a2669f into master Dec 14, 2018
bbondy added a commit that referenced this pull request Dec 14, 2018
Issue 1985: Properly show the widevine absence prompt.
@bbondy
Copy link
Member

bbondy commented Dec 14, 2018

master (0.61.x): 1a2669f
060.x: 0b04a06

@kjozwiak
Copy link
Member

@iefremov @bbondy uplift request to 0.59.x approved after deliberating with @srirambv & @rebron 👍 Please add/remove all required labels and ensure that the associated issue is moved to the correct milestone.

bbondy added a commit that referenced this pull request Dec 14, 2018
Issue 1985: Properly show the widevine absence prompt.
@bbondy
Copy link
Member

bbondy commented Dec 14, 2018

0.59.x: 981f7f4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Purchased content from youtube doesn't prompt to install Widevine (Amazon too)
4 participants