Updated default search providers in KR #10590

simonhong · 2021-10-19T09:51:23Z

Resolves brave/brave-browser#18855

Desktop & android will have Brave Search, Daum, Naver and Google as a default search provider.

Desktop search engine settings page

Android onboarding page

Android search engine settings page

Submitter Checklist:

I confirm that no security/privacy review is needed, or that I have requested one
There is a ticket for my issue
Used Github auto-closing keywords in the PR description above
Wrote a good PR/commit description
Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
Ran git rebase master (if needed)

Reviewer Checklist:

A security review is not needed, or a link to one is included in the PR description
New files have MPL-2.0 license header
Adequate test coverage exists to prevent regressions
Major classes, functions and non-trivial code blocks are well-commented
Changes in component dependencies are properly reflected in gn
Code follows the style guide
Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Set Region settings as South Korea
Launch Brave with fresh profile
Check search engine settings has SK specific provider list - Brave, Naver, Daum and Google
Check Naver is set as an initial default provider

android/java/org/chromium/chrome/browser/onboarding/SearchEngineEnum.java

browser/ui/android/strings/android_brave_strings.grd

simonhong · 2022-06-27T07:19:50Z

@rebron @bradleyrichter Do we want to update Android onboarding with this default search provider change?
If so, I need Naver and Daum 's logo image and their description.

rebron · 2022-06-29T05:08:55Z

@timchilds @anthonypkeane We need getting assets for Daum and Naver, logo and description.

anthonypkeane · 2022-06-29T23:27:54Z

We don't show this screen in Android during onboarding. If we are, it is a bug.

simonhong · 2022-06-30T00:33:03Z

We don't show this screen in Android during onboarding. If we are, it is a bug.

@anthonypkeane This search provider onboarding is launched for first touch on omnibox.
AFAIK, it's not launched for some regions that brave search is configured as a default.
@deeppandya Am I right?

anthonypkeane · 2022-06-30T01:31:33Z

Slack Thread: https://bravesoftware.slack.com/archives/C01NNFM9XMM/p1656552687093119

deeppandya · 2022-06-30T01:33:06Z

We don't show this screen in Android during onboarding. If we are, it is a bug.
@anthonypkeane we still show the onboarding except countries listed here :

brave-core/android/java/org/chromium/chrome/browser/toolbar/top/BraveToolbarLayoutImpl.java

Line 146 in 3598a86

private static final List<String> mBraveSearchEngineDefaultRegions =

simonhong · 2022-07-06T06:53:25Z

Kindly ping for logo and description :)

anthonypkeane · 2022-07-06T21:58:58Z

@rmcfadden3 can you please help with the copy for Daum & Naver?
@Sam-Sibley could you pls provide search icons for Daum & Naver?

rmcfadden3 · 2022-07-13T17:07:51Z

How about these descriptions?

Daum: South Korean web portal & search
Naver: South Korean web portal & search

I could try to add more to differentiate them, but character count is really limited. LMK.

anthonypkeane · 2022-08-09T12:31:45Z

Hi @simonhong

#10590 (comment)

Does this work ok? Thanks

simonhong · 2022-08-09T22:44:10Z

Hi @simonhong

#10590 (comment)

Does this work ok? Thanks

@anthonypkeane Desc seems fine. and I was also waiting both providers' logo icon.
If we don't want to use different icon, I could get their official logo icon from their web site and use it.

github-actions · 2023-01-11T10:42:51Z

⚠️ PR head is an unsigned commit
commit: 68e4b7d
reason: unsigned
Please follow the handbook to configure commit signing
cc: @simonhong

github-actions · 2023-01-12T06:33:09Z

⚠️ PR head is an unsigned commit
commit: f8f14e7
reason: unsigned
Please follow the handbook to configure commit signing
cc: @simonhong

github-actions · 2023-01-12T07:10:31Z

⚠️ PR head is an unsigned commit
commit: f8f14e7
reason: unsigned
Please follow the handbook to configure commit signing
cc: @simonhong

github-actions · 2023-01-12T07:10:31Z

⚠️ PR head is an unsigned commit
commit: f8f14e7
reason: unsigned
Please follow the handbook to configure commit signing
cc: @simonhong

github-actions · 2023-01-12T07:10:49Z

⚠️ PR head is an unsigned commit
commit: 2204ec2
reason: unsigned
Please follow the handbook to configure commit signing
cc: @simonhong

github-actions · 2023-01-13T03:34:38Z

⚠️ PR head is an unsigned commit
commit: f60a04b
reason: unsigned
Please follow the handbook to configure commit signing
cc: @simonhong

deeppandya

Android changes LGTM

deeppandya · 2023-01-17T17:34:57Z

@simonhong were you able to verify the change for android on device ?

simonhong · 2023-01-17T23:26:08Z

Yes, above screenshots came from my android phone.

fix brave/brave-browser#18855 Default search provider list will include Brave Search, Naver, Daum and Google. And Naver will be set as a default provider.

Daum & Naver are listed in search provider list

goodov · 2023-01-20T08:36:47Z

chromium_src/components/search_engines/template_url_prepopulate_data.cc

@@ -81,6 +81,13 @@ const std::vector<BravePrepopulatedEngineID> brave_engines_AU_IE = {
    PREPOPULATED_ENGINE_ID_ECOSIA,
 };

+const std::vector<BravePrepopulatedEngineID> brave_engines_KR = {


I wonder why these are vectors instead of plain arrays?

Ok, I'll try to handle this as a f/u. Filed brave/brave-browser#27943

Updated default search providers in KR

kjozwiak · 2023-02-02T09:15:37Z

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.49.81 Chromium: 110.0.5481.52 (Official Build) nightly (64-bit)
-- | --
Revision | 979113183ded4544a2c443aceb1629c430907e52-refs/branch-heads/5481@{#636}
OS | Windows 11 Version 22H2 (Build 22621.1105)

`Test Case #1` - Clean Profile

installed 1.49.82 Chromium: 110.0.5481.52 and ensured that brave://settings/search was displaying the correct SE
- mentioned via Updated default search providers in KR #10590 (comment)
ensured that Naver is selected as the default SE
ensured that Brave is at the top of the Normal Window dropdown
ensured that Brave is selected as the default SE for Private Window
ensured that the correct SE are being listed via brave://settings/searchEngines
ensured that you can change the SE for both Normal & Private windows without issues
- ensured that the changes are retained after restarting the browser several times
ensured that the new default SE is also reflected via brave://settings/searchEngines

`Example`	`Example`	`Example`	`Example`	`Example`	`Example`

`Test Case #2` - Upgrade from `1.49.55 Chromium: 109.0.5414.86` --> `1.49.82 Chromium: 110.0.5481.52`

Verification FAILED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.49.82 Chromium: 110.0.5481.52 (Official Build) canary (32-bit)
--- | ---
Revision | 979113183ded4544a2c443aceb1629c430907e52-refs/branch-heads/5481@{#636}
OS | Android 13; Build/TQ1A.230105.002

`Test Case #1` - Clean Profile

installed 1.49.82 Chromium: 110.0.5481.52 and ensured that the SE onboarding is displayed when tapping on omnibox
ensured that the new SE mentioned via Updated default search providers in KR #10590 (comment) are being displayed
ensured that Naver is selected as the default SE via the SE onboarding
ensured that you can switch to different SE via Hamburger Menu -> Search engines without any issues
ensured that users choice is being retained when restarting the browser

`Example`	`Example`	`Example`	`Example`

`Test Case #2` - Upgrade from `1.49.55 Chromium: 109.0.5414.86` --> `1.49.82 Chromium: 110.0.5481.52`

Test Case #1 - Default SE (Google) selected via omnibox search onboarding

installed 1.49.55 Chromium: 109.0.5414.86 and ensured that the previous onboarding appeared once tapping on omnibox
ensured that Google was selected as the default SE via the search onboarding and continued with Google selected
ensured that Google was selected as the default SE for both Standard Tab & Private Tab

`Example`	`Example`	`Example`	`Example`

upgraded from 1.49.55 Chromium: 109.0.5414.86 --> 1.49.82 Chromium: 110.0.5481.52
ensured that Google was still set as the default SE for both Standard Tab & Private Tab
ensured that the new SE are being displayed within Standard Tab & Private Tab
ensured that Google is also being displayed via both Standard Tab & Private Tab
ensured that Brave is at the top of the list for both Standard Tab & Private Tab
ensured that you can switch to other SE after upgrading without any issues
- ensured that the changes are retained when restarting the browser several times

`Example`	`Example`	`Example`

Test Case #2 - Selecting other SE (DDG) via omnibox search onboarding

installed 1.49.55 Chromium: 109.0.5414.86 and ensured that the previous onboarding appeared once tapping on omnibox
ensured that Google was selected as the default SE via the search onboarding
select DDG as the default SE and ensure both Standard Tab & Private Tab are using DDG

`Example`	`Example`	`Example`	`Example`

upgraded from 1.49.55 Chromium: 109.0.5414.86 --> 1.49.82 Chromium: 110.0.5481.52
ensured that DDG was still set as the default SE for both Standard Tab & Private Tab
ensured that the new SE are being displayed within Standard Tab & Private Tab
ensured that DDG is also being displayed via both Standard Tab & Private Tab
ensured that Brave is at the top of the list for both Standard Tab & Private Tab
ensured that you can switch to other SE after upgrading without any issues
- ensured that the changes are retained when restarting the browser several times

`Example`	`Example`	`Example`

Test Case #3 - Selecting two different SE via Search Settings before upgrading

installed 1.49.55 Chromium: 109.0.5414.86 and ensured that the previous onboarding appeared once tapping on omnibox
ensured that Google was selected as the default SE via the search onboarding
select Startpage as the default SE and ensure both Standard Tab & Private Tab are using Startpage
changed the default SE for both Standard Tab (Bing) & Private Tab (Qwant)

`Example`	`Example`	`Example`	`Example`	`Example`

upgraded from 1.49.55 Chromium: 109.0.5414.86 --> 1.49.82 Chromium: 110.0.5481.52
ensured that Bing was still set as the default SE for Standard Tab
ensured that Qwant was still set as the default SE for Private Tab
ensured that the SE are being displayed/selected within Standard Tab & Private Tab
ensured that Brave is at the top of the list for both Standard Tab & Private Tab
ensured that you can switch to other SE after upgrading without any issues
- ensured that the changes are retained when restarting the browser several times

`Example`	`Example`	`Example`

kjozwiak · 2023-02-02T09:18:29Z

Created brave/brave-browser#28232 which should be fixed on Android before uplifting the above into 1.48.x via #16842. Also created brave/brave-browser#28235 for Desktop which also needs to be resolved/fixed before uplifting.

Also found brave/brave-browser#28262 which isn't related to the above.

fix brave/brave-browser#18855 fix brave/brave-browser#28232 fix brave/brave-browser#28235 Original PR(#10590) was reverted because it revealed another two bugs(#28232, #28235). As fixes for both bugs were merged, we can reland SK's default list.

simonhong self-assigned this Oct 19, 2021

simonhong force-pushed the default_search_provider_sk branch 2 times, most recently from 061226d to 3161ace Compare June 27, 2022 06:10

simonhong commented Jun 27, 2022

View reviewed changes

android/java/org/chromium/chrome/browser/onboarding/SearchEngineEnum.java Outdated Show resolved Hide resolved

simonhong commented Jun 27, 2022

View reviewed changes

browser/ui/android/strings/android_brave_strings.grd Outdated Show resolved Hide resolved

simonhong force-pushed the default_search_provider_sk branch from 3161ace to df6917f Compare June 27, 2022 07:13

simonhong mentioned this pull request Jul 7, 2022

remove Set default search engine screen for AT / ES / MX brave/brave-browser#23908

Closed

simonhong force-pushed the default_search_provider_sk branch from df6917f to 68e4b7d Compare January 11, 2023 10:42

simonhong force-pushed the default_search_provider_sk branch from 68e4b7d to f8f14e7 Compare January 12, 2023 06:32

simonhong changed the title ~~WIP: Updated default search provider in KR~~ Updated default search provider in KR Jan 12, 2023

simonhong marked this pull request as ready for review January 12, 2023 07:10

simonhong requested a review from a team as a code owner January 12, 2023 07:10

simonhong force-pushed the default_search_provider_sk branch from f8f14e7 to 2204ec2 Compare January 12, 2023 07:10

simonhong requested a review from bsclifton January 12, 2023 07:12

simonhong force-pushed the default_search_provider_sk branch from 2204ec2 to f60a04b Compare January 13, 2023 03:34

simonhong force-pushed the default_search_provider_sk branch from f60a04b to ea40ee5 Compare January 13, 2023 11:58

deeppandya approved these changes Jan 17, 2023

View reviewed changes

simonhong force-pushed the default_search_provider_sk branch from ea40ee5 to 25bf853 Compare January 20, 2023 02:06

simonhong changed the title ~~Updated default search provider in KR~~ Updated default search providers in KR Jan 20, 2023

simonhong added 3 commits January 20, 2023 11:28

Updated default search provider in KR

12393ab

fix brave/brave-browser#18855 Default search provider list will include Brave Search, Naver, Daum and Google. And Naver will be set as a default provider.

Updated onboarding fragment for new search provider list in KR

25a0675

Daum & Naver are listed in search provider list

Set Naver as default search provider in SK

873c691

simonhong force-pushed the default_search_provider_sk branch from 25bf853 to 873c691 Compare January 20, 2023 02:29

goodov reviewed Jan 20, 2023

View reviewed changes

goodov approved these changes Jan 23, 2023

View reviewed changes

simonhong merged commit 58dfd60 into master Jan 24, 2023

simonhong deleted the default_search_provider_sk branch January 24, 2023 11:53

github-actions bot added this to the 1.49.x - Nightly milestone Jan 24, 2023

simonhong added a commit that referenced this pull request Jan 25, 2023

Merge pull request #10590 from brave/default_search_provider_sk

46d59a9

Updated default search providers in KR

simonhong mentioned this pull request Jan 25, 2023

Updated default search providers in KR (uplift to 1.48.x) #16842

Closed

7 tasks

kjozwiak mentioned this pull request Feb 2, 2023

incorrect SE being used for Private Tab after upgrading - follow up to #18855 brave/brave-browser#28232

Closed

This was referenced Feb 6, 2023

Cache private search provider's template url data #17015

Merged

Cache private search provider's template url data on Android #17098

Merged

kjozwiak mentioned this pull request Feb 14, 2023

Revert default search provider list in SK #17089

Merged

25 tasks

simonhong mentioned this pull request Mar 6, 2023

Re-land default search provider update in South Korea #17484

Merged

25 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated default search providers in KR #10590

Updated default search providers in KR #10590

simonhong commented Oct 19, 2021 •

edited

simonhong commented Jun 27, 2022

rebron commented Jun 29, 2022

anthonypkeane commented Jun 29, 2022

simonhong commented Jun 30, 2022

anthonypkeane commented Jun 30, 2022

deeppandya commented Jun 30, 2022

simonhong commented Jul 6, 2022

anthonypkeane commented Jul 6, 2022

rmcfadden3 commented Jul 13, 2022

anthonypkeane commented Aug 9, 2022

simonhong commented Aug 9, 2022 •

edited

github-actions bot commented Jan 11, 2023

github-actions bot commented Jan 12, 2023

github-actions bot commented Jan 12, 2023

github-actions bot commented Jan 12, 2023

github-actions bot commented Jan 12, 2023

github-actions bot commented Jan 13, 2023

deeppandya left a comment

deeppandya commented Jan 17, 2023

simonhong commented Jan 17, 2023

goodov Jan 20, 2023

simonhong Jan 21, 2023

kjozwiak commented Feb 2, 2023 •

edited

kjozwiak commented Feb 2, 2023 •

edited

Updated default search providers in KR #10590

Updated default search providers in KR #10590

Conversation

simonhong commented Oct 19, 2021 • edited

Desktop search engine settings page

Android onboarding page

Android search engine settings page

Submitter Checklist:

Reviewer Checklist:

After-merge Checklist:

Test Plan:

simonhong commented Jun 27, 2022

rebron commented Jun 29, 2022

anthonypkeane commented Jun 29, 2022

simonhong commented Jun 30, 2022

anthonypkeane commented Jun 30, 2022

deeppandya commented Jun 30, 2022

simonhong commented Jul 6, 2022

anthonypkeane commented Jul 6, 2022

rmcfadden3 commented Jul 13, 2022

anthonypkeane commented Aug 9, 2022

simonhong commented Aug 9, 2022 • edited

github-actions bot commented Jan 11, 2023

github-actions bot commented Jan 12, 2023

github-actions bot commented Jan 12, 2023

github-actions bot commented Jan 12, 2023

github-actions bot commented Jan 12, 2023

github-actions bot commented Jan 13, 2023

deeppandya left a comment

Choose a reason for hiding this comment

deeppandya commented Jan 17, 2023

simonhong commented Jan 17, 2023

goodov Jan 20, 2023

Choose a reason for hiding this comment

simonhong Jan 21, 2023

Choose a reason for hiding this comment

kjozwiak commented Feb 2, 2023 • edited

Test Case #1 - Clean Profile

Test Case #2 - Upgrade from 1.49.55 Chromium: 109.0.5414.86 --> 1.49.82 Chromium: 110.0.5481.52

Test Case #1 - Clean Profile

Test Case #2 - Upgrade from 1.49.55 Chromium: 109.0.5414.86 --> 1.49.82 Chromium: 110.0.5481.52

kjozwiak commented Feb 2, 2023 • edited

simonhong commented Oct 19, 2021 •

edited

simonhong commented Aug 9, 2022 •

edited

kjozwiak commented Feb 2, 2023 •

edited

`Test Case #1` - Clean Profile

`Test Case #2` - Upgrade from `1.49.55 Chromium: 109.0.5414.86` --> `1.49.82 Chromium: 110.0.5481.52`

`Test Case #1` - Clean Profile

`Test Case #2` - Upgrade from `1.49.55 Chromium: 109.0.5414.86` --> `1.49.82 Chromium: 110.0.5481.52`

kjozwiak commented Feb 2, 2023 •

edited