Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update search version after attribution removed from Bing #12290

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Feb 16, 2022

Fixes brave/brave-browser#21085

Small step unintentionally missed with #11994 - with this value updated, browser will rebuild the table of default search engines

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@bsclifton bsclifton self-assigned this Feb 16, 2022
@simonhong simonhong merged commit 00508e7 into master Feb 16, 2022
@simonhong simonhong deleted the bsc-update-search-version branch February 16, 2022 11:12
@simonhong simonhong added this to the 1.37.x - Nightly milestone Feb 16, 2022
brave-builds pushed a commit that referenced this pull request Feb 16, 2022
@stephendonner
Copy link
Contributor

Verified PASSED using

Brave 1.37.53 Chromium: 98.0.4758.102 (Official Build) nightly (64-bit)
Revision 273bf7ac8c909cde36982d27f66f3c70846a3718-refs/branch-heads/4758@{#1151}
OS Windows 10 Version 21H2 (Build 19044.1566)

Scenario 1 - Brave search -> upgrade

  1. Install 1.35.103.
  2. Launch to create a profile, search using default SE (Brave search).
  3. Close.
  4. Rename profile to Brave-Browser-Nightly.
  5. Launch with latest 1.37.x.
  6. Do a new search from omnibox (ex. :b hats).

Confirmed resulting URL does NOT contain PC=U316&FORM=CHROMN.

example example example
21085-1 21085-2 21085-3

Scenario 2 - Bing search -> upgrade

  1. Install 1.35.103.
  2. Do not change default SE (Brave search).
  3. Search using Bing via omnibox (ex. :b shoes).
  4. Resulting URL contains PC=U316&FORM=CHROMN.
  5. Close Brave.
  6. Rename profile to Brave-Browser-Nightly.
  7. Launch with latest 1.37.x version.
  8. Do a new search from omnibox (ex. :b hats).

Confirmed final resulting URL does NOT contain PC=U316&FORM=CHROMN.

example example example example
21085-4 21085-5 21085-6 21085-7

Scenario 3: Clean profile

  1. installed 1.37.53
  2. changed default search engine to Bing
  3. searched using Bing from the omnibox (shoes)

Confirmed resulting URL does NOT contain PC=U3166&FORM=CHROMN

example example
21085-8 21085-9

Scenario 4: Upgrade w/Bing as default

  1. installed 1.35.103
  2. changed default search engine to Bing
  3. searched using Bing from the omnibox (e.g. shoes)
  4. confirmed the resulting URL contains PC=U3166&FORM=CHROMN
  5. closed Brave
  6. renamed profile to Brave-Browser-Nightly
  7. launched 1.37.53
  8. searched using the omnibox (e.g. laptop)

Confirmed resulting URL does NOT contain PC=U3166&FORM=CHROMN

example example example example example
21085-10 21085-11 21085-12 21085-13 21085-14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants