Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed wrong background color of default browser prompt dialog #13746

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Jun 13, 2022

fix brave/brave-browser#23422

Fixed by specifying color from BubbleBorder ctor.
By default, kColorDialogBackground will be picked.

This is regression from below upstream change.

https://chromium-review.googlesource.com/c/chromium/src/+/3600776
Make BubbleBorder prefer themed colors to SkColors.

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See the test plan of #8150 and check background color

fix brave/brave-browser#23422

Fixed by specifying color from BubbleBorder ctor.
By default, kColorDialogBackground will be picked.

This is regression from below upstream change.
https://chromium-review.googlesource.com/c/chromium/src/+/3600776
Make BubbleBorder prefer themed colors to SkColors.

This also fixes the signin_view_controller_delegate_views.cc code to use
a color ID instead of a locally-hardcoded SkColor.
@simonhong simonhong self-assigned this Jun 13, 2022
Copy link
Contributor

@sangwoo108 sangwoo108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@simonhong simonhong merged commit 7f3bf51 into master Jun 13, 2022
@simonhong simonhong deleted the default_browser_prompt_dialog_bg_color branch June 13, 2022 10:44
@simonhong simonhong added this to the 1.41.x - Nightly milestone Jun 13, 2022
emerick pushed a commit that referenced this pull request Jun 14, 2022
…_color

Fixed wrong background color of default browser prompt dialog
emerick pushed a commit that referenced this pull request Jun 15, 2022
…_color

Fixed wrong background color of default browser prompt dialog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants