Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set brave as your default browser modal popup is displayed with incorrect background color #23422

Closed
GeetaSarvadnya opened this issue Jun 13, 2022 · 7 comments · Fixed by brave/brave-core#13746
Closed

Set brave as your default browser modal popup is displayed with incorrect background color #23422

GeetaSarvadnya opened this issue Jun 13, 2022 · 7 comments · Fixed by brave/brave-core#13746
Assignees
@simonhong
Labels
bug OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes regression release-notes/exclude
Milestone
1.40.x - Release

Comments

@GeetaSarvadnya
Copy link

Description

Set brave as your default browser modal popup is displayed with incorrect background-color

Steps to Reproduce

  1. NA

Actual result:

image

Expected result:

image

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.41.58 Chromium: 103.0.5060.42 (Official Build) nightly (64-bit)
Revision de0d840bf9439c31bd86bf74f065c31fdf9b208d-refs/branch-heads/5060@{#667}
OS Windows 10 Version 21H2 (Build 19044.1706)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/qa-team @rebron @mkarolin @emerick
@simonhong
Copy link
Member

Looking now

@simonhong simonhong self-assigned this Jun 13, 2022
@simonhong simonhong added this to In progress in General Jun 13, 2022
simonhong added a commit to brave/brave-core that referenced this issue Jun 13, 2022
@simonhong
Fixed wrong background color of default browser prompt dialog
daea64b 
fix brave/brave-browser#23422

This is regression from below upstream change.
Fixed by specifying color from BubbleBorder ctor.
By default, kColorDialogBackground will be picked.

https://chromium-review.googlesource.com/c/chromium/src/+/3600776
Make BubbleBorder prefer themed colors to SkColors.

This also fixes the signin_view_controller_delegate_views.cc code to use
a color ID instead of a locally-hardcoded SkColor.
simonhong added a commit to brave/brave-core that referenced this issue Jun 13, 2022
@simonhong
Fixed wrong background color of default browser prompt dialog
c733460 
fix brave/brave-browser#23422

Fixed by specifying color from BubbleBorder ctor.
By default, kColorDialogBackground will be picked.

This is regression from below upstream change.
https://chromium-review.googlesource.com/c/chromium/src/+/3600776
Make BubbleBorder prefer themed colors to SkColors.

This also fixes the signin_view_controller_delegate_views.cc code to use
a color ID instead of a locally-hardcoded SkColor.
@simonhong simonhong mentioned this issue Jun 13, 2022
Merged
25 tasks
@simonhong
Copy link
Member

simonhong commented Jun 13, 2022 •
edited
Loading

@emerick This seems regression from cr103 update. I think fix for this also should be uplifted together with cr103 PR.

General automation moved this from In progress to Completed Jun 13, 2022
@simonhong simonhong added this to the 1.41.x - Nightly milestone Jun 13, 2022
@emerick emerick mentioned this issue Jun 13, 2022
Merged
25 tasks
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Jun 13, 2022
Closed
@stephendonner
Copy link

stephendonner commented Jun 15, 2022 •
edited
Loading

Verified PASSED using

Brave 1.41.65 Chromium: 103.0.5060.42 (Official Build) nightly (x86_64)
Revision de0d840bf9439c31bd86bf74f065c31fdf9b208d-refs/branch-heads/5060@{#667}
OS macOS Version 11.6.7 (Build 20G630)

Reproduced using 1.41.58; confirmed fixed using 1.41.65

Confirmed fix in both Light and Dark modes.

1.41.58 1.41.65(Light) 1.41.65 (Dark)
Screen Shot 2022-06-15 at 11 23 23 AM Screen Shot 2022-06-15 at 11 28 46 AM Screen Shot 2022-06-15 at 11 31 58 AM

@kjozwiak
Copy link
Member

This is being uplifted as part of brave/brave-core#13755 and can be verified using 1.40.101 or higher 👍 We should probably re-check to make sure that the above was actually fixed with C103 now that we've merged it into 1.40.x.

@MadhaviSeelam
Copy link

MadhaviSeelam commented Jun 16, 2022 •
edited
Loading

Brave 1.40.101 Chromium: 103.0.5060.42 (Official Build) (64-bit)
Revision de0d840bf9439c31bd86bf74f065c31fdf9b208d-refs/branch-heads/5060@{#667}
OS Windows 11 Version 21H2 (Build 22000.739)

Confirmed correct modal popup in Win 11 x64

Dark Light
image image

@stephendonner
Copy link

Verified PASSED using

Brave 1.40.101 Chromium: 103.0.5060.42 (Official Build) (x86_64)
Revision de0d840bf9439c31bd86bf74f065c31fdf9b208d-refs/branch-heads/5060@{#667}
OS macOS Version 11.6.7 (Build 20G630)
Dark Light
Screen Shot 2022-06-16 at 12 01 45 PM Screen Shot 2022-06-16 at 12 00 10 PM

@kjozwiak
Copy link
Member

Verification PASSED on PopOS 22.04 x64 using the following build(s):

Brave | 1.40.105 Chromium: 103.0.5060.53 (Official Build) (64-bit)
--- |---
Revision | a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS | Linux
Example (Light Theme) Example (Dark Theme)
image image

@rebron rebron removed this from Completed in General Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
bug OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes regression release-notes/exclude
Projects
None yet
Milestone
1.40.x - Release
Development

Successfully merging a pull request may close this issue.

Fixed wrong background color of default browser prompt dialog brave/brave-core
5 participants
@stephendonner @kjozwiak @simonhong @GeetaSarvadnya @MadhaviSeelam