Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet): show solana connection status and permission #15094

Merged
merged 2 commits into from
Sep 16, 2022

Conversation

Pavneet-Sing
Copy link
Contributor

@Pavneet-Sing Pavneet-Sing commented Sep 14, 2022

Resolves brave/brave-browser#24810

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Note: Wallet icon will disappear on page refresh so the wallet should be locked and connect wallet should be triggered to view the wallet icon: Linked issue brave/brave-browser#25258
(Demo is recorded by keeping the wallet icon visible always to mimic desktop's test plan)

Test plan is same as desktop: #13993

solana-dapps-status.webm

@Pavneet-Sing Pavneet-Sing requested a review from a team as a code owner September 14, 2022 11:25
@Pavneet-Sing Pavneet-Sing self-assigned this Sep 14, 2022
@Pavneet-Sing Pavneet-Sing force-pushed the implement-solana-connection-status branch from 73cb10d to 102b2be Compare September 14, 2022 15:24
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@Pavneet-Sing Pavneet-Sing added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Sep 16, 2022
@Pavneet-Sing Pavneet-Sing force-pushed the implement-solana-connection-status branch from 102b2be to afa0902 Compare September 16, 2022 08:41
@Pavneet-Sing Pavneet-Sing merged commit bfde918 into master Sep 16, 2022
@Pavneet-Sing Pavneet-Sing deleted the implement-solana-connection-status branch September 16, 2022 09:57
@github-actions github-actions bot added this to the 1.45.x - Nightly milestone Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
2 participants