Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes clicking tipping button before opting into rewards. #15541

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

mkarolin
Copy link
Collaborator

Resolves brave/brave-browser#26109

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin requested a review from a team as a code owner October 19, 2022 18:47
@mkarolin mkarolin self-assigned this Oct 19, 2022
@mkarolin mkarolin force-pushed the maxk-fix-tipping-buttons-before-optin branch from 5cc4bb0 to 29dd5c8 Compare October 19, 2022 21:15
@mkarolin mkarolin added this to the 1.47.x - Nightly milestone Oct 19, 2022
@mkarolin mkarolin merged commit 2bdc68a into master Oct 19, 2022
@mkarolin mkarolin deleted the maxk-fix-tipping-buttons-before-optin branch October 19, 2022 22:38
brave-builds pushed a commit that referenced this pull request Oct 19, 2022
@LaurenWags
Copy link
Member

LaurenWags commented Oct 25, 2022

Verified with

Brave | 1.47.16 Chromium: 107.0.5304.62 (Official Build) nightly (x86_64)
-- | --
Revision | 1eec40d3a5764881c92085aaee66d25075c159aa-refs/branch-heads/5304@{#942}
OS | macOS Version 12.6.1 (Build 21G217)

Verified STR from brave/brave-browser#26109 (comment):

Twitter - PASSED
  1. Fresh profile, relaunch to pull griffin seed
  2. Go to twitter.com/emerick (or reddit.com/u/cryptojennie or open this GH issue)
  3. Click on an in-line tip button somewhere on the page
  4. Confirmed panel opened to show onboarding
1 47 x twitter
Reddit - PASSED
  1. Fresh profile, relaunch to pull griffin seed
  2. Go to reddit.com/u/cryptojennie
  3. Click on an in-line tip button somewhere on the page
  4. Confirmed panel opened to show onboarding
1 47 x reddit
GitHub - PASSED
  1. Fresh profile, relaunch to pull griffin seed
  2. Go to this issue
  3. Click on an in-line tip button somewhere on the page
  4. Confirmed panel opened to show onboarding
1 47 x GH

Verified Case 4 from brave/brave-browser#14277 (comment) for the in-line tip buttons:

Case 4 - In-line tip button - PASSED
  1. Fresh profile, relaunch to pull griffin seed
  2. Go to twitter.com/emerick
  3. Click on an in-line tip button
  4. Panel is displayed, but do not opt in to rewards. Close panel.
  5. Check for calls to *.rewards.brave.com
  6. Confirm no calls to *.rewards.brave.com
  7. Go to github.com/miyayes
  8. Click on an in-line tip button
  9. Panel is displayed, but do not opt in to rewards. Close panel.
  10. Check for calls to *.rewards.brave.com
  11. Confirm no calls to *.rewards.brave.com
  12. Go to reddit.com/u/cryptojennie
  13. Click on an in-line tip button
  14. Panel is displayed, but do not opt in to rewards. Close panel.
  15. Check for calls to *.rewards.brave.com
  16. Confirm no calls to *.rewards.brave.com
  17. Open NTP
  18. Check for calls to *.rewards.brave.com
  19. Confirm no calls to *.rewards.brave.com
  20. Open browser Task Manager and confirm Ledger service is not running
Step 6 Step 11 Step 16 Step 19 Step 20
6 11 16 19 20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants