Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added don't show again button to obsolete system infobar #16270

Merged

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Dec 7, 2022

fix brave/brave-browser#27122

W/o this, user will see this infobar whenever brave is launched.

Screenshot 2022-12-07 161035

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Launch Brave on Win7/8 and check obsolete system infobar with don't show again button is shown
  2. Click don't show again button and check infobar is hidden
  3. Relaunch and check this infobar is not shown anymore

@simonhong simonhong requested a review from rebron December 7, 2022 07:26
@simonhong simonhong self-assigned this Dec 7, 2022
@github-actions github-actions bot added the potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false label Dec 7, 2022
@simonhong simonhong force-pushed the add_dont_show_again_button_to_obsolete_system_infobar branch from 9c39243 to 95db0a3 Compare December 7, 2022 07:27
@simonhong simonhong marked this pull request as ready for review December 7, 2022 07:48
@simonhong simonhong requested a review from a team as a code owner December 7, 2022 07:48
@simonhong simonhong marked this pull request as draft December 7, 2022 08:06
@simonhong
Copy link
Member Author

Set as draft because kSuppressUnsupportedOSWarning prefs should be cleared when user did os update.

@simonhong simonhong marked this pull request as ready for review December 8, 2022 04:14
@simonhong simonhong force-pushed the add_dont_show_again_button_to_obsolete_system_infobar branch from 95db0a3 to edc7d7d Compare December 8, 2022 04:14
@simonhong
Copy link
Member Author

It's ready to review. PTAL :)

Copy link
Contributor

@sangwoo108 sangwoo108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But I'm not quite sure if it's good to suppress this warning. I feel like users could be exposed to potential danger by using an obsolete version - some security patches could be missing for these systems, I guess. So, I would prefer showing the warning even if it bothers them so that they could feel like updating the system. But it's just my persnoal preference.

browser/brave_browser_process_impl.cc Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2022

⚠️ PR head is an unsigned commit
commit: edc7d7d
reason: unsigned
Please follow the handbook to configure commit signing
cc: @simonhong

@simonhong simonhong merged commit be2f3ca into master Dec 8, 2022
@simonhong simonhong deleted the add_dont_show_again_button_to_obsolete_system_infobar branch December 8, 2022 13:28
@github-actions github-actions bot added this to the 1.48.x - Nightly milestone Dec 8, 2022
brave-builds added a commit that referenced this pull request Dec 20, 2022
brave-builds added a commit that referenced this pull request Dec 20, 2022
simonhong added a commit that referenced this pull request Dec 21, 2022
…solete_system_infobar

Added don't show again button to obsolete system infobar
@kjozwiak
Copy link
Member

LGTM. But I'm not quite sure if it's good to suppress this warning. I feel like users could be exposed to potential danger by using an obsolete version - some security patches could be missing for these systems, I guess. So, I would prefer showing the warning even if it bothers them so that they could feel like updating the system. But it's just my persnoal preference.

Just adding some more context, users would also be able to see a warning regarding their Brave installs not getting updates via brave://settings/help as well whenever they go into Settings -> About Brave. Granted, not sure how many users would actually go there.

simonhong added a commit that referenced this pull request Jan 19, 2023
…solete_system_infobar

Added don't show again button to obsolete system infobar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false
Projects
None yet
4 participants