-
Notifications
You must be signed in to change notification settings - Fork 845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added don't show again button to obsolete system infobar #16270
Added don't show again button to obsolete system infobar #16270
Conversation
9c39243
to
95db0a3
Compare
Set as draft because |
fix brave/brave-browser#27122 W/o this, user will see this infobar whenever brave is launched.
95db0a3
to
edc7d7d
Compare
It's ready to review. PTAL :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But I'm not quite sure if it's good to suppress this warning. I feel like users could be exposed to potential danger by using an obsolete version - some security patches could be missing for these systems, I guess. So, I would prefer showing the warning even if it bothers them so that they could feel like updating the system. But it's just my persnoal preference.
|
…solete_system_infobar Added don't show again button to obsolete system infobar
Just adding some more context, users would also be able to see a warning regarding their Brave installs not getting updates via |
…solete_system_infobar Added don't show again button to obsolete system infobar
fix brave/brave-browser#27122
W/o this, user will see this infobar whenever brave is launched.
Resolves
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
don't show again
button is showndon't show again
button and check infobar is hidden