Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ZCash feature flag #20145

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Add ZCash feature flag #20145

merged 1 commit into from
Sep 15, 2023

Conversation

cypt4
Copy link
Collaborator

@cypt4 cypt4 commented Sep 13, 2023

Resolves brave/brave-browser#32104

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@cypt4 cypt4 requested a review from a team as a code owner September 13, 2023 16:23
@github-actions github-actions bot added CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) feature/web3/wallet feature/web3/wallet/core labels Sep 13, 2023
@darkdh
Copy link
Member

darkdh commented Sep 13, 2023

Why are we adding feature flag when there is nothing to be enabled? This will be just a flag and when users enable it, nothing happened.
Normally feature flag is only added when the feature is nearly complete.

@darkdh
Copy link
Member

darkdh commented Sep 13, 2023

@bbondy said this does no harm so I'm fine with adding this feature flag in any order.

@cypt4 cypt4 merged commit 9d6ad1c into master Sep 15, 2023
15 checks passed
@cypt4 cypt4 deleted the brave_32104 branch September 15, 2023 08:53
@github-actions github-actions bot removed the CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) label Sep 15, 2023
@github-actions github-actions bot added this to the 1.60.x - Nightly milestone Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ZCash] Add Zcash flag to brave://flags
3 participants