Upgrade from Chromium 125 to Chromium 126 #23233

….0.6478.17.

This change adds a way to patch the inclusion/exclusion file used by the clang plugin to determine which files should have this clang warning enabled. Due to redirect_cc, all files have `src/` prepended to their paths. This breaks the way the filter for the clang plugin works, effectively enabling the warning for all paths, as no path in chromium starts that way. This change adds a way to patch the txt file to duplicate the entries to also have their `src/` preppended corresponding entries. Chromium change: https://chromium.googlesource.com/chromium/src/+/e7db1e3f3da734dc1baebac6b45b924136106d63 commit e7db1e3f3da734dc1baebac6b45b924136106d63 Author: danakj <danakj@chromium.org> Date: Tue Apr 16 20:43:24 2024 +0000 Next generation control of unsafe-buffers-usage plugin Allow per-file control of warnings without clobbering the whole build. Do this in a way that allows us to mark all dirty files in individual directories incrementally, then work to remove those markings. Default to checking all source files except: * generated files * system headers Opt paths out of being checked by putting them in the paths file with a `-` at the start of the line: ``` -not_checked/ ``` Opt paths into being checked (overriding the above) by putting them in the paths file with a `+` at the start of the line: ``` +not_checked/actually_checked_though/ ``` Individual files can be opted in/out of checks without clobbering the whole build by using pragmas, which can appear anywhere in the file and will apply to the whole file, but not get applied to other files that include it or are included into it. To opt a file out of checks: ``` // TODO: crbug.com/XYZ - Remove unsafe pointer usage in this file. #pragma allow_unsafe_buffers ``` To opt a file into checks: ``` #pragma check_unsafe_buffers ``` Bug: 41497066, 40284755

The override in this file was there to force the use of the CR2023 code path, which is now the default. Chromium change: https://chromium.googlesource.com/chromium/src/+/389f3604766cdc60a58a333a6b16b120fd9ad1da commit 389f3604766cdc60a58a333a6b16b120fd9ad1da Author: Elaine Chien <elainechien@chromium.org> Date: Tue Apr 16 17:04:57 2024 +0000 [ChromeRefresh2023] Make update row stand out in app menu Per UX requests. See bug for details. This CL also removes the ChromeRefresh2023 feature check for adding the Chrome Refresh color mixer since Chrome Refresh has been fully launched. Bug: 40935744

This is just a renaming of the type and adjust of the inclusion paths. Chromium changes: https://chromium.googlesource.com/chromium/src/+/edb30060cd059433b7742fa6f92a098982093098 commit edb30060cd059433b7742fa6f92a098982093098 Author: Jacques Newman <janewman@microsoft.com> Date: Tue Apr 16 22:37:02 2024 +0000 [Views AX] Rename AXEventNotificationDetails to AXUpdatesAndEvents in CL: 5445074, we decided we wanted to do a move and rename, unfortunately git would then see it as a delete/add, so the rename portion of the change has been split into this CL Bug: 40672441 https://chromium.googlesource.com/chromium/src/+/517ba184fb7f897aab75db7c75392ff4ece013b4 commit 517ba184fb7f897aab75db7c75392ff4ece013b4 Author: Jacques Newman <janewman@microsoft.com> Date: Tue Apr 16 00:51:07 2024 +0000 [Views AX] Move AXEventNotificationDetails to ui/accessibility/ In preparation of moving BrowserAccessibility and BrowserAccessibilityManager to the ui/ layer, I am working to move anything that can be done ahead of time. `AXEventNotificationDetails` is referenced by BrowserAccessibilityManager and several of its platform specific implementations, and will need to be moved out of content/ so it can continue to be used by the moved classes. Moving BrowserAccessibility and BrowserAccessibilityManager to the UI layer will allow us to share the functionality of these classes with Views as well, allowing us to have a consistent accessibility implementation, while also enabling Views to utilize our caching mechanisms, allowing us to stop recomputing everything on each accessibility API call to views. Bug: 40672441

A constant referenced in brave has been moved into a namespace, and this change corrects that. Chromium change: https://chromium.googlesource.com/chromium/src/+/71303418b7bfe66d0b7994e2b46201013d7f36bc commit 71303418b7bfe66d0b7994e2b46201013d7f36bc Author: dljames <dljames@chromium.org> Date: Tue Apr 16 16:48:36 2024 +0000 [ TabRestore ] Move restore types out of TabRestoreService Moves the tab restore structs Entry, Tab, Group, and Window out of the TabRestoreService and into its own file. The goal of this CL is to decouple LiveTabContext from TabRestoreService, which includes LiveTabContext. Doing this will allow us to pass the Tab, Group, and Window types as parameters to functions such as LiveTabContext::AddRestoredTab instead of passing all the fields of the objects individually. Change-Id: I2f30bb25f934806112333d67ed3586dade09fe46 Bug: 334170377

An extra argument is being passed into this function, that needs to be specified with a placeholder with the device sync tests. Chromium change: https://chromium.googlesource.com/chromium/src/+/f3565e20a88080d64f8e2314d661fce9914e82bf commit f3565e20a88080d64f8e2314d661fce9914e82bf Author: Mikel Astiz <mastiz@chromium.org> Date: Tue Apr 16 11:24:43 2024 +0000 [sync] Introduce DeletionOrigin API in ModelTypeChangeProcessor The API is implemented by ClientTagBasedModelTypeProcessor but remains actually unused. ModelTypeChangeProcessor::Delete() now optionally takes a DeletionOrigin value which, if provided, makes it to the commit requests uploaded to the Sync server. Change-Id: Id3b808c42e6e6787fd8fb71be7ede9aa7242b911 Bug: 334001702

Chromium change: https://source.chromium.org/chromium/chromium/src/+/236a5a62f305419289ee89151bf8a15decf22ae6 commit 236a5a62f305419289ee89151bf8a15decf22ae6 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Tue Apr 16 13:42:02 2024 +0000 [ios] Rename GetLastUsedBrowserState() The method should not be used so renamed it to make this obvious in future code reviews: GetLastUsedBrowserStateDeprecatedDoNotUse(). Add TestChromeBrowserStateManager::GetLastUsedBrowserStateForTesting() as it is fine in test environments to access the BrowserState passed to the TestChromeBrowserStateManager constructor. Bug: 333865629, 325256948, 325256943

This change requires a few changes around `RefCountedMemory` instances are accessed, and in one case derived. This in general makes the type interface easier to understand, as the derived types provide their own underlying access. Chromium change: https://chromium.googlesource.com/chromium/src/+/529a3eba25e6a166606533fc4bd5d4363ed6760a commit 529a3eba25e6a166606533fc4bd5d4363ed6760a Author: danakj <danakj@chromium.org> Date: Thu Apr 18 20:14:56 2024 +0000 Reland "Spanify base::RefCountedMemory" This is a reland of commit 431722686bd15761e77c290b04957f01d5640a99 Fixed the null deref of scoped_refptr in the usb descriptor code, by not constructing the span from the RefCountedMemory before we know the RefCountedMemory is really there. Original change's description: > Spanify base::RefCountedMemory > > - The base class gets data() and size() as well as begin() and end() > - The virtual interface gets a span from the subclass. > - All subclasses hold a bounded type. > - Remove front_as<T>() from the base class. Use a span or data() > instead. > - Remove most use of front() from the base class, but leave the > method there just to reduce the scope/size of this CL a bit. Use > a span or data() instead. > - Rename data() in subclasses to be more specific: as_vector() or > as_string(). > - Remove the shadowing data(), and front_as(), from the vector-based > subclass that provided mutable access. Have mutable access go > through as_vector(). > - Remove the shadowing data() from the string-based subclasses that > provided mutable access. Have mutable access go through > as_string(). > > The base class provides const access to the underlying data, as not > all implementations point to mutable data. The subclasses provided > methods to access the underlying data mutably, sometimes in ways that > shadowed the base class methods (such as with front_as). When mutable > access is required, we now go through the underlying storage accessor > such as as_vector() or as_string(). > > In the X11 code there's a bunch of RefCountedMemory that are > actually unsized, since they come from void* in C APIs. So split > those off to a separate x11::UnsizedRefCountedMemory, and use that > for all reply type data fields. > > Add conversion types to move between sized and unsized, which are needed > very rarely. > > Use RefCountedMemory as a span since it converts now: > - Convert all front_as<char>() to use base::as_string_view(*mem). > - Convert make_span(mem->front(), mem->size()) to span(*mem). > - Except when mutable access is required, in which case we go through > the underlying storage type. > > Bug: 40284755 > Change-Id: Ib1c5fd61973092e3e02562646a7b3416e1070cd1 > Low-Coverage-Reason: refactoring, not new code > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5447596 > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Owners-Override: Kyle Charbonneau <kylechar@chromium.org> > Reviewed-by: Kyle Charbonneau <kylechar@chromium.org> > Commit-Queue: danakj <danakj@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1288921} Bug: 40284755

This function now receives a value, which in most cases is ignored, however is necessary to pass for forward calls of `CalculatePreferredSize` to the superclass. Chromium change: https://chromium.googlesource.com/chromium/src/+/21851324089d1c93848caf1f34c933d504f7a8a3 commit 21851324089d1c93848caf1f34c933d504f7a8a3 Author: weidongliu <weidongliu@chromium.org> Date: Tue Apr 23 16:25:26 2024 +0000 views: ImageButton use CalculatePreferredSize(SizeBounds) override. In order to ensure implementation consistency and avoid oversights, we should unify CalculatePreferredSize() and GetHeightForWidth(). Replace them with the CalculatePreferredSize(SizeBounds) overload. Bug: 40232718

This function is only being overriden to return a single value, so the arguments had never had any bearing on the result. Chromium change: https://chromium.googlesource.com/chromium/src/+/16f130dad85fd943e5bb30604a52f78e1c0f30c4 commit 16f130dad85fd943e5bb30604a52f78e1c0f30c4 Author: Mike Wasserman <msw@chromium.org> Date: Wed Apr 17 23:03:30 2024 +0000 Fullscreen: Remove unused params from CanEnterFullscreenMode[ForTab] Bug: None

This function is used only in a test, and FROM_HERE is the correct answer anyway. Chromium change: https://chromium.googlesource.com/chromium/src/+/d81352351f602ab6c8f655d789309092005896e7 commit d81352351f602ab6c8f655d789309092005896e7 Author: Mikel Astiz <mastiz@chromium.org> Date: Wed Apr 17 14:04:42 2024 +0000 [bookmarks] Broadcast base::Location triggering deletions The general ideal is that BookmarkModelObserver should be able to provide details about which piece of code (base::Location) was responsible for issuing a deletion. The only planned consumer for this location is sync_bookmarks::BookmarkModelObserverImpl. The logic there isn't implemented yet but TODOs are added to convert this location to something that can be exposed to Sync code and consequently to the Sync server. Change-Id: If679ec259c879da2318e3297ab9d4d1301e30c11 Bug: 334001702

This file now includes a header that happens to have a token similar to the one that we substitute for the override. This change preempts the header inclusion to avoid this issue. Chromium change: https://chromium.googlesource.com/chromium/src/+/42788d8dda1956d901c6cf8f1328b746d5953150 commit 42788d8dda1956d901c6cf8f1328b746d5953150 Author: Keren Zhu <kerenzhu@chromium.org> Date: Thu Apr 18 15:18:51 2024 +0000 Record site engagement score for WebUI pages Site engagement scores will provide useful information for preloading Top Chrome WebUIs. For example, if a user never uses Top Chrome WebUIs, we would disable the preloading. Adds a checkbox to chrome://site-engagement to show or hide WebUI pages. By default chrome pages are excluded. See screenshot: https://screenshot.googleplex.com/gdSS2CJ3P5Psrmq Adds a new `url_set` parameter to SiteEngagementService::GetAllDetails(). This parameter is used for filtering origins based on origin types (HTTP and/or WebUI). It defaults to include HTTP and HTTPS origins, which maintains the old behavior of this function. This patch should have no effect on existing clients of SiteEngagementService. Bug: 40168622

This change adds the mocking stub for this new pure virtual in the base class. Chromium change: https://chromium.googlesource.com/chromium/src/+/b57dda5f8e0f22f290bb5c18ffac08ed9345deff commit b57dda5f8e0f22f290bb5c18ffac08ed9345deff Author: Christine Ying <chrstne@google.com> Date: Mon Apr 22 16:14:18 2024 +0000 Replace restricted notice defaults with new functionality IsRestrictedNoticeRequired Change-Id: Iabc4c845e4b0477d5dedc964c4ef03c4f2a212aa Bug: b:335418394

This argument can now be passed into the constructor for `TrackingProtectionSettings`, and it is done so in the only place this occcurs, which is a test. Chromium change: https://chromium.googlesource.com/chromium/src/+/0a1f8dd449a54310216c130d1a59589843f14f09 commit 0a1f8dd449a54310216c130d1a59589843f14f09 Author: Michelle Abreo <michelleabreo@google.com> Date: Tue Apr 23 16:19:35 2024 +0000 [UB] Add HostContentSettingsMap to TrackingProtectionSettings. This is a precursor to adding a getter/setter function for the new content setting in TPS. Bug: b:304424308

Upstream is moving away from `SkColor`, and favouring `ui::ColorId`, therefore this function is being deprecated. However, this will require further review that might be addressed separately, so for now we just make use of the deprecated function. Chromium change: https://chromium.googlesource.com/chromium/src/+/1a06f4e794d104caf7a7bd944ff8d2e7c95fb748 commit 1a06f4e794d104caf7a7bd944ff8d2e7c95fb748 Author: EmiliaPaz <emiliapaz@chromium.org> Date: Thu Apr 18 04:02:15 2024 +0000 [Extensions-c2s] Customize allow and dismiss request buttons Configure buttons of extension entry in message section to have kText style and same background as the container. Constraints: - Adding extension entries happen at construction and while the menu is opened. - Background color override takes a SkColor, which needs color provider Instead of setting the background SkColor at construction and after, we can add a new SetBgColorIdOverride() that takes a color id. That way, we only need to set it at construction. This allows us to: - Use SetBgColorIdOverride() for other calls - Deprecate SetBgColorOverride(), since it's only used in one place (which is complicated to migrate because value is read from value::Dict to SKColor). Screenshot: https://drive.google.com/file/d/11Ijn_cx1YPqJmoIKLw4zKvQSKafF9aW5/view?usp=sharing Bug: 40879945

This change follows upstream changes to make code more ergonomic around buffer size and interacting with other types that already use `size_t`. Chromium change: https://chromium.googlesource.com/chromium/src/+/f5d24010ac66465149c6275396ccc8570d21a94d commit f5d24010ac66465149c6275396ccc8570d21a94d Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Tue Apr 9 17:05:16 2024 +0000 `size_t` in `mojo::DataPipe[Consumer|Producer]Handle`: New `size_t` API. Motivation for using `size_t` instead of `uint32_t`: * It makes it easier to interoperate with C++ container APIs that typically use `size_t`. In particular, it makes it easier to execute subsequent migration to `span` (`span::size` returns `size_t`). See also WIP CL at https://crrev.com/c/5404364. * It supports the `-Wshorten-64-to-32` work. See also crbug.com/1201109 and https://docs.google.com/document/d/1CTbQ-5cQjnjU8aCOtLiA7G6P0i5C6HpSDNlSNq6nl5E/edit?usp=sharing This CL introduces new `size_t`-based APIs in `//mojo/public/c/system/data_pipe.h`. Notes: * To support incremental migration the old `uint32_t`-based APIs have been retained in `//mojo/public/cpp/system/data_pipe.h` for now. Follow-up CLs will migrate remaining users of the old APIs outside of `//mojo`. * This CL does *not* change the C-level APIs because of the requirement to retain a stable ABI (see also the comments at the top of `//mojo/public/c/system/thunks.h`). * This CL may have introduced new integer conversions - in those cases the CL attempts to have well-defined behavior (e.g. using `base::checked_cast`). OTOH, this CL did *not* attempt to fix old integer operations (e.g. old `int` => `uint32_t` / `size_t` conversions, or old additions that may potentially overflow). Bug: 40284755

Verified this with security team. No impact, since it's an enterprise-only feature. Chromium change: https://chromium.googlesource.com/chromium/src/+/6c52ec56cbc9fc2e5a3d4bf8ac0bc2ba07415943 commit 6c52ec56cbc9fc2e5a3d4bf8ac0bc2ba07415943 Author: Sandor Major <sandormajor@google.com> Date: Thu Apr 18 20:04:03 2024 +0000 Delete LegacyTechReportEnableCookieIssueReports flag and related code Bug: b/324847121, 330367496

This flag has been deleted and the behaviour made the default. However, this change adds an override to keep the state of the code as it was before. Chromium change: https://chromium.googlesource.com/chromium/src/+/b325d75f6afebe0bb76b4bcd623eda184cefbcae commit b325d75f6afebe0bb76b4bcd623eda184cefbcae Author: Dave Tapuska <dtapuska@chromium.org> Date: Tue Apr 23 01:34:14 2024 +0000 [code health] Remove kSignedExchangeReportingForDistributors It shipped in M74 remove the feature flag. Bug: 40604536

This flag was unused, which means that at some point it had been gutted. This change removes any mentions of it Chromium change: https://chromium.googlesource.com/chromium/src/+/89015bf2e0576f74ad9486de7e0b4704920ec8d3 commit 89015bf2e0576f74ad9486de7e0b4704920ec8d3 Author: Fiona Macintosh <fmacintosh@google.com> Date: Fri Apr 19 17:50:18 2024 +0000 Remove unused CookieSettingsUiAlignment feature

This function was being overriden into a file that has been deleted and replaced by `google_apis/google_api_keys-inc.cc`. This change corrects the override file accordingly. Chromium change: https://chromium.googlesource.com/chromium/src/+/6d65d3f71df312ebf047c2b720e5875c3a6f3c6e commit 6d65d3f71df312ebf047c2b720e5875c3a6f3c6e Author: Mihai Sardarescu <msarda@chromium.org> Date: Fri Apr 5 14:06:34 2024 +0000 [google_apis] Move google_api_keys.cc to google_api_keys-inc.cc File google/google_api_keys.cc is included directly from google/google_api_keys_unittest.cc which is now forbidden by PRESUMIT and adding any new test of this new file leads to a presubmit error. This CL simply moves the file to google_api_keys-inc.cc to respect the new PRESUBMIT rules. Note: Even if file google_api_keys-inc.cc looks like a new added file, its contents are identical to the previous version of google_api_keys.cc (it is a pure move of the previous file, without any edits). Bug: None

These are general fixes for things that happen to work in a previous version due to unintentional transient inclusions.

`StringPiece` is deprecated and being replaced in certain places in upstream. Chromium change: https://chromium.googlesource.com/chromium/src/+/0b5d4d38179c0e9208625d4453fd3e496e5075d3 commit 0b5d4d38179c0e9208625d4453fd3e496e5075d3 Author: Md Hasibul Hasan <hasibulhasan873@gmail.com> Date: Sat Apr 20 01:00:13 2024 +0000 [Blink] Convert StringPiece to std::string_view in //third_party/blink The changes of this CL are made using the following script with some minor changes. Used printf for writing into files instead of echo as it was not skipping special characters like "\n" and messing up files. Script: https://issues.chromium.org/issues/40506050#comment347 Removed header "base/strings/string_piece.h" Added header "<string_view>" where applicable Replaced base::StringPiece16 with std::u16string_view Replaced base::StringPiece with std::string_view Bug: 40506050

Copied from product.icon. Chromium change: https://chromium.googlesource.com/chromium/src/+/66602ea6de9c3b3ed0f491e6765c260d8a7fc146 commit 66602ea6de9c3b3ed0f491e6765c260d8a7fc146 Author: aliaaborhamy <aliaaborhamy@google.com> Date: Wed Apr 17 18:10:53 2024 +0000 [iOS Promo] Adding chrome product icon to vector icons. The current product icon is out dated and has a frame, we will be using the new icon to generate Promos QR code with chrome product icon in the center. The new icon has been added in https://crrev.com/i/7156857 Bug: 332719682

This change corrects both calling sites as well as overriding methods that must now provide a location argument. No attempt has been done in making any use of the location data in cases where the argument is necessary to override the function. Chromium change: https://chromium.googlesource.com/chromium/src/+/cdacee55c70cc463b7079cec258de4a6d7188506 commit cdacee55c70cc463b7079cec258de4a6d7188506 Author: Mikel Astiz <mastiz@chromium.org> Date: Wed Apr 24 18:42:38 2024 +0000 [passwords] Require base::Location for PasswordStoreInterface removals This patch extends PasswordStoreInterface and all implementations with a new argument in APIs that issue password deletions. Callers must specify a base::Location, often FROM_HERE, that allows tracing where a deletion request originated. The goal is to consume this information for logging purposes, in case user reports need to be investigated. The plumbing required for Sync code to consume this information will be tackled in follow-up patches. Change-Id: I0c6bbc250ea67f10e3d5e3879f674003a86f3abc

Chromium change: https://source.chromium.org/chromium/chromium/src/+/7a8881d8676f24256d3c817fda583fff0faf48e1 commit 7a8881d8676f24256d3c817fda583fff0faf48e1 Author: Side Yilmaz <sideyilmaz@chromium.org> Date: Wed Apr 17 20:30:01 2024 +0000 Enable Safety Hub by default To be able to enable by default, this CL also makes some small changes. Such as: - PasswordStatusCheckService will be created by factory only if there is a profile store available.The profile store may not be available for OTR profile and some tests. - SafetyHubMenuNotificationService will only add password notification if PasswordStatusCheckService is not null. - PasswordStatusCheckService and NotificationPermissionReviewService will not be create with browser context anymore. This was not necessary and was causing some test to be failed whenever profile store is not available. Bug: b/40267370

…upstream Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/5f9bb54ae57a008c87f7e84e43442e42ebb795d3 [StartRefactor] Cleanup LogoMediator#updateVisibilityAndMaybeCleanUp. In this CL, we remove two parameters of 1. isParentSurfaceShown: it is always true after moving logo off Start surface toolbar. 2. shouldDestroyBridge: it is always false after moving logo off Start surface toolbar. Bug: 40221888, 40064966 Change-Id: I565d9643c8b7131500a263429a9d4edc0e442afd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5449686

…inatorSupplier` to `desktopWindowStateProvider` after upstream Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/f9ddbefd1d9a684771841f9b72753270ecc4120c [TSLO] Add AppHeaderStateProvider interface Introduce AppHeaderStateProvider interface to detangle dependencies over AppHeaderCoordinator. Bug: 332784708 Change-Id: I367e0be5ed4fde09e063625b6782030c86599bd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5430978

…ageLayout.setSearchProviderBottomMargin` are private now, so apply Java asm patching for proper inheritance at `NewTabPageLayout`. Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/4dd30b9213c2d36bf2f4d4e4cf60ad57adf8901b [LogoPolish] Only enable Logo Polish for Google doodle on NTP. This CL only enables the logo polish and adjust the logo size on NTP when the logo is a Google doodle. The behavior will look like this: For Phone: https://drive.google.com/file/d/1Sanx-LqGhzA9NjX9RZaKc4JGFyizQm8O/view?usp=sharing&resourcekey=0-G8NxGsD0ZMiwzPdkcb1jxA For Tablet: https://drive.google.com/file/d/1mQKFDLFHh8wEbrbvXAIXApiT-jC-Ykup/view?usp=sharing&resourcekey=0-Tk6_0wGgcjLRqTS1aUjVoQ Bug: 335276342 Change-Id: I3ed9235003633fa5a1d8437f7c36dc4ba91c01f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5463034

Now it has `boolean forcePhoneStyleOmnibox` Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/900a84c7d4419343f3f1532202c4ea0ff80a757c Remove unnecessary AutocompleteCoordinator members. Drive by cleanup, with the intention to adopt AsyncViewProvider. Bug: 40253396 Change-Id: Ifce983b878d3e08fbd8823019447339abf4311a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5465393

Now it has `Profile profile` Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/361f25f4657194e20941c9714d8011dcb209e88f Remove getLastUsedRegularProfile from ManageAccountDevicesLinkView. Bug: 40254448 Change-Id: I570add47faced4ab9c02a8b75f3334c04d739837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5458378

this commit is just a stub, work is in progress Related Chromium PR: https://source.chromium.org/chromium/chromium/src/+/f1f760c66d99f75606c077ceb4264057b0f39566 Use Async calls for NotificationChannelsProviderAndroid NotificationManager APIs can block the main thread. So I am working on moving all notification related calls to async. This CL will change all method in NotificationChannelsProviderAndroid to async. Because of the asynchronous calls, NotificationChannelProviderAndroid::GetRuleIterator() will no longer update the cached channels synchronously. Instead, GetRuleIterator() will schedule a async call to update channels, so later on all the observers will get notified. Additionally, SetWebsiteSettings() may have a delayed impact on GetRuleIterator(), as all the tasks are asynchronous. Will change the java side class to call the async APIs in next CL. Bug: b:242038130, b:242028843 Change-Id: Iccbac30846e83681411831c0c2e0fadda48487d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5341621

Chromium change: https://source.chromium.org/chromium/chromium/src/+/0f0b7f0ffad6c04b135823e776aed9a1fc3b4f16 commit 0f0b7f0ffad6c04b135823e776aed9a1fc3b4f16 Author: Takumi Fujimoto <takumif@chromium.org> Date: Wed Apr 17 11:36:23 2024 +0000 Add a permission prompt view for keyboard and pointer lock Add these new classes: - ExclusiveAccessPermissionPrompt - ExclusiveAccessPermissionPromptView They are based on these existing classes: - EmbeddedPermissionPrompt - EmbeddedPermissionPromptAskView - EmbeddedPermissionPromptBaseView Some code is duplicated to avoid creating a dependency on the embedded permissions code. EmbeddedPermissionPromptContentScrimView is now shared between Embedded and ExclusiveAccess permission prompts. Bug: 324147495

Chromium change: https://source.chromium.org/chromium/chromium/src/+/2091c71f8284727ab79ce74903f5989a1d35b2f3 commit 2091c71f8284727ab79ce74903f5989a1d35b2f3 Author: Erik Chen <erikchen@chromium.org> Date: Tue Apr 16 01:57:46 2024 +0000 tabs: Hook up TabInterface with LensOverlayController. This CL deletes some now unnecessary hooks in TabModel, including TabModelObserver. This CL modifies the constructor of LensOverlayController to pass a VariationsClient so that LensOverlayController continues to have minimal dependencies on Profile and Browser. Change-Id: Iacebd0e18f5c2c260f68f39c5b3a99e0f38e8452 Bug: 333791050

The upstream test that this was originally based on was marked as flakey on both Windows and Linux, but we only disabled it for Windows. Disabling it on Linux as it frequently fails there as well.

…x also" This reverts commit 3849cb0.

…ails Upstream moved AreHoverCardImagesEnabled into the TabHoverCardController, so we need to adjust our handling to ensure the continued proper initialization of hover_card_image_previews_enabled_. commit 021bc74ce312f9b245f2703c4723c1c0e91d5c0c Author: Eshwar Stalin <estalin@chromium.org> Date: Wed Apr 17 20:27:43 2024 +0000 Disabling showing memory usage in hovercards for system apps Currently we are showing memory usage in hovercards for ChromeOS system apps like Terminal which supports tabbed windows. This change disables showing memory usage in hovercards for those apps. The CL also does some refactoring to move some logic from bubble to the controller. Bug: 333605249

Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/b5d9c76ccb59dec56abb032f907d4b8c4d0c5038 [Adaptive Toolbar] Hook-up "Add to bookmarks" button to UI and settings This CL adds an "Add to bookmarks" button to the adaptive toolbar page in settings. This setting will be hidden behind a flag, so users will need to enable it in chrome:flags before they can select it in settings. This CL also adds an IPH message to the button. Bug: 1425502 Change-Id: I2fbd7c94c3d5ec0ff3ec672ff9573e593bf10112 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4348520

This is a mere change from legacy to cxx11 enum classes. Chromium change: https://chromium.googlesource.com/chromium/src/+/f70de6de6e206bbd366169d83cdc0eabff5b1b22 commit f70de6de6e206bbd366169d83cdc0eabff5b1b22 Author: Christian Dullweber <dullweber@chromium.org> Date: Fri Apr 26 14:16:05 2024 +0000 ContentSettings: Make SettingSource an enum class Bug: 40538766

This change updates the APIs to be named as `Discard` rather than `Replace`, which better reflects the actual operations being done. Chromium change: https://chromium.googlesource.com/chromium/src/+/c179a0cb7eaa23bd7ca8c21b722b9d4cc9fb760d commit c179a0cb7eaa23bd7ca8c21b722b9d4cc9fb760d Author: Erik Chen <erikchen@chromium.org> Date: Wed Apr 24 23:16:27 2024 +0000 [tabs] Clean up discard interface for Tabs. The only time that a WebContents is changed for a Tab is during tab discard. Update APIs to reflect this new constraint.

This is in line with other similar changes, where `CalculatePreferredSize` receives an `available_size` argument. Chromium change: https://chromium.googlesource.com/chromium/src/+/c142216d0c6583a4d058fc7b4c6736b39527c439 commit c142216d0c6583a4d058fc7b4c6736b39527c439 Author: weidongliu <weidongliu@chromium.org> Date: Sat Apr 27 05:29:45 2024 +0000 views: use CalculatePreferredSize(SizeBounds) in /chrome/browser/ui/views/download. In order to ensure implementation consistency and avoid oversights, we should unify CalculatePreferredSize() and GetHeightForWidth(). Replace them with the CalculatePreferredSize(SizeBounds) overload. This CL was uploaded by git cl split. Bug: 40232718

It is not necessary to provide an explicit call in tests anymore. Chromium change: https://chromium.googlesource.com/chromium/src/+/3a3362de8e20f4ba5e8aca66185af8468dcb7d8d commit 3a3362de8e20f4ba5e8aca66185af8468dcb7d8d Author: Yichen <yichenz@chromium.org> Date: Tue Apr 30 20:53:59 2024 +0000 ui: lazily create color map in color provider BUG=b:330711730

This is part of large refactoring to have this method passing an available area argument. This change adds this argument to the derived types, and instantiates it too when necessary. Chromium change: https://chromium.googlesource.com/chromium/src/+/35d902cea8ee655e5fa071809cbb8573c0cfb6b0 commit 35d902cea8ee655e5fa071809cbb8573c0cfb6b0 Author: weidongliu <weidongliu@chromium.org> Date: Mon Apr 29 17:21:49 2024 +0000 views: LabelButton use CalculatePreferredSize(SizeBounds) override. In order to ensure implementation consistency and avoid oversights, we should unify CalculatePreferredSize() and GetHeightForWidth(). Replace them with the CalculatePreferredSize(SizeBounds) overload. Because the complete implementation of this CL involves a wide range of changes. Therefore, available_size is temporarily ignored. Make it effective in subsequent CL. Currently CL only modifies overloads. Bug: 40232718

The `kForYouFre` feature flag was removed and all code around `welcome_enabled` has been deleted, which was being set always to true, to disable the first run dialogue from chromium, as brave has its own dialogue. With the deletion of this alternative codepath, the override has been updated to directly disable the first run page. Chromium change: https://chromium.googlesource.com/chromium/src/+/9813104eb5d5b3a09c67d0ab473de6adb679d74b commit 9813104eb5d5b3a09c67d0ab473de6adb679d74b Author: Jack Yammine <jyammine@google.com> Date: Tue Apr 30 13:43:46 2024 +0000 Reland Remove kForYouFre feature flag check from startup_browser_creator_impl The feature is now fully launched. This is part of the cleanup process. Reverted CL: https://crrev.com/c/5481574 The cause of the revert was fixed in https://crrev.com/c/5490294 Fixed: b:336748320 Chromium change: https://chromium.googlesource.com/chromium/src/+/808398cbb37bad2e518a0f68936dc756d471f4b6 commit 808398cbb37bad2e518a0f68936dc756d471f4b6 Author: Jack Yammine <jyammine@google.com> Date: Tue May 7 08:26:59 2024 +0000 Reland "Remove kForYouFre feature flag check from startup_tab_provider.cc" This is a reland of commit 4516af18eca36992141e13386c9a788f374f00ab The cause of the revert was fixed in https://crrev.com/c/5490294 Original change's description: > Remove kForYouFre feature flag check from startup_tab_provider.cc > > The feature is now fully launched. This is part of the cleanup process. > > Fixed: b:336965525 > Change-Id: I9232cbf8ef7b0399349e04a58e7c2e0b19b93935 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5487040 > Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org> > Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> > Auto-Submit: Jack Yammine <jyammine@google.com> > Cr-Commit-Position: refs/heads/main@{#1293168}

This enum is now represented as a scoped enum called `ProviderType`. Chromium change https://chromium.googlesource.com/chromium/src/+/d2293728254be09ec8d233fd65ac546a95f5b869 commit d2293728254be09ec8d233fd65ac546a95f5b869 Author: Christian Dullweber <dullweber@chromium.org> Date: Mon Apr 29 14:53:22 2024 +0000 ContentSettings: Make ProviderType a mojo enum Make ProviderType a mojo enum to replace the string source in ContentSettingsPatternSource. Bug: 40538766

Shutdown reason is now retrieved through a static, and the function override has to be updated accordingly. Chromium change: https://chromium.googlesource.com/chromium/src/+/4324ee65bf9228bc88edd49637412e9023be3499 commit 4324ee65bf9228bc88edd49637412e9023be3499 Author: Marc Treib <treib@chromium.org> Date: Tue Apr 30 11:46:32 2024 +0000 SyncServiceImpl cleanup: Remove second param from ResetEngine ResetEngine had two params, ShutdownReason and ResetEngineReason. ResetEngineReason is more detailed, and ShutdownReason can be derived from it. So this CL removes the ShutdownReason param. This also ensures consistency between the two. Bug: none

Chromium change: https://chromium.googlesource.com/chromium/src/+/10bcef364fc5f47784f0ad7a3ab5280354d46852 commit 10bcef364fc5f47784f0ad7a3ab5280354d46852 Author: Shari Trewin <trewin@google.com> Date: Tue Apr 30 23:30:10 2024 +0000 [Read aloud] Bundle JS files The Reading mode WebUI toolbar has some long load latency at 99th %ile. The toolbar loads ~55 js files. This CL bundles those files to reduce page loading time. This required changes to the tests to fetch dependencies from the bundled read_anything.js file. The strings.m.js file needs to be in the local directory to be referenced correctly in an optimized build. Bug: 40927698 Change-Id: I492513208c3a778c0a40d9f8b8becc01036bc542 Fixed: 335446138

…flag Chromium change: https://source.chromium.org/chromium/chromium/src/+/0d04a9b25b586afdd477fe3ef9754044d7ca23dc commit 0d04a9b25b586afdd477fe3ef9754044d7ca23dc Author: James Lee <ljjlee@google.com> Date: Tue Apr 23 12:16:34 2024 +0000 Clean up PreconnectAccountCapabilitiesBeforeSignIn feature Bug: b/324027561

Chromium change: https://source.chromium.org/chromium/chromium/src/+/a6d2d5253824d1c53a0a72c2f678008573a3a859 commit a6d2d5253824d1c53a0a72c2f678008573a3a859 Author: Andrey Davydov <andreydav@google.com> Date: Thu Apr 25 15:18:15 2024 +0000 Add Sync model type for cookies Minimal changes to introduce `ModelType::COOKIES`, no `UserSelectableType` yet. Context (internal): go/cookies-sync-type. Bug: b:318391357

Chromium change: https://source.chromium.org/chromium/chromium/src/+/8785806a79a8e17e1f1c10c5452982a0673c394c commit 8785806a79a8e17e1f1c10c5452982a0673c394c Author: Allen Bauer <kylixrd@chromium.org> Date: Thu Apr 25 15:03:05 2024 +0000 Don't show the 'Search this page with...' item in incognito mode. Removed non-IsChromeRefresh2023() code blocks. Bug: 40929941

…UIController Chromium change: https://source.chromium.org/chromium/chromium/src/+/22f1dba577f3796acd38f1238dc64804c1544053 commit 22f1dba577f3796acd38f1238dc64804c1544053 Author: Teresa Mao <temao@chromium.org> Date: Thu Apr 25 02:44:14 2024 +0000 WebUI: Migrate multiple WebUIs to WebUIConfig. BookmarksSidePanelUI ReadingListUI ShoppingInsightsSidePanelUI Bug: 40222519

…rdinator.ctor` Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/cc4bc09f39ff16e6ed59d95920c1afb7260dffe3 Wire overlay panel visibility and color to BottomAttachedUiObserver https://screencast.googleplex.com/cast/NjI1ODA3OTU5NDE4NDcwNHw2ZTllOGQ5Yy1iYg Bug: 329287585 Change-Id: Id7d85a762d827ffad24f651767db7e2d9b7623e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5472457

Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/94794635ed8558f2892ff4055c93239492448e68 [TabTearing] Restrict closing empty window after tab reparenting to desktop windowing mode Currently, when the only tab in a Chrome window is dragged out and into another Chrome window in multiwindow mode, the empty source window is closed. Restrict closing the empty window to desktop windowing mode, such a window should continue to exist in split screen after tab reparenting. Bug: 333411285 Change-Id: I71c694f4c7fdb311a455b5c4b80cf21de806a3eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5436853

…ethod Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/01bbc848cd2b08fa83a0fc0cdfef94e21c37dffc [Code Health][Clank] Clean up unused feature Incognito NTP Bug: 40258200, 40838267, 335440649 Change-Id: I8ae1135c0e1a195607e39a808a771a4ed32a6a51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5490088

Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/d3500b942cde04737bc13021173b6ffa11aaf1b9 Ensure feeds code is excluded if it is not enabled The feeds (rss) code was getting included even when enable_feed_v2 was not enabled. This also removes dead code left behind from previous recent feed-related code removal. This saves ~700k of disk space for chrome.dll when feeds are disabled. Bug: 335003908 Change-Id: I1131669b5bfb8a1e2185f23958994f2e754ca5b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5458847

Chromium change: https://source.chromium.org/chromium/chromium/src/+/70c7a2f1b48b477380b5e70c6d5755a7ce73111c commit 70c7a2f1b48b477380b5e70c6d5755a7ce73111c Author: Joshua Pawlicki <waffles@chromium.org> Date: Wed Apr 17 18:28:17 2024 +0000 Chrome/Updater: Transition keystone_infobar_delegate.mm to .cc. This is a cleanup, no change in behavior is expected. Bug: b/332911252

We are not using this UI at the moment and it blocks our bottom toolbar. Chromium change: https://source.chromium.org/chromium/chromium/src/+/b39f3a16ecb3a74e3cb5614f6038b7a5dd6e8c3d [Hub] Default enable on ToT Enable on ToT after metrics green light. Also deflake two tests that have block submit. Bug: 335250391

Chromium change: https://source.chromium.org/chromium/chromium/src/+/6f146af553664f34579e03da9f672eddd8dc04c5 commit 6f146af553664f34579e03da9f672eddd8dc04c5 Author: Teresa Mao <temao@chromium.org> Date: Wed Apr 17 19:14:00 2024 +0000 WebUI cr-toolbar-search-field: Default to CR2023 styles Bug: 326116364

This change doesn't have any relevant effects to our uses of this class. Chromium change: https://chromium.googlesource.com/chromium/src/+/ba53950109199863b9b4814f4221e21b3dbd739f commit ba53950109199863b9b4814f4221e21b3dbd739f Author: Frank Liberato <liberato@chromium.org> Date: Wed Nov 15 19:57:13 2023 +0000 [codehealth] remove NOTIFICATION_LOAD_STOP from UrlLoadObserver Introduces AllWebContentsObserver that allows tests to watch all WebContents from all tabs from all browsers. This is built on various observers, rather than the NotificationService. This code was moved from the captive portal browsertests, and generalized to support more uses. The original code has been ported over too. Builds UrlLoadObserver on top this, rather than the NotificationService, to watch for navigations. Change-Id: Id8eace40e58ec261461fa9859a2f41972f2aa51c Bug: 1174764

This flag is now deleted so there's no point in overriding upstream code to indicated it is expired. Chromium change: https://chromium.googlesource.com/chromium/src/+/747de34cff8a25a47ab3c7b4ef0e16f037beae84 commit 747de34cff8a25a47ab3c7b4ef0e16f037beae84 Author: Alison Gale <agale@chromium.org> Date: Wed May 1 23:00:36 2024 +0000 Remove expired chrome://flags entries for chrome refresh Also remove labs entries. #chrome-refresh-2023-cleanup Bug: 335861565

This flags are in a different header now, and this change merely corrects the inclusion path. Chromium change: https://chromium.googlesource.com/chromium/src/+/028530eff08eb34bb29bcda1a0d3b77348467ffe commit 028530eff08eb34bb29bcda1a0d3b77348467ffe Author: Boris Sazonov <bsazonov@chromium.org> Date: Thu May 2 15:10:00 2024 +0000 Merge signin_features.{h,cc} into signin_switches.{h,cc} No behavior changes. Bug: None

…reateWebUIController" This reverts commit ef0cf37.

This has been part of a refactoring to have views passing the available size when calculating the preferred size. The changes for brave involve change the override, and the calls to pass a default value. Chromium change: https://chromium.googlesource.com/chromium/src/+/91b134f303dcd510a31303b94a961cd3c8f49279 commit 91b134f303dcd510a31303b94a961cd3c8f49279 Author: Keren Zhu <kerenzhu@chromium.org> Date: Tue Jul 26 19:29:57 2022 +0000 Allows view::GetPreferredSize() to accept a size constraint Some views (e.g. multiline label) have a varying GetPreferredSize() that will change with respect to the width. It has caused various issues, e.g. in the Download Bubble (see g/chrome-desktop-ui/iOeDLh1m_38), where the label text is dynamically updated. Fix the above use case by, * Add view::GetPreferredSize(const SizeBounds&) that calculates a preferred size within the constraint space. * In TableLayout, request unbounded preferred sizes from children views. * Implements Label::GetPreferredSize(const SizeBounds&). This CL will not change the behavior of any views or layout managers except for the combination of Label + TableLayout. Layout managers other than TableLayout might still be problematic with multiline labels. Follow-ups will need to migrate them to call the size-constrained GetPreferredSize(). Bug: 1346889

This is part of the deletion of non-CR2023 codepaths, and the removal of this flag can't be reversed. Chromium change: https://chromium.googlesource.com/chromium/src/+/8b5d469378cce73994cea86de7c49d6fe9dc5ea4 commit 8b5d469378cce73994cea86de7c49d6fe9dc5ea4 Author: Emily Shack <emshack@chromium.org> Date: Mon May 6 21:45:58 2024 +0000 Remove kChromeRefresh2023NTB #chrome-refresh-2023-cleanup Bug: 335904250

We override `DisplayObserver::OnDisplayRemoved` for a couple of things, although we make no use of the argument passed. This event is now only available supporting more than one display being removed. This is of no consequence for our uses. Chromium change: https://chromium.googlesource.com/chromium/src/+/ba3cd346f19fb60e8c116e18d385bbaf68eef9a3 commit ba3cd346f19fb60e8c116e18d385bbaf68eef9a3 Author: Vincent Chiang <vincentchiang@google.com> Date: Mon May 6 22:09:36 2024 +0000 Migrate OnDisplayRemoved to OnDisplaysRemoved Deprecate DisplayObserver::OnDisplayRemoved and use DisplayObserver::OnDisplaysRemoved instead. Bug: 329003664

Chromium change: https://chromium.googlesource.com/chromium/src/+/940dbde5cf6bbd3dafd98052aceeac4a18bbd8c8 commit 940dbde5cf6bbd3dafd98052aceeac4a18bbd8c8 Author: Florian Leimgruber <fleimgruber@google.com> Date: Mon May 6 14:00:14 2024 +0000 Remove unused payments functions from PDM The CL doesn't attempt to remove any now-unused includes, since this requires fixing some dependency issues/IWYU violations elsewhere. This will be done in a follow-up CL. For now, we want to make sure that no new references can be added. Bug: b/322170538

The overrides for the functions affected are merely stubs and therefore this change has no functional effect to the existing code. Chromium change: https://chromium.googlesource.com/chromium/src/+/28f693e95792d6887d7bcf63534acdbec1a3c116 commit 28f693e95792d6887d7bcf63534acdbec1a3c116 Author: Camillia Smith Barnes <cammie@chromium.org> Date: Mon May 6 19:53:48 2024 +0000 Shared Storage: Add out param to indicate if denial is site-specific For privacy reasons, site-setting-specific preferences errors for cross-origin shared storage worklets need to be suppressed (i.e. shown as successes to JS, despite actually being errors). Earlier, a CL (https://crrev.com/c/5469020) hid all cross-origin preferences errors from JS. We will narrow this scope to only site- setting-specific errors in a follow-up CL (https://crrev.com/c/5502151). Here, we prepare the way by adding an out parameter to the three relevant settings methods so that we can relay whether or not a preference error, if one happens, is site-specific. Bug: 335839125

There was an override to always disable the new flow, as it was adding an edit button to the wrong dialog, however with the deletion of this code upstream there's no need for the override anymore. Chromium change: https://chromium.googlesource.com/chromium/src/+/e19372afef112655f729f7c2fe50c4b913441bee commit e19372afef112655f729f7c2fe50c4b913441bee Author: Matt Jones <mdjones@chromium.org> Date: Mon May 6 23:09:49 2024 +0000 Remove simplified save flow This patch removes the simplified save flow from the bookmarking dialog for new bookmarks. Bug: b:41496433

There is a fallback argument now that allows one to choose what sort of fallback behaviour should be used in case a favicon failed to load. This change uses what was already the default behaviour in the first place. Chromium change: https://chromium.googlesource.com/chromium/src/+/7dae47cbfcfd453e2eff4b1a5eef14b796da0ba1 commit 7dae47cbfcfd453e2eff4b1a5eef14b796da0ba1 Author: Peter Kotwicz <pkotwicz@chromium.org> Date: Thu May 2 17:12:32 2024 +0000 Consolidate LargeIconService methods This CL modifies LargeIconService::GetLargeIconRawBitmapForPageUrl() to be generic. Specifically, the modified method: - enables the caller to control what is returned if there is no big enough bitmap in the database. - renames the `desired_size_in_pixel` and makes it std::optional<int> to make its purpose clearer. The new API should enable consolidating LargeIconService::GetLargeIconRawBitmapOrFallbackStyleForPageUrl() LargeIconService::GetLargeIconImageOrFallbackStyleForPageUrl() LargeIconService::GetLargeIconRawBitmapForPageUrl() BUG=337714411

Chromium change: https://source.chromium.org/chromium/chromium/src/+/028530eff08eb34bb29bcda1a0d3b77348467ffe commit 028530eff08eb34bb29bcda1a0d3b77348467ffe Author: Boris Sazonov <bsazonov@chromium.org> Date: Thu May 2 15:10:00 2024 +0000 Merge signin_features.{h,cc} into signin_switches.{h,cc} No behavior changes. Bug: None

…bUIConfig Chromium change: https://source.chromium.org/chromium/chromium/src/+/9ce5e231047a68c9f323164ce8f5bbfd57fb661e commit 9ce5e231047a68c9f323164ce8f5bbfd57fb661e Author: Teresa Mao <temao@chromium.org> Date: Thu May 2 22:24:32 2024 +0000 WebUI: Replace WebUIConfig with DefaultWebUIConfig for less code. Update multiple UIs to inherit from DefaultWebUIConfig which reduces the amount of boilerplate code. Bug: 40222519

Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/e41a445297f4cae9d31915673a68ecc67fed97d1 ContentSettings: Replace string provider names in java code Use ProviderType enum instead of strings to identify the source of a content setting. Add a "NONE" ProviderType to replace empty source strings. Bug: 40538766 Change-Id: Ide6fbc52af50ab3604fe5ab9b41f4450fca30b8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5515011

Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/3c8f4d81103b902a3957a15315b59d082f8789da Remove getLastUsedRegularProfile from ToolbarPhone. Bug: 40254448 Change-Id: Iefb4d474c2e03314841be2f38a7c415c9ca4c4c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5505737

…pdownItemViewInfoListBuilder` class Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/4e3da51aa16578531272f86121a90a2b8196ba62 Complete OmniboxFeatures cleanup: keep Omnibox features together. This change moves OmniboxFeatures class to where all OmniboxFeatures are declared. Change-Id: I38dc816fc9c0a01bb539e6b77a521db627eb6775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5504477

Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/618819a4be308d02459fb6b06df5a00515b5ee26 Convert static methods in HomepageManager to non-static. This works towards passing in a Profile into HomepageManager and remove the static Profile access internally. Bug: 338276230 Change-Id: Ib20372f0494cf2fc75d3a51c03fa31e7d7b587f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5507082

Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/d294821b0548c2021e27ea625f9f4230d556ffbf [TSLO] Update MultiInstanceManagerApi31 to use DesktopWindowStateProvider This CL removes the boolean desktop window mode supplier used by MultiInstanceManager and injects a DesktopWindowStateProvider supplier instead, since the latter is instantiated after MultiInstanceManager on startup. Bug: 325351108 Change-Id: Ibe3c7cbb66cc0a31459d705e86ca69313d99b63a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5503037

Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/3c8f4d81103b902a3957a15315b59d082f8789da Remove getLastUsedRegularProfile from ToolbarPhone. Bug: 40254448 Change-Id: Iefb4d474c2e03314841be2f38a7c415c9ca4c4c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5505737

Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/618819a4be308d02459fb6b06df5a00515b5ee26 Convert static methods in HomepageManager to non-static. This works towards passing in a Profile into HomepageManager and remove the static Profile access internally. Bug: 338276230 Change-Id: Ib20372f0494cf2fc75d3a51c03fa31e7d7b587f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5507082

Chromium change: commit 2c885728f29b653f404e6a42da86b19e055def72 Author: Ari Chivukula <arichiv@chromium.org> Date: Mon May 6 20:03:59 2024 +0000 [CookieEnabled] Align with spec navigator.cookieEnabled currently indicates if “the user agent attempts to handle cookies” in a given context. A change in Chrome, shipping as part of third-party cookie deprecation (3PCD), would cause it to indicate whether unpartitioned cookie access is possible (causing it to return false in most cross-site iframes). We should restore the prior behavior of navigator.cookieEnabled which indicated only if cookies were enabled/disabled for the site and rely on the cross-vendor function document.hasStorageAccess to indicate if unpartitioned cookie access is possible. whatwg/html#10256 https://chromestatus.com/feature/6227655153418240 https://groups.google.com/a/chromium.org/g/blink-dev/c/xU3gTW4aTfg Bug: 335553590 Change-Id: I6cc1f2a9caea6220b6f85240ae9875a65a91d179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5464207 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Ari Chivukula <arichiv@chromium.org> Reviewed-by: Jonathan Njeunje <njeunje@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/main@{#1297071}

The token that was being substituted has been removed with the clean up of the chromium refresh entries. Chromium change: https://chromium.googlesource.com/chromium/src/+/f77256532d0704eef943adc9ea2bebbe3902d6e5 commit f77256532d0704eef943adc9ea2bebbe3902d6e5 Author: dljames <dljames@chromium.org> Date: Tue May 7 19:59:38 2024 +0000 [Send Tab To Self] Clean up ChromeRefresh2023 logic SendTabToSelfToolbarIconView now defaults to the ChromeRefresh2023 icon. #chrome-refresh-2023-cleanup Change-Id: I55e2083cb6b90a330cb844a307f3af689dccf651 Bug: 335848275

This is now a required in the function signature. The only place where this function is being called is using the standard unknown origin. Chromium change: https://chromium.googlesource.com/chromium/src/+/3a7d78f88d38fd89ccb38b8104d99c1e92637b5c commit 3a7d78f88d38fd89ccb38b8104d99c1e92637b5c Author: Mikel Astiz <mastiz@chromium.org> Date: Wed May 8 19:23:44 2024 +0000 [sync] Force explicit passing of code origin for local deletions No behavioral changes, pure refactoring for the remaining calling sites, owned by the sync team. This allows removing a temporary overload in ModelTypeChangeProcessor, forcing all callers to pass a syncer::DeletionOrigin. Callers can still use DeletionOrigin::Unspecified() if the codepath doesn't actually have information to provide fine-grained information about where the deletion originated. Change-Id: I729e73a6448ae95f2cf9fa887f29aa0f7adb6465 Bug: 334001702

The flag represented by this flag is now guarded by two flags. This change corrects the existing code to disable both new flags. Chromium change: https://chromium.googlesource.com/chromium/src/+/6f9fb45bbb643b91b90b223b3b40df1f678306e9 commit 6f9fb45bbb643b91b90b223b3b40df1f678306e9 Author: Alex Turner <alexmt@chromium.org> Date: Wed May 8 15:18:09 2024 +0000 Unbundle Private Aggregation debug mode feature from context ID features Currently, they're all bundled together. We separate out the feature that manages the requirement for third-party cookie eligibility to use debug mode from the context ID-related features. This should be a no-op as the feature is enabled by default and not affected by any Finch configs. However, the change will allow us to remove the flags from the codebase on different timelines. Bug: 40281717

This change only involves plumbing the existing isolate around. Chromium change: https://chromium.googlesource.com/chromium/src/+/eef993ddb3be1b252bbe542f44da114fd2553c7c commit eef993ddb3be1b252bbe542f44da114fd2553c7c Author: Igor Sheludko <ishell@chromium.org> Date: Tue May 7 14:31:33 2024 +0000 [bindings] Isolatify ScriptState::From(..) and friends ... in order to shave off unnecessary instructions from hot paths here and there. This CL introduces: - ScriptState::ForCurrentRealm(v8::Isolate*), - ScriptState::ForRelevantRealm(v8::Isolate*, v8::Local<v8::Object>), - ScriptState::From(v8::Isolate*, v8::Local<v8::Context>), - ScriptState::MaybeFrom(v8::Isolate*, v8::Local<v8::Context>). Removes: - ScriptState::ForRelevantRealm(v8::Isolate*, v8::Local<v8::Object>), - ScriptState::From(v8::Local<v8::Context>), - ScriptState::MaybeFrom(v8::Local<v8::Context>) in favour of version with isolate parameter. Additionally - ScriptState::ForRelevantRealm(..) is used instead of ScriptState::From(.., obj.GetCreationContext()), - ScriptState::Current(v8::Isolate*) is removed in favour of ScriptState::ForCurrentRealm(v8::Isolate*) - for uniformity, - V8PerContextData::From(context) is removed in favour of script_state->PerContextData(). This CL brings ~0.2-0.7% on Speedometer2 and Speedometer3. performance. Binary-Size: We accept binary size increase as a trade-off for Bug: 336738728

There were two overrides for this function, and one of them was relying on a call that has been now deleted. The main aspect of the second override has been merged into the first one, as this is about adding resources to `source`. Chromium change: https://chromium.googlesource.com/chromium/src/+/146afebef91c7ded0bb5e71893b5516578471a83 commit 146afebef91c7ded0bb5e71893b5516578471a83 Author: dpapad <dpapad@chromium.org> Date: Wed May 8 16:05:46 2024 +0000 WebUI: Remove webui::SetupChromeRefresh2023() helper. Bug: 326116364

…BUILD.gn

Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/44f20aacfd674f255d403fc693669d86bf5fae1e Show a dialog when ungrouping the last tab(s). Bug: 324935631 Change-Id: I4bd56ac21f4e1eca795001dcbff9c2662e312f71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5516444

…nabled arg Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/a90215339806ae4f6a512a63d84fa06063c7f3ff [SurfacePolish][CleanUp] Clean up surface polish code related with SURFACE_POLISH_LESS_BRAND_SPACE_PARAM parameter. Clean up surface polish code related with SURFACE_POLISH_LESS_BRAND_SPACE_PARAM parameter. Bug: 331667743 Change-Id: Id575285bd8d903e067e4c8c7a8edf6a433cafa16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5530104

Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/44f20aacfd674f255d403fc693669d86bf5fae1e Show a dialog when ungrouping the last tab(s). Bug: 324935631 Change-Id: I4bd56ac21f4e1eca795001dcbff9c2662e312f71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5516444

Chromium change: https://source.chromium.org/chromium/chromium/src/+/b2294323445cdef22b355708c6b4b691235c9804 commit b2294323445cdef22b355708c6b4b691235c9804 Author: Emily Shack <emshack@chromium.org> Date: Tue May 7 20:03:21 2024 +0000 Remove CustomizeChromeSupportsChromeRefresh2023 Also removes a test hack that was causing failures with these changes. The flags referenced in that hack are also getting cleaned up concurrently, and should no longer ever be false. Additionally, removes kCustomizeChromeSidePanelNoChromeRefresh2023, which is no longer used. #chrome-refresh-2023-cleanup Bug: 335903631, 335904195, 41492974

Called AddMaterialChromeColorMixer() as it registers tab search bubble's color. Maybe we want to override it later if we want to use different colors from its color set.

We were previously replacing kTranlateIcon, but now we have to replace vector_icons::kTranslateChromeRefreshIcon. Chromium change: https://source.chromium.org/chromium/chromium/src/+/b2294323445cdef22b355708c6b4b691235c9804 commit b2294323445cdef22b355708c6b4b691235c9804 Author: Emily Shack <emshack@chromium.org> Date: Tue May 7 20:03:21 2024 +0000 Remove CustomizeChromeSupportsChromeRefresh2023 Also removes a test hack that was causing failures with these changes. The flags referenced in that hack are also getting cleaned up concurrently, and should no longer ever be false. Additionally, removes kCustomizeChromeSidePanelNoChromeRefresh2023, which is no longer used. #chrome-refresh-2023-cleanup Bug: 335903631, 335904195, 41492974

Chromium change: https://source.chromium.org/chromium/chromium/src/+/1e44b05b98b8acf0228fc16b951a01f29ddb8eb1 commit 1e44b05b98b8acf0228fc16b951a01f29ddb8eb1 Author: Alison Gale <agale@chromium.org> Date: Wed May 8 16:10:49 2024 +0000 Add a default browser prompt subfolder Change-Id: I1448b98d314c2f992658e158411e4be210b90fca

These flags are all slated for deletion soon, so there's nothing to do about it. Chromium change: https://chromium.googlesource.com/chromium/src/+/5a6cfd0a1a4e97667378e7ece2594ee0e05e4e42 commit 5a6cfd0a1a4e97667378e7ece2594ee0e05e4e42 Author: dpapad <dpapad@chromium.org> Date: Thu May 9 18:27:12 2024 +0000 WebUI: Delete features::kChromeWebuiRefresh2023 feature flag. Bug: 326116364 Fixed: 335904177,335904009

This function only affects the colection of metrics that are disabled in brave. Chromium change: https://chromium.googlesource.com/chromium/src/+/9608aec64e118b14340f4ae7eac4a904ae2c9c2d commit 9608aec64e118b14340f4ae7eac4a904ae2c9c2d Author: Andy Paicu <andypaicu@chromium.org> Date: Thu May 9 09:56:46 2024 +0000 [PEPC] Only record ASK permission prompts in metrics Permission Actions should only be recorded for Ask Prompts in PEPC, so that they can be comparable to the metrics of current prompts. For context: PEPC has several views, i.e. PreviouslyDenied, PreviouslyAllowed etc. that do not exist for current bubble prompts. Bug: 1462930

This is a simplification of the use of `RandBytes`, to make use of the span interface of the function, as the pointer/size pair one has been deleted. Chromium change: https://chromium.googlesource.com/chromium/src/+/b42414ce8cb9679ccae9f811f25b9bf60c11a32b commit b42414ce8cb9679ccae9f811f25b9bf60c11a32b Author: danakj <danakj@chromium.org> Date: Fri May 10 16:06:12 2024 +0000 Remove pointer-based base::RandBytes and crypto:RandBytes There are no callers left. R=dcheng@chromium.org Bug: 40284755

The flag has been deleted with the feature, as prerender2 is the new favoured way. Chromium chnange: https://chromium.googlesource.com/chromium/src/+/00502dc6a135995ad944d9f85c611c8445cabf3c commit 00502dc6a135995ad944d9f85c611c8445cabf3c Author: Hiroki Nakagawa <nhiroki@chromium.org> Date: Fri May 10 02:18:13 2024 +0000 NoStatePrefetch: Remove unused Omnibox trigger Omnibox no longer uses NoStatePrefetch in favor of Prerender2. OBSOLETE_HISTOGRAMS=NoStatePrefetch on Omnibox is superseded by Prerender2 Change-Id: If6fc14baf4accefdd2fa0c640993a20821354e33 Bug: 335028973

A constructor has been deleted in this class, leaving the type to be instantiated only with another constructor that requires a `parent_window` to be provided. As the parent window can be passed as `nullptr`, this change uses this constructor with `nullptr` for the window, to preserve all the existing behaviour. Chromium change: https://chromium.googlesource.com/chromium/src/+/0bf35b00aade6855fc8df8e2f6b1c594da02d45a commit 0bf35b00aade6855fc8df8e2f6b1c594da02d45a Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Fri May 10 20:47:18 2024 +0000 [Extensions] Remove unused ctor on WebstoreInstallWithPrompt WebstoreInstallWithPrompt had an unused ctor. Remove it. Bug: None

This argument used to be a string. This change corrects all references to use the new enum values. Chromium change: https://chromium.googlesource.com/chromium/src/+/42390c5321b3c6c586123c49b5dcca8ac7c0b2a1 commit 42390c5321b3c6c586123c49b5dcca8ac7c0b2a1 Author: Christian Dullweber <dullweber@chromium.org> Date: Fri May 10 18:51:57 2024 +0000 ContentSettings: Remove string provider name Replace string provider name with ProviderType enum and remove conversion methods. Bug: 40538766

This flag is not being passed anymore, and therefore doesn't need to be checked against as it was the case. Chromium change: https://chromium.googlesource.com/chromium/src/+/705060d44865a923ed15e1f9a38a10234df4c79e commit 705060d44865a923ed15e1f9a38a10234df4c79e Author: Andreas Haas <ahaas@chromium.org> Date: Fri May 10 05:06:00 2024 +0000 [v8] Clean up no_alloc_direct_call_for_testing V8 fast calls can now allocate objects, trigger GC, call back to JavaScript, and throw exceptions. Therefore there is no need anymore for tests that check that API functions called by fast V8 calls don't do these things. Bug: 41492790

This component now has a visibility list entry, that requires listing, and therefore a patch is being added. Chromium change: https://chromium.googlesource.com/chromium/src/+/afe7ee3030f21235dddaac5f2fbcbfac605ff799 commit afe7ee3030f21235dddaac5f2fbcbfac605ff799 Author: dpapad <dpapad@chromium.org> Date: Mon May 13 19:20:35 2024 +0000 WebUI: Restrict visibility of //third_party/polymer/v3_0:library target. This is in preparation of making Lit the recommended framework for new Desktop WebUI development. Any new targets depending on Polymer will have to explicitly be added to the list. Once the guidance to require Lit for new development is in effect, no new additions/exceptions will be allowed. Bug: 40943652

…ed parameter anymore Related Chromium change: [SurfacePolish][CleanUp] Clean up surface polish code related with SURFACE_POLISH_LESS_BRAND_SPACE_PARAM parameter. Clean up surface polish code related with SURFACE_POLISH_LESS_BRAND_SPACE_PARAM parameter. Bug: 331667743 Change-Id: Id575285bd8d903e067e4c8c7a8edf6a433cafa16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5530104

Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/a90215339806ae4f6a512a63d84fa06063c7f3ff [SurfacePolish][CleanUp] Clean up surface polish code related with SURFACE_POLISH_LESS_BRAND_SPACE_PARAM parameter. Clean up surface polish code related with SURFACE_POLISH_LESS_BRAND_SPACE_PARAM parameter. Bug: 331667743 Change-Id: Id575285bd8d903e067e4c8c7a8edf6a433cafa16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5530104

…ated Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/a3bca21ae74b12a3373b7df0e51d46a19c8b872a Modularize webui_util.h Several desktop-only methods are moved to webui_util_desktop. These methods are marked as deprecated, as they use disallowed methods. Bug: 339497734 Change-Id: I5f58ab882b8325581ec66290f69c98131fb3b6af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5528814

This icon shows up as the Page Info icon for brave://settings, among other places. Chromium change: https://source.chromium.org/chromium/chromium/src/+/b2294323445cdef22b355708c6b4b691235c9804 commit b2294323445cdef22b355708c6b4b691235c9804 Author: Emily Shack <emshack@chromium.org> Date: Tue May 7 20:03:21 2024 +0000 Remove CustomizeChromeSupportsChromeRefresh2023 Also removes a test hack that was causing failures with these changes. The flags referenced in that hack are also getting cleaned up concurrently, and should no longer ever be false. Additionally, removes kCustomizeChromeSidePanelNoChromeRefresh2023, which is no longer used. #chrome-refresh-2023-cleanup Bug: 335903631, 335904195, 41492974

Removed upstream colors.

…password store. Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/d8a8c88e167001e6262883973dac7fed724c7a7e Reland "[UPM] Always set use_login_database_as_backend to false for android" This is a reland of commit 6183fd7d4b080a7a70ecaf123408d86101ebfdec The CL was reverted because of the tests breakage. The reason for that was that one of the bots had an outdated GMS Core version. The problem was fixed in the CL crrev.com/c/5490111. Original change's description: > [UPM] Always set use_login_database_as_backend to false for android > > IMPORTANT: Using the login database on Android will be deprecated in > about 6 months. This CL makes using the GMS Core for password storing > the default approach. > > chrome_public_apk can still be built with the login database by setting > the argument use_login_database_as_backend=true in the args.gn. > The default value of use_login_database_as_backend is set to false on > Android in this CL. > > The increase of binary size is taking place because the build flag value is changed, which causes our feature code to be compiled for Chromium builds now. Chrome builds already contain the code, so for those, this change is a no-op. > > Bug: 331746629 > Binary-Size: Size increase is unavoidable (see above) > Change-Id: Ibf3fe2d6c63bae521496d722ceebe7d0b4ac41d2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5402473 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Commit-Queue: Anna Tsvirchkova <atsvirchkova@google.com> > Cr-Commit-Position: refs/heads/main@{#1292307} Bug: 331746629 Binary-Size: Size increase is unavoidable (see above) Change-Id: I0f62a2dc0a4c764fef738995eeae666af06f9653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5493819

Chromium change: https://source.chromium.org/chromium/chromium/src/+/67a610e6329dc0bdc58408725a044871f460fa59 commit 67a610e6329dc0bdc58408725a044871f460fa59 Author: Jong Ahn <jongahn@google.com> Date: Tue May 7 00:43:47 2024 +0000 [Structured Metrics]: Remove old nearby share feature flag. It has been some time since this has launched so removing feature flag. Bug: 336801244

Chromium change: https://source.chromium.org/chromium/chromium/src/+/153730cf46e506f9306cee4896f66a8314661188 commit 153730cf46e506f9306cee4896f66a8314661188 Author: Joshua Pawlicki <waffles@chromium.org> Date: Tue Apr 16 15:14:57 2024 +0000 Reland "Chrome/Updater: Use the updater scheduler to ensure updater presence." This is a reland of commit 6c8d9f199eb403213d463b85787040c0f4736580 The original CL is patchset 1. Original change's description: > Chrome/Updater: Use the updater scheduler to ensure updater presence. > > The goal of this CL is to simplify and consolidate the number of flows > that lead to installation of the updater. This reduces contention on > the updater locks, etc, and may improve the startup performance of > Chrome and the reliability of the promotion infobar. These changes have > the following effects: > > 1. Installation of the updater and registration of Chrome will happen > 19 seconds after browser startup, rather than twice during message > loop and UI pre-initialization. > 2. The promotion infobar will be shown at that time, if necessary, > rather than right away. This is beneficial in some cases since > previously the infobar wouldn't be shown in cases where the profile > selection dialog is shown. > 3. The infobar will be shown on the first run of Chrome if needed. > 4. The infobar will shown several hours into the browsing session if > it did not previously show, or if things have changed and promotion > is now needed. > > There is still one other path to EnsureUpdater that I did not alter > here - if Chrome is restarted with a chrome://help tab open, that tab > will initiate an on-demand update check, installing the updater if > necessary. Multiple such tabs might cause contention on the locks, but > do not cause any errors. Performance issues associated with that seem > infrequent and don't justify additional complexity in my opinion. > > Fixed: b/332911252 > Change-Id: Ibdef62b1807f25e7cddaf8f41ab37ca2499cf969 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5425369 > Auto-Submit: Joshua Pawlicki <waffles@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Commit-Queue: Joshua Pawlicki <waffles@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1287969} Change-Id: If70f187f22e2ea3b557d6430e5af5afcfe3d88fe

The necessary substitution for the side panel type doesn't propagate to browser tests. This change adds an override to account for it in this new test. Chromium change: https://chromium.googlesource.com/chromium/src/+/6af23c1169286add9ccffde22ace7e4781efb981 commit 6af23c1169286add9ccffde22ace7e4781efb981 Author: Duncan Mercer <mercerd@google.com> Date: Thu May 16 00:50:34 2024 +0000 Reland "[lensoverlay] Fix side panel interactions" This reverts commit d55b86a5ac50f4ef75d71be5a2e955b1c4dd4aeb. Reason for revert: Disabled failing tests for ChromeOS. Original change's description: > Revert "[lensoverlay] Fix side panel interactions" > > This reverts commit d5923aacfdaeb3c86cb09269c9e819e1348f3c08. > > Reason for revert: Linux MSan failures > > Original change's description: > > [lensoverlay] Fix side panel interactions > > > > 1) If a side panel is open when the overlay is invoked, we > > close it and wait for it to close before taking a > > screenshot. This plays the side panel sliding close > > animation which refows the page so it is ready for the > > screenshot. > > 2) When we are closing the overlay, if our side panel is open, > > we wait close it and wait for it to finish closing before > > hiding the overlay. This allows our overlay to smoothly grow > > before hiding, making a less jarring transition. > > > > Since we are relying on events from the side panel, and other > > clients of the side panel can interrupt the sequence we are > > waiting for, it is important we never get in a stuck state. To do > > this, I added a closing interrupted event, which notifies us if > > the side panel was closing but got reopened. With this close > > interrupted event, along with precise state tracking in the > > overlay, the overlay should be robust enough to not get stuck > > waiting for side panel close/open. > > > > Bug: b:337344507, b:328296424 > > Change-Id: I5e9755e2d51831a79ce825a6d5cd6bbc042bf2c9 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5534998 > > Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org> > > Reviewed-by: Mark Pearson <mpearson@chromium.org> > > Commit-Queue: Duncan Mercer <mercerd@google.com> > > Reviewed-by: Erik Chen <erikchen@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1301006} > > Bug: b:337344507, b:328296424 > Change-Id: I499b9347691d361c9c7d45873679aeca73ac1b31 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5541053 > Commit-Queue: Kalvin Lee <kdlee@chromium.org> > Owners-Override: Kalvin Lee <kdlee@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#1301114} Bug: b:337344507, b:328296424

This change also replaces `obsoleted` with `deprecated` for iOS 16 marked types to produce warnings instead of errors for references to those types

fixes brave/brave-browser#38524 Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/d185bd9ea3aa006e8dfc789dce07f3d902886c9a [Android] Allow CachedFlags to specify test defaults This mimics fieldtrial_testing_config.json for CachedFlag in tests. It does not affect the flag value in developer builds like fieldtrial_testing_config.json does, however. Bug: 40239922 Change-Id: I8b67a6c2feeadd5ce12dcf6d41fe4c2e3e3d240f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5523173

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade from Chromium 125 to Chromium 126 #23233

Upgrade from Chromium 125 to Chromium 126 #23233

Commits on May 24, 2024