Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] - Fix History Deleting Visual Glitch #24276

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

Brandon-T
Copy link
Contributor

Summary

  • Fix a visual bug when deleting a History item -- Bug where the item still shows even though it was deleted.
  • Fix memory leak in HistoryObserver

Resolves brave/brave-browser#39144

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Test Deleting History items.

@Brandon-T Brandon-T added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 labels Jun 19, 2024
@Brandon-T Brandon-T self-assigned this Jun 19, 2024
@Brandon-T Brandon-T requested a review from a team as a code owner June 19, 2024 01:44
@Brandon-T Brandon-T merged commit d72bfae into master Jun 19, 2024
19 checks passed
@Brandon-T Brandon-T deleted the bugfix/HistoryDelete branch June 19, 2024 16:21
@github-actions github-actions bot added this to the 1.69.x - Nightly milestone Jun 19, 2024
brave-builds added a commit that referenced this pull request Jun 19, 2024
@kjozwiak
Copy link
Member

kjozwiak commented Jul 2, 2024

Verification PASSED on iPhone 11 running iOS 17.5.1 via the following build(s):

1.69.73 Chromium: 127.0.6533.26 (Official Build) nightly (64-bit) 
--- | ---
Revision | ebfe046ab117...
OS | iOS

Using the STR/Cases outlined via #24276 (comment) & brave/brave-browser#39144 (comment), ensured that removing History from Brave worked without any issues/failures as per the following:

RPReplay_Final1719960868.MP4

kjozwiak pushed a commit that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
3 participants